Commit Graph

4446 Commits

Author SHA1 Message Date
Florian Bruhin
923b726e38 Merge remote-tracking branch 'origin/pr/4220' 2018-10-04 19:28:01 +02:00
Florian Bruhin
29142f763c Use a proper data dir for PDF.js 2018-10-04 16:54:44 +02:00
Ryan Roden-Corrent
66cc5f5ea4
Add support for more values in QtColor config type.
Recent changes in the completion highlighter mandate that
config.val.colors.completion.match be changed from a QssColor to a
QtColor. However, the latter accepts fewer formats. To avoid breaking
configs, this allows QtColors to be specified using all the same formats
as QssColors, excluding gradients.

I separated the QssColor and QtColor tests as the previous approach of
generating the tests made adding tests for QtColor more complicated.

While working on this I discovered that Qt's css parser is potentially
broken around parsing hsv percentages and filed
https://bugreports.qt.io/browse/QTBUG-70897.

For consistency, I made our parser similarly broken.

You can show the bug in qutebrowser right now by noting that the
following have different effects:

```
set colors.completion.odd.bg 'hsv(100%, 100%, 100%)'
set colors.completion.odd.bg 'hsv(358, 255, 255)'
```
2018-10-02 17:30:43 -04:00
Florian Bruhin
1cedfc5470 Add test 2018-10-02 13:38:28 +02:00
Jay Kamat
2b35d04607
Select text node in tests to imitate real selections 2018-09-30 23:29:24 -07:00
Florian Bruhin
4b495303f9 Merge remote-tracking branch 'origin/pr/4191' 2018-09-30 22:01:57 +02:00
Florian Bruhin
b8be4e5915 Merge remote-tracking branch 'origin/pr/4266' 2018-09-30 21:52:35 +02:00
Florian Bruhin
96f28c6f72 Show errors on invalid --mode argument for :hint 2018-09-30 11:45:59 +02:00
Jay Kamat
322b053cbf
Merge branch 'master' of https://github.com/qutebrowser/qutebrowser into jay/visible-update-titles 2018-09-29 12:29:50 -07:00
Jay Kamat
a5f9115b2f
Only apply visibility toggle if we have >10 tabs 2018-09-29 12:26:42 -07:00
zaowen
5b089d0460 Minor requested changes 2018-09-29 02:00:42 -06:00
Florian Bruhin
f780974d07 Allow fallback=False with config.get/get_obj 2018-09-28 16:40:08 +02:00
Florian Bruhin
5527d27ba7 Merge remote-tracking branch 'origin/pr/4189' 2018-09-28 13:02:45 +02:00
Jay Kamat
3081d017ce
Move tabbedbrowser test to tabwidget 2018-09-27 23:30:54 -07:00
Jay Kamat
de148bb778
Fix tabwidget tests 2018-09-27 19:59:43 -07:00
Jay Kamat
14e55eae49
Merge remote-tracking branch 'upstream/master' into jay/max-tab 2018-09-27 19:03:15 -07:00
Jay Kamat
d64771b8e3
Clean up tab min/max width tests 2018-09-27 18:57:26 -07:00
Florian Bruhin
f3408710ba Fix webkitelem tests 2018-09-27 23:09:44 +02:00
Florian Bruhin
718376f154 Refactor JS escaping
This renames javascript.convert_js_arg() to javascript.to_js() and uses that
instead of string_escape() where possible.
2018-09-27 16:36:28 +02:00
Florian Bruhin
38a4734b9a Merge remote-tracking branch 'origin/pr/4204' 2018-09-27 16:28:30 +02:00
Florian Bruhin
905863f74e Fix lint 2018-09-27 10:08:50 +02:00
Florian Bruhin
56b8447fb9 Use callback.assert_called_with() 2018-09-27 10:06:50 +02:00
Jay Kamat
e01682f51d
Add tabs.max_width setting 2018-09-26 21:39:45 -07:00
Florian Bruhin
a27a8ada4d Use qtbot.wait_callback 2018-09-26 11:45:45 +02:00
Florian Bruhin
73cba046e5 Use wait argument with qtbot.assert_not_emitted 2018-09-26 11:27:58 +02:00
Florian Bruhin
a292664ca0 Merge remote-tracking branch 'origin/pr/4218' 2018-09-26 11:20:45 +02:00
Florian Bruhin
133ed5604e Fix lint 2018-09-26 08:43:13 +02:00
Florian Bruhin
62ea8f6ec2 Merge remote-tracking branch 'origin/pr/4245' 2018-09-26 08:42:54 +02:00
Florian Bruhin
d5826b8458 Skip visible/invisible test on Windows
See #4230
2018-09-26 08:34:31 +02:00
Florian Bruhin
9ab3188b43 Disable SSL download test on Qt 5.11.2
See #4240

Remains to be seen if it looks better on Qt 5.12, but it seems like it?
2018-09-24 18:15:06 +02:00
Florian Bruhin
04e7b89978 Add delay after zooming
It looks like zooming happens asynchronously, so we need to make sure we scroll
after zoomed in.

See #4025
2018-09-24 16:39:18 +02:00
Florian Bruhin
12a4ad18be Ignore another Chromium error
See #4025
2018-09-24 12:18:30 +02:00
Florian Bruhin
9eccaea09c Normalize mhtml for Qt 5.12
See #4025
2018-09-24 11:04:18 +02:00
Florian Bruhin
87c6b361f8 Compare strings in mhtml tests 2018-09-24 10:25:33 +02:00
Florian Bruhin
165ed19bef Qt 5.12: Ignore new warnings from in_progress_cache_impl.cc
Fixes #4247
2018-09-24 10:24:41 +02:00
Jay Kamat
77703c5263
Add benchmark for _tab_pinned 2018-09-23 22:58:48 -07:00
Florian Bruhin
25e7ee1dd0 Fix wrong signal order in test_question
This never raised because of a pytest-qt bug.
2018-09-23 21:03:03 +02:00
Florian Bruhin
1e32d1e01f Fix PDFJS/qutescheme end2end tests 2018-09-23 17:40:10 +02:00
Ryan Roden-Corrent
0fed563a02
Use QSyntaxHighlighter for completion.
This is a more "Qt" way of highlighting syntax, and works around the
problems of #4199 without resorting to complicated html escaping.

The tests are more straightforward with less mocking, but do involve
testing a private class.
2018-09-22 12:13:28 -04:00
Jay Kamat
f0568ece57
Make convert_js_arg public and use it for dispatch_element in webkit 2018-09-21 18:08:04 -07:00
Zarthur
b41d7ba203
Merge branch 'master' into master 2018-09-20 11:02:27 -06:00
zaowen
a75587f270 blah 2018-09-20 10:51:33 -06:00
zaowen
5ecfe43ebb ci dumb 2018-09-20 10:49:37 -06:00
zaowen
c4cca4755e Add adblock import directory unit test 2018-09-20 10:38:50 -06:00
Ryan Roden-Corrent
2eacf4bd94
Clean up completiondelegate tests.
Respond to code review comments to reduce mocking and clean up comments.
2018-09-18 20:40:06 -04:00
Ellis
398519762b Merge branch 'master' of https://github.com/qutebrowser/qutebrowser 2018-09-18 13:33:30 -04:00
Ellis
343de2db51 Added case for whitelisted url with * wildcard 2018-09-18 13:33:05 -04:00
Florian Bruhin
c56b950cc5 Don't open any error pages in test_invocations 2018-09-18 17:25:24 +02:00
Florian Bruhin
46435bcd2f Use always/never instead of force-on/force-off 2018-09-18 11:12:50 +02:00
Florian Bruhin
17c7663ad0 Make content.headers.referer work on QtWebEngine 2018-09-17 19:40:18 +02:00