rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
12,447 Commits 1 Branch 0 Tags 112 MiB
88b878098d
Commit Graph

36 Commits

Author SHA1 Message Date
Florian Bruhin
7dd5e4b2e6 Skip broken completion tests 
This skips test_completer and test_models - we'll reintroduce them when merging
the new completion.
 2017-07-04 15:08:04 +02:00
Florian Bruhin
822623f2ed Finally update copyrights... 2017-05-09 21:37:03 +02:00
Ryan Roden-Corrent
120379dd21 Benchmark url completion. 
This benchmark simulates what I expect to be the most common use-case for url
completion: opening completion and entering several letters.
 2017-05-03 07:43:02 -04:00
Ryan Roden-Corrent
6646bbfe1f Test config completion with a ValueList. 
The help, section, and option completion models behavee differently
with a ValueList than with a KeyValue, but previously we only tested
KeyValue.
 2016-09-14 17:26:56 -04:00
Ryan Roden-Corrent
657859524f Make completion/test_models more rigorous. 
It was checking that every expected item was in the actual item list,
but not visa-versa. This meant that extra completion items could show
up without failing the test.

This caught one bad test case. Bind completion includes aliases, but
the test did not expect this.
 2016-09-14 17:26:56 -04:00
Florian Bruhin
f3c32308d3 Merge branch 'complete-hidden-commands' of https://github.com/rcorre/qutebrowser into rcorre-complete-hidden-commands 2016-08-10 15:38:46 +02:00
Florian Bruhin
ad5008152c Move browser.webkit.history to browser.history 2016-08-10 14:45:52 +02:00
Ryan Roden-Corrent
0c43ca9f09 Don't sort command completions in models. 
The sortfilter already handles sorting, there is no reason to pre-sort
the entries in the model.
 2016-08-10 06:58:34 -04:00
Ryan Roden-Corrent
97a971624b Show bindings for aliases in completion. 
Command completions for `:bind` and `:` will now show bindings for
aliases. The binding is only included if it is bound to that alias, not
if it is bound to the command the alias points to.
 2016-08-10 06:56:44 -04:00
Ryan Roden-Corrent
709470fbe6 Clean up miscmodels and test_models. 
- Split up a long conditional into multiple variables.
- Fix a small typo in a related test.
- Remove a trailing comma from an argument list.
 2016-08-10 06:56:44 -04:00
Ryan Roden-Corrent
8dbc368d08 Refactor duplicate code for command completion. 
Consolidate the logic used to generate the command completion category
into one place. This is shared by CommandCompletionModel,
HelpCompletionModel, and BindCompletionModel.
 2016-08-10 06:56:44 -04:00
Ryan Roden-Corrent
0ea61d5f15 Show hidden commands in completion for :bind. 
There is a fair amount of duplicate code around command completion that
could probably be refactored.

Resolves #1707.
 2016-08-10 06:56:44 -04:00
Ryan Roden-Corrent
dd9470af94 Show hidden commands in help completion. 
Hidden commands are not shown in command completion as they typically
would not be run directly. However, a user might still might like to see
help for them if, for example, they are writing a script or creating a
binding.

Addresses #1707.
 2016-08-10 06:55:46 -04:00
Florian Bruhin
c40059715a Fix long line 2016-07-29 10:43:53 +02:00
Florian Bruhin
cffe2281b1 Use qtmodeltester for completion model tests 
See http://pytest-qt.readthedocs.io/en/latest/modeltester.html
See #1702
 2016-07-29 10:26:55 +02:00
Florian Bruhin
e36123735b Use a fixture for FakeWebTab 
We need to make sure qapp and tab_registry are available everywhere the
FakeWebTab class is used.
 2016-07-10 16:57:02 +02:00
Florian Bruhin
2befebaf3a Don't use properties for AbstractTab 
Otherwise exceptions in there could be hidden by Python/PyQt.

Some places are not changed yet, as there are also other renames in the
next commits.
 2016-07-08 10:05:46 +02:00
Florian Bruhin
4e5a7a891e tests: Use FakeWebTab for stubbing 2016-07-07 18:32:52 +02:00
Florian Bruhin
a3b0e7c1cb Fix indent 2016-07-01 14:38:18 +02:00
Ryan Roden-Corrent
d45acb0388 Eliminate FakeSettingSection/Value. 
Don't really need to mock these out for tests as the real classes are
simple enough.
 2016-06-30 20:12:44 -04:00
Ryan Roden-Corrent
94ec712ea8 Really clean up Qt view in completion tests. 
Missed a spot.
 2016-06-30 20:12:04 -04:00
Ryan Roden-Corrent
4178f73ed9 Move utility functions to top of test_completion. 
Just a style change.
 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
849706e310 Clean up Qt view used in completion tests. 
Add the view created during the tests to qtot so it gets cleaned up
after the test exits.
 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
ee59b133c0 Don't bother mocking a history entry. 
Use webkit.history.Entry in tests instead of FakeHistoryEntry.
 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
d6012ad95c Test delete_cur_item more cleanly. 
Reduce duplicate code by mocking out a QTreeView around the model and
setting its index.
 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
9d49f5a57d Test tab completion with multiple tabbed browsers. 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
b6652ad6bc Test completion quickmark/bookmark deletion. 
Validate that quickmarks and bookmarks can be deleted from the url
completion menu.
 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
409de10fb4 Unit test delete_cur_item for tab completion model. 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
8321c1a90f Unit test setting value completion 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
f5b1019d4d Unit test config option completion. 
Had to add the `raw` parameter to ConfigStub.get as the setting option
completion model passes this argument explicitly (although the docs say
only raw=True is supported).
 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
5255a71bc5 Unit test setting section completion. 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
16f043034f Unit test tab (buffer) completion. 
This involved adding a few stubs as well as expanding the FakeWebView.
 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
610f9b7068 Unit test session completion 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
baf8d00a20 Unit test url/quickmark/bookmark completion. 
This also adds a few more stubs/fakes to mock out the
quickmark-manager, bookmark-manager, and web-history objects.
 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
b037ec489f Add unit tests for help completion. 
Also adds a FakeConfigSection stub for stubbing out configdata.DATA.
 2016-06-30 07:26:02 -04:00
Ryan Roden-Corrent
555bdb75b5 Add unit test for CommandCompletionModel. 
This establishes a pattern that can probably be used to test any of the
completion models.

See #999.
 2016-06-30 07:26:02 -04:00