Florian Bruhin
1ada821092
Make sure config options exist
2018-02-19 22:09:54 +01:00
Florian Bruhin
cea664e396
Don't emit changed in unset if unneeded
2018-02-19 22:09:54 +01:00
Florian Bruhin
ab119975e7
Only emit changed in unset if there was a change
2018-02-19 22:09:46 +01:00
Florian Bruhin
8fead148e2
Add FIXME
2018-02-19 22:09:46 +01:00
Florian Bruhin
1409f4e564
Fix migration of tabs.persist_mode_on_change
2018-02-19 22:09:46 +01:00
Florian Bruhin
19148a4593
Fix :config-unset
2018-02-19 22:09:46 +01:00
Florian Bruhin
615c6ffe5a
Make :config-write-py work again
2018-02-19 22:09:46 +01:00
Florian Bruhin
0f907b1a77
Fix getting YAML values in test_configcommands.py
2018-02-19 22:09:46 +01:00
Florian Bruhin
75181e16fa
Fix test_models.py
...
The Config object got initialized via the config_stub fixture early, so we need
to force it to re-init its values after patching configdata.DATA.
2018-02-19 22:09:46 +01:00
Florian Bruhin
c89e804653
Fix handling of invalid types in YamlConfig
2018-02-19 22:08:42 +01:00
Florian Bruhin
87e329aee3
Fix config.dump_userconfig() with defaults
2018-02-19 22:08:42 +01:00
Florian Bruhin
f43c7fa360
Fix changing values in configutils.Values
2018-02-19 22:08:42 +01:00
Florian Bruhin
cb631d532a
Fix getting global value from configutils.Values
2018-02-19 22:08:42 +01:00
Florian Bruhin
8b666d2d2e
Try to update settings in acceptNavigationRequest
...
This still doesn't seem to update them early enough?
2018-02-19 22:08:42 +01:00
Florian Bruhin
bd6e99158e
Get rid of the second deepcopy for config values
...
There were two reasons why we deepcopy mutable objects in the config:
1) So mutations don't mess with our internal/default values.
2) So we can detect mutations and update the config.
If we're going to copy the value for 1) in maybe_copy(), we know the original
value is not going to be mutated, so we can use that directly for self._mutables
instead of making another copy.
2018-02-19 22:07:53 +01:00
Florian Bruhin
93972ff3f1
Copy value before watching it for mutations in config
...
If we copy it afterwards, we are going to mutate the copied object.
2018-02-19 22:07:53 +01:00
Florian Bruhin
ddb914dc65
Refactor YAML init
2018-02-19 22:07:53 +01:00
Florian Bruhin
8504ad6ff3
Change how iterating over Config/YamlConfig works
2018-02-19 22:07:53 +01:00
Florian Bruhin
6abb42a066
Make saving in autoconfig.yml work
2018-02-19 22:07:53 +01:00
Florian Bruhin
4691753965
Avoid running change handlers on config.clear
2018-02-19 22:07:53 +01:00
Florian Bruhin
9c670e13ce
Make clearing config work
2018-02-19 22:07:53 +01:00
Florian Bruhin
a6b979539d
Add missing configutils.py
2018-02-19 22:07:53 +01:00
Florian Bruhin
14a69d9047
Fix lint
2018-02-19 22:07:53 +01:00
Florian Bruhin
2a7998847f
Unset values properly
2018-02-19 22:07:53 +01:00
Florian Bruhin
74a7676111
Fix issues with per-domain proof-of-concept
2018-02-19 22:07:53 +01:00
Florian Bruhin
d09afdf0ee
Refactor handling of mutables with url/pattern in Config
...
This also should not copy stuff coming from the config if it's not needed.
2018-02-19 22:07:53 +01:00
Florian Bruhin
8551288efb
Start working on different per-URL storage
2018-02-19 22:07:53 +01:00
Florian Bruhin
5e50824042
Broken per-URL proof-of-concept
2018-02-19 22:07:53 +01:00
Florian Bruhin
4ed07d6062
Initial implementation of per-URL setting storage
2018-02-19 22:07:53 +01:00
gammelon
42ac3dcda0
Add Option url.open_base_url
...
when set to true, invoking a searchengine shortcut without argument
opens the baseurl of that searchengine instead of DEFAULT searchengine
2018-02-17 11:21:22 +01:00
George Edward Bulmer
9397cc74c1
Pylint indentation fix
2018-02-12 14:24:53 +00:00
George Edward Bulmer
561e5d17b9
Remove extraneous space
2018-02-12 14:22:25 +00:00
George Edward Bulmer
b59a7cdcc0
Report syntax errors as unhandled exceptions
...
Update tests accordingly
2018-02-12 14:07:05 +00:00
George Edward Bulmer
ce8b457bac
Only display exception type if no traceback
...
Update test to match
2018-02-12 13:43:22 +00:00
George Edward Bulmer
164b2a3eef
Fix a lengthy line
2018-02-11 23:20:24 +00:00
George Edward Bulmer
72103ec730
Format error type in a different way
2018-02-11 23:16:04 +00:00
George Edward Bulmer
21a50cf961
Use the repr() of the exception instead of str()
2018-02-11 17:46:09 +00:00
Florian Bruhin
d306f81130
Merge remote-tracking branch 'origin/pr/3525'
2018-02-11 10:44:27 +01:00
Florian Bruhin
6d750aff8b
Merge remote-tracking branch 'origin/pr/3430'
2018-02-10 16:27:41 +01:00
715cc7b7dd
Make statusbar widgets configurable
2018-02-10 13:15:11 +01:00
Florian Bruhin
4ac4833c93
Clean up YamlConfig._handle_migrations
2018-02-10 11:44:18 +01:00
Marc Jauvin
504e29c004
fix configfiles tests
...
- fix test_renamed_key()
- fix test_deleted_key()
- combine both test_merge_persist tests using @pytest.mark.parametrize
- fix _handle_migrations(): mark data dirty for renamed and deleted
2018-02-09 21:25:11 -05:00
Marc Jauvin
9b7db8ee8a
Need to mark config as dirty in _handle_migrations()
...
Add tests for tabs.persist_mode_on_change migration
2018-02-09 14:41:33 -05:00
Marc Jauvin
85dfe5c403
add special code to migrate tabs.persist_mode_on_change setting to tabs.mode_on_change.
2018-02-09 11:28:21 -05:00
Marc Jauvin
f3b52aaf23
fix asciidoc for tabs.mode_on_change
2018-02-09 10:39:02 -05:00
Marc Jauvin
a7db197e45
replace persist_mode_on_change with mode_on_change
...
supports old persist_mode_on_change functionality or new save/restore mode
2018-02-09 10:39:02 -05:00
Florian Bruhin
3e38aab0f6
Document configdata.Migrations
2018-02-09 11:31:25 +01:00
Florian Bruhin
1a81f7231b
Make sure multiple wrong keys are reported
2018-02-08 22:02:22 +01:00
Florian Bruhin
298dcb4c90
Validate config separately from migrations
...
It makes for cleaner code, and it makes sure the target of renamed options
actually exists.
2018-02-08 21:49:41 +01:00
Florian Bruhin
3306247ae5
Merge branch 'editor-watch'
2018-02-07 22:31:49 +01:00
Florian Bruhin
6f028e9ad0
Update copyright years
2018-02-05 12:19:50 +01:00
Florian Bruhin
c8de4675db
Various spelling fixes
2018-02-04 21:30:59 +01:00
Ryan Roden-Corrent
833df95485
Only detect save for open-editor and config-edit.
...
Scope down the new trigger-on-save behavior to only open-editor and
config-edit. Other uses of the editor such as edit-url and edit-command
will behave as before.
2018-02-03 19:57:47 -05:00
Marc Jauvin
1a2ab0ffe7
add back rl-yank key binding; use alt-y for prompt-yank.
2018-01-28 10:28:11 -05:00
Ryan Roden-Corrent
a940de3717
Rename editing_finished to file_updated.
...
ExternalEditor now fires an event on save rather than on exit, so the
signal name should be updated to match the behavior.
2018-01-27 15:03:18 -05:00
Marc Jauvin
fe4dd579f9
add --sel option to prompt-yank
2018-01-26 22:06:05 -05:00
Marc Jauvin
520b473350
modify Question.yank_text to Question.url
...
error out when question.url is None
add url to yesno prompts
add default binding in prompt mode (ctrl-y)
2018-01-25 17:48:45 -05:00
Daniel Hahler
6a40cbf160
incdec_number: add support for port
2018-01-22 21:26:46 +01:00
Florian Bruhin
cb2cd615e0
Update docs
2018-01-18 07:57:31 +01:00
Marc Jauvin
e25a33790f
remove blank line to satisfy flake8
2018-01-15 20:44:56 -05:00
Marc Jauvin
528b48dab6
fix line too
2018-01-15 15:51:14 -05:00
Marc Jauvin
8940e05baf
bind without agruments shows current bindings
2018-01-12 17:27:44 -05:00
Florian Bruhin
dcf89f7a28
Fix KeyConfig._prepare
2017-12-29 16:10:12 +01:00
Florian Bruhin
a145497c65
Make :unbind work correctly
2017-12-29 16:05:16 +01:00
Florian Bruhin
caa05df16d
Use KeySequences in config.py
2017-12-29 15:58:20 +01:00
Florian Bruhin
7b3cb14e6e
Revert "Try to have strings in KeyConfig"
...
This reverts commit 28b6b97f39
.
2017-12-29 15:41:28 +01:00
Florian Bruhin
28b6b97f39
Try to have strings in KeyConfig
2017-12-29 15:41:12 +01:00
Florian Bruhin
7b17ab4b3f
Initial str() attempt
2017-12-29 14:22:20 +01:00
Florian Bruhin
cc747b00ce
Move parsing to class
2017-12-29 01:50:51 +01:00
Florian Bruhin
21b3e05ed0
Fix getting reverse bindings
2017-12-29 01:24:05 +01:00
Florian Bruhin
b1dde41b74
Rename sequence.py to keyutils.py
2017-12-29 01:24:05 +01:00
Florian Bruhin
dcf0d21121
Move key related utils to sequence.py
2017-12-29 01:24:05 +01:00
Florian Bruhin
a8aaf01ff0
Fix some more stuff (and break some :D)
2017-12-29 01:24:05 +01:00
Florian Bruhin
ddcb5445a2
Initial refactoring for new key parsing
2017-12-29 01:24:05 +01:00
Florian Bruhin
f203535e00
Merge remote-tracking branch 'origin/pr/3407'
2017-12-18 16:11:16 +01:00
Ryan Roden-Corrent
ef2de8201a
Fix colors.completion.fg default and description.
...
Update the description to mention the number of columns and change the
default to ["white", "white", "white"] to make it more obvious that
multiple colors can be specified. This also satisfies the config test
that expects the default value for ListOrValue types to be a list.
One other test had to be tweaked to use a config option that is still
just a QtColor rather than a ListOrValue.
While it is possible to provide just two colors, it is "undefined
behavior". It will use the first color as the third color, but that is
an artifact of the implementation and therefore not documented (though
also not an error, as it is harmless).
2017-12-18 08:42:22 -05:00
Florian Bruhin
f4ed31b295
Add an utils.Unreachable exception
2017-12-15 16:33:47 +01:00
Florian Bruhin
016fc0ebb1
Fix some inconsistent returns
2017-12-15 16:33:47 +01:00
Florian Bruhin
1a4a9b4392
Declare *args before keyword arguments
...
See https://pylint.readthedocs.io/en/latest/whatsnew/1.8.html
2017-12-15 16:33:47 +01:00
Florian Bruhin
3f9ded3bed
Add missing docstrings
2017-12-15 13:55:06 +01:00
Ryan Roden-Corrent
57e2d407ce
Support different colors per completion column.
...
Now colors.completion.fg may be set to a list to specify a different
color for each completion column. For example:
:set colors.completion.fg [black,blue,white] will use black text for the
first column, blue for the second, and white for the third.
Setting to a single value still works and behaves as before. The default
is unchanged from 'white'.
Resolves #1794 .
2017-12-13 17:03:59 -05:00
Ryan Roden-Corrent
12112e0fc7
Implement command-accept --rapid.
...
command-accept --rapid will run the command without clearing the prompt,
allowing "rapid fire" commands. For example, one could open completion
for `open -t` and open several tabs in a row.
The default binding is ctrl+enter.
Resolves #588 .
2017-12-13 16:30:42 -05:00
Florian Bruhin
c8aef015b0
Merge remote-tracking branch 'origin/pr/3201'
2017-12-13 09:22:36 +01:00
Justin Partain
8451899a76
Add block for ignore_case
2017-12-12 11:31:28 -05:00
Justin Partain
4eebd2a85d
Create config.search.* group with ignore_case and incremental
2017-12-12 11:31:28 -05:00
Justin Partain
bb2fcddcd4
Update incremental_search PR with changes from review
2017-12-12 11:31:28 -05:00
Justin Partain
c1094b6660
Feature - incremental_search
...
Added config option to find on a page incrementally, renewing the search
each time a new character is entered.
2017-12-12 11:31:28 -05:00
George Edward Bulmer
747a9bc5b6
Modify usage of re.match to fit re.fullmatch or re.search.
...
re.match features an implicit left anchor, which can be surprising.
re.fullmatch features implicit anchors on both sides, but is aptly named
and unsurprising.
re.search has no such implicit anchors, which ought to be the default
even if a single anchor is needed.
2017-12-11 21:32:55 +00:00
Florian Bruhin
444f0a36df
Update docs
2017-12-11 07:12:45 +01:00
unknown
2483b8315c
Merge remote-tracking branch 'refs/remotes/origin/master'
2017-12-07 13:36:49 -07:00
evanlee123
d1a00eb934
Clarity on protocol field
2017-12-07 02:35:34 -07:00
unknown
f0de3601cb
Merge remote-tracking branch 'upstream/master'
2017-12-06 13:37:05 -07:00
unknown
30b25da273
Added protocol key to field
2017-12-06 13:09:44 -07:00
Florian Bruhin
dcb4448594
Merge remote-tracking branch 'origin/pr/3345'
2017-12-06 06:51:03 +01:00
Florian Bruhin
ca74991900
Read backend after args.temp_settings
...
This should hopefully not affect any config change handlers, as almost nothing
is registered this early.
Fixes #3340
2017-11-28 17:00:45 +01:00
Florian Bruhin
0f3cff60fa
Merge remote-tracking branch 'origin/pr/3335'
2017-11-26 19:42:54 +01:00
Panagiotis Ktistakis
e05dabefdf
Show default keybinding in :bind completion
2017-11-26 13:34:18 +02:00
Ryan Farley
5ed8019115
update flake8 and flake8-deprecated
...
Updated requirements and adjusted the configuration in `.flake8`; other
files have been modified where the lack of per-file auto-ignore caused
problems, where putty's `# flake8: disable=` syntax could be replaced
with a simpler `noqa`, or where pylint directives already suppressed the
same error.
2017-11-26 00:16:14 -06:00
Florian Bruhin
0afd6b23c9
Add the option name to the backend error message
2017-11-24 09:25:45 +01:00
Florian Bruhin
3b3acba34e
Edit description of tabs.persist_mode_on_change
2017-11-22 09:11:17 +01:00
Florian Bruhin
2581be051f
Always leave hint/caret mode when switching tabs
...
See #3323
2017-11-22 08:53:01 +01:00
mhm@mhm.com
e2d5a443cc
lazy sessions
2017-11-21 23:57:06 +01:00
Vladimir Shulyak
7532db83c4
Add option to persist current mode on tab change
2017-11-21 18:57:41 +00:00
Florian Bruhin
203b6c354f
Fix content.cache.size overflow with QtWebEngine
...
While 64-bit values are allowed with QtWebKit/QNetworkDiskCache, QtWebEngine
only allows 32-bit values here. With the updated sip's strict overflow checking,
that means we get an exception when setting a too big value.
2017-11-21 14:07:49 +01:00
mhm@mhm.com
aa40842848
lazy sessions, docstring formatted, settings renamed, javascript notice changed, insert method changed
2017-11-21 00:38:51 +01:00
Florian Bruhin
62f37df573
Make cursor keys go through completion if a text was entered
...
This hopefully helps with people who try to use arrow keys for the completion,
while still making the command history somewhat discoverable.
2017-11-19 20:35:16 +01:00
Florian Bruhin
2b063f577e
Handle OSError in :config-write-py
2017-11-19 14:06:11 +01:00
mhm@mhm.com
95f8c07d7f
lazy sessions
2017-11-18 00:31:53 +01:00
Dasith Gunawardhana
ea70a0dea1
changed setting name and reverted non-issue fix
2017-11-14 01:41:15 -05:00
Dasith Gunawardhana
36c8ca9790
added option to limit fullscreen to window only
2017-11-13 21:38:02 -05:00
Florian Bruhin
870c15a02c
Merge remote-tracking branch 'origin/pr/3264'
2017-11-13 20:40:23 +01:00
Jay Kamat
0f17e6633d
Stop calling _register automatically for StyleSheetObservers
2017-11-13 12:04:31 -05:00
Florian Bruhin
df4a011d48
Put files into the config dir with :config-write-py and rel. paths
2017-11-13 10:58:51 +01:00
Florian Bruhin
5c43dca0da
Improve error message for files which don't exist
2017-11-13 10:47:37 +01:00
Florian Bruhin
7f0ecaa89e
Merge remote-tracking branch 'origin/pr/3266'
2017-11-13 07:09:49 +01:00
Florian Bruhin
fc8f2090f0
Merge remote-tracking branch 'origin/pr/3271'
2017-11-13 07:09:29 +01:00
Florian Bruhin
f6e6f9d27b
Make qutebrowser aware of settings requiring a restart
...
See #3270
2017-11-12 17:17:19 +01:00
Jay Kamat
c1fcabe846
Remove default config-cycle bindings
...
Many people accidentally hit 'x{x,t,b}', hiding their statusbar by mistake
2017-11-11 16:16:26 -05:00
Jay Kamat
f242fc5cd7
Add setting to avoid shrinking pinned tabs
2017-11-11 11:33:33 -05:00
Jay Kamat
e00a072d15
Fix garbage collection of StyleSheetObserver objects
2017-11-10 23:25:46 -05:00
Florian Bruhin
8df759ecad
Merge remote-tracking branch 'origin/pr/3259'
2017-11-10 09:42:05 +01:00
dkanada
6ecd429d8f
group indicator preferences
2017-11-08 15:27:16 -07:00
dkanada
b8b49637e2
replace changes to desc
2017-11-08 14:46:00 -07:00
dkanada
785bf24652
change the code for the renamed preferences
2017-11-08 14:42:09 -07:00
cryzed
6e719d1796
Fix issue #3251
2017-11-08 15:08:36 +01:00
Joel Bradshaw
52be2dd665
Update documents to reflect new dictcli.py script
2017-11-06 22:21:07 -08:00
Florian Bruhin
0053b10e4d
Merge remote-tracking branch 'origin/pr/3243'
2017-11-06 16:26:21 +01:00
Florian Bruhin
29cbf75615
Merge remote-tracking branch 'origin/pr/3249'
2017-11-06 13:46:24 +01:00
Florian Bruhin
22f3fade24
Bump up default font size to 10pt
...
See #1585
2017-11-06 07:36:52 +01:00
Florian Bruhin
f52930c857
Make the window.hide_wayland_decoration option less special
2017-11-06 07:33:13 +01:00
Florian Bruhin
4fdf2d6f40
Update docs
2017-11-06 07:11:00 +01:00
Florian Bruhin
341e8ca864
Add a qt.highdpi setting
...
See #1585
2017-11-06 07:02:07 +01:00
Ryan Roden-Corrent
db3b1aee0d
Add default ctrl+c binding for completion yank.
...
By default, ctrl+c will yank the selection from the completion menu onto
the clipboard, and ctrl+shift+c will yank it onto the primary selection.
Unfortunately ctrl+y was already taken by rl-yank (which,
counter-intuitively to vim users, will paste the last deleted text).
2017-11-05 11:14:28 -05:00
Florian Bruhin
5689a3c0dc
Fix unbinding default keys twice
...
When doing :unbind with a default keybinding the first time, it gets inserted
into bindings.commands with None as value.
When then doing :unbind a second time, instead of just leaving that None value
as-is, we removed it again (because it got treated as a custom binding).
Fixes #3162
2017-11-04 15:17:19 +01:00
Michal Siedlaczek
16ad9182f1
Add en-AU (Australia) to the list of valid languages
2017-11-03 17:24:33 -04:00
Florian Bruhin
c22a27d47f
Add missing trailing dots
...
(cherry picked from commit 5f43b02badc20a4fc67931ab6e76f1050ab283aa)
2017-11-03 15:03:05 +01:00
Marcel Schilling
7e07f5c996
standardize placeholders in configdata descriptions
...
* Keep descriptions concise.
* Prefer starting descriptions with a noun.
* Don't explain that placeholders are placeholders/get replaced.
* Introduce placeholder list by the following line:
'The following placeholders are defined:'
* List placeholders in a markdown-style list:
'* `{<placeholder>}`: <description>.'
2017-11-03 08:48:30 +01:00
Marcel Schilling
c6d7509220
rephrase configdata descriptions
...
* see discussion of PR #3181
2017-11-03 08:44:11 +01:00
Marcel Schilling
87ec7a1a0b
prefer nouns for configdata descriptions
...
* reserve interrogative words for selection type options
2017-11-03 08:44:11 +01:00
Marcel Schilling
aebe4c8f9e
assume single user in configdata descriptions
...
* 'a user' -> 'the user'
2017-11-03 08:44:11 +01:00
Marcel Schilling
a6451c05d7
add missing units to configdata descriptions
...
* fixes #3171
2017-11-03 08:44:11 +01:00
Marcel Schilling
01b29cd640
use interrogative words for configdata descriptions
...
* for selections, use appropriate determiner/pro-adverb/pronoun:
* 'When to [...].'
* 'How to [...].'
* 'Which [...] to [...].'
* 'What [...] to [...].'
2017-11-03 08:44:11 +01:00
Marcel Schilling
0a908206bc
avoid boolean redundancy in configdata descriptions
...
* 'Enable or disable [...]' -> 'Enable [...]'
What else? ---^^^^^^^
2017-11-03 08:44:11 +01:00
Marcel Schilling
494aceec45
use imperative mood for bools in configdata descriptions
...
* considers ConfirmQuit and BoolAsk in addition to Bool
2017-11-03 08:44:11 +01:00
Marcel Schilling
f76af6c949
define type before desc in configdata YAML file
2017-11-03 08:44:11 +01:00
Marcel Schilling
b187a83d59
avoid spaces before colons in confidata YAML file
...
* ' desc : [...]' -> ' desc: [...]'
space ----^ no space ----^
2017-11-03 08:44:11 +01:00
Marcel Schilling
56671e5787
avoid articles in configdata descriptions
...
* includes `valid_value` descriptions in addition to `desc` fields
2017-11-03 08:44:11 +01:00
Marcel Schilling
e744a7c25a
avoid code duplication in configdata descriptions
...
* available placeholders are defined for tabs.title.format
* tabs.title.format_pinned refers to that definition
* window.title.format repeats the identical(!) definition
* this replaces the repetion by another reference
2017-11-03 08:44:11 +01:00
Marcel Schilling
fe8b9519c8
avoid redundancy in configdata descriptions
...
* drop phrases referring to the settings themselves:
* 'set ...'
* 'control ...'
* 'definitons of ...'
2017-11-03 08:44:11 +01:00
Marcel Schilling
fd52409d0c
standardize units in configdata descriptions
...
* encapsulate units in parentheses: ('(in <unit>)')
* move units right behind the corresponding noun
2017-11-03 08:44:11 +01:00