Ryan Roden-Corrent
822f6bae2c
Fix webkitelem test.
...
Now that it checks tab.is_deleted we need to mock that.
2017-12-01 07:28:02 -05:00
Ryan Roden-Corrent
4497f710f9
Try SIGINT instead of SIGTERM for windows.
2017-11-30 07:56:37 -05:00
Ryan Roden-Corrent
b465c109ee
Fix test_editor_bdd.py for windows.
...
- Use a raw string to handle windows path separators
- Use SIGTERM instead of SIGUSR1
2017-11-29 07:42:12 -05:00
Ryan Roden-Corrent
fcad40ceb7
Add orphaned tab check to WebKit as well.
...
This implements the orphaned editor fix for WebKit. Webkit wasn't
crashing before, but this causes webkit to show the same warning
webengine does if the editor is orhpaned (rather than silently
continuing). This allows the same BDD test to pass for both webkit and
webengine.
2017-11-29 07:35:11 -05:00
Ryan Roden-Corrent
e09a8c77e9
Simplify check for orphaned editor.
...
Instead of rewiring signals on tab.shutting_down, have the webelem check
if its parent tab is deleted, and throw a specific exception.
This is only necessary in WebEngine, Webkit does not crash when the
editor is orphaned.
I tried to write a test for is_deleted, but could not get it to pass:
```
def test_is_deleted(qtbot, view, config_stub, tab_registry, mode_manager):
tab_w = Tab(win_id=0, mode_manager=mode_manager)
qtbot.add_widget(tab_w)
tab_w._set_widget(view)
assert not tab_w.is_deleted()
sip.delete(view)
#assert tab_w.is_deleted()
```
The qtbot post-test cleanup would error due to the deleted view.
2017-11-29 07:01:48 -05:00
Ryan Roden-Corrent
01a9405391
Make ophaned editor test less flaky.
...
Instead of having the editor sleep a short time, explicitly send it a
signal to exit.
2017-11-28 08:38:04 -05:00
Ryan Roden-Corrent
9dfc6b0f61
Change wording for orphaned editor.
...
The term "vanished" is used elsewhere.
2017-11-28 08:37:38 -05:00
Ryan Roden-Corrent
54fffc8264
Resolve crash when editor tab is closed.
...
If an editor is open on a form in a tab and that tab is closed, rewire
the callback to print a warning. Previously, the callback would access a
deleted C++ object and cause a crash.
Resolves #2758 .
2017-11-26 07:50:49 -05:00
Florian Bruhin
03a9cbdfb4
Break long lines
...
(cherry picked from commit 18a45bbd5b0492785cfc6e9b541d816ed8ec5c54)
2017-11-24 16:03:34 +01:00
Florian Bruhin
06fc52321e
Ignore new Qt 5.9.3 error message
2017-11-24 14:24:15 +01:00
Florian Bruhin
15c7ede916
Update to PyQt 5.9.2
2017-11-24 14:24:15 +01:00
Florian Bruhin
0afd6b23c9
Add the option name to the backend error message
2017-11-24 09:25:45 +01:00
Florian Bruhin
28d7c5e204
Fix lint
2017-11-24 07:25:10 +01:00
Ryan Roden-Corrent
8eab402820
Abort :edit-command on invalid input.
...
Show an error message if the user edits the command such that it is
missing a start character (:, /, or ?). Previously, this would cause the
browser to crash.
Resolves #3326 .
2017-11-23 08:15:27 -05:00
Florian Bruhin
b31360b6e3
Fix line break
2017-11-22 17:19:21 +01:00
Florian Bruhin
750d2c490f
Fix :completion-item-focus --history with / or ?
...
If we have no completion (like when searching), we can just always go through
history with up/down.
2017-11-22 15:34:48 +01:00
Florian Bruhin
5d8c9577a7
Improve hypothesis example generation for configtypes.Dict
2017-11-22 11:53:49 +01:00
Florian Bruhin
72d466d236
Break long lines
2017-11-22 11:34:10 +01:00
Florian Bruhin
487951cd31
Fix joining :jseval path
2017-11-22 10:57:48 +01:00
Florian Bruhin
cbf5fc01fa
Avoid more about:blank loads
2017-11-22 10:15:18 +01:00
Florian Bruhin
221b81ae90
Fix typo in changelog
2017-11-22 09:37:17 +01:00
Florian Bruhin
12f4940ef3
Make :jseval use a fixed path with relative paths
2017-11-22 09:37:17 +01:00
Florian Bruhin
3b3acba34e
Edit description of tabs.persist_mode_on_change
2017-11-22 09:11:17 +01:00
Florian Bruhin
2581be051f
Always leave hint/caret mode when switching tabs
...
See #3323
2017-11-22 08:53:01 +01:00
Florian Bruhin
401a37bf4b
Stabilize :spawn with userscript tests
2017-11-22 08:43:47 +01:00
Florian Bruhin
e5cabb6d23
Match QtWebKit error message for qute://help/img test
2017-11-22 08:40:20 +01:00
Florian Bruhin
fd93e7ba6c
Update docs
2017-11-22 08:02:38 +01:00
Florian Bruhin
94b2a41ed7
Merge remote-tracking branch 'origin/pr/3323'
2017-11-22 08:00:57 +01:00
Florian Bruhin
aa417019ae
Try stabilizing loading about:blank in end2end tests
2017-11-22 07:59:22 +01:00
Florian Bruhin
8acfe501fe
Revert "Stabilize cleaning up open tabs"
...
We're going to fix this in a more generic way.
This reverts commit 8440303d82
.
2017-11-22 07:56:31 +01:00
Florian Bruhin
c4291a8ed5
Update GitHub contributing docs
2017-11-22 07:52:03 +01:00
Vladimir Shulyak
358c888760
Fix long line
2017-11-21 22:35:19 +00:00
Vladimir Shulyak
7532db83c4
Add option to persist current mode on tab change
2017-11-21 18:57:41 +00:00
Florian Bruhin
b684e50cdf
Stabilize view-source test
2017-11-21 18:14:17 +01:00
Florian Bruhin
9744a3d0bc
Skip test_webenginesettings without QtWebEngine
2017-11-21 17:58:32 +01:00
Florian Bruhin
8440303d82
Stabilize cleaning up open tabs
...
For some reason, about:blank isn't properly loaded sometimes. But this should
always work.
2017-11-21 14:53:31 +01:00
Florian Bruhin
2f12233cb7
Update changelog
2017-11-21 14:10:48 +01:00
Florian Bruhin
6c9f496edf
Add a test for setting content.cache.size to a big value
2017-11-21 14:09:38 +01:00
Florian Bruhin
a451e8ac9d
Add a cache_tmpdir fixture
2017-11-21 14:09:30 +01:00
Florian Bruhin
c9d42c8bea
Enable strict overflow checking in tests
2017-11-21 14:09:20 +01:00
Florian Bruhin
203b6c354f
Fix content.cache.size overflow with QtWebEngine
...
While 64-bit values are allowed with QtWebKit/QNetworkDiskCache, QtWebEngine
only allows 32-bit values here. With the updated sip's strict overflow checking,
that means we get an exception when setting a too big value.
2017-11-21 14:07:49 +01:00
Florian Bruhin
75555fc244
Fix warning regex
2017-11-21 13:21:50 +01:00
Florian Bruhin
cff557d2fc
Try to stabilize command test, take 2
2017-11-21 13:19:11 +01:00
Florian Bruhin
56d1c5c7dd
Stabilize command history test
2017-11-21 11:31:22 +01:00
Florian Bruhin
54af872825
Add missing comma
2017-11-21 10:45:49 +01:00
Florian Bruhin
dc00bc1774
Add an initial Makefile
2017-11-21 10:35:11 +01:00
Florian Bruhin
273747624f
Update tox environment list in contributing docs
2017-11-21 09:24:43 +01:00
Florian Bruhin
c3128494a1
Create CODE_OF_CONDUCT.md
2017-11-21 09:19:06 +01:00
Florian Bruhin
d90d626ac4
Merge remote-tracking branch 'origin/pr/3316'
2017-11-20 21:17:29 +01:00
Florian Bruhin
25be4d4383
Merge remote-tracking branch 'origin/pr/3318'
2017-11-20 21:16:57 +01:00