Florian Bruhin
ad72b26b1a
Add comment why abstract-method is ignored.
2015-12-01 22:16:23 +01:00
Florian Bruhin
307fe6b109
Avoid shadowing 'model'.
2015-11-30 07:03:49 +01:00
Florian Bruhin
a4f47150b4
Simplify unneeded if.
2015-11-30 07:00:51 +01:00
Florian Bruhin
1da7996c3b
Style fixes.
2015-11-13 22:27:41 +01:00
Florian Bruhin
9f11990efc
Rename scrollbar.padding/scrollbar.width.
2015-10-19 05:15:52 +02:00
Nathan Isom
d326cc050e
correct style string, file modeline.
2015-10-18 14:11:22 -05:00
Nathan Isom
ec3cafc293
resolve merge conflicts and merge branch scrollbar.
2015-10-18 11:42:56 -05:00
Nathan Isom
9b5c0075b9
Move min-height to correctly fix bug, edit colors to match https://github.com/The-Compiler/qutebrowser/pull/1021 .
2015-10-17 19:31:47 -05:00
Nathan Isom
6391da4f6f
Forgot font changes.
2015-10-16 12:02:57 -05:00
Nathan Isom
2a11adc8ac
initial replace pass.
2015-10-16 10:52:02 -05:00
Nathan Isom
27db1ad891
fix scrollbar not showing up error, change test_get_stylesheet a bit.
2015-10-16 09:56:31 -05:00
Nathan Isom
57d8ebfb83
not hardcode width/padding values.
2015-10-15 14:06:16 -05:00
Nathan Isom
19c27a04e5
Add completion scrollbar settings.
2015-10-15 13:18:32 -05:00
Antoni Boucher
1acd32f697
Fixed issue #1008 .
2015-10-10 11:16:06 -04:00
Florian Bruhin
d229e90724
Fix some splelling mistakes.
2015-10-04 15:41:42 +02:00
Florian Bruhin
739d2cfffd
Fix displaying of web history if limited to -1.
...
This is a regression introduced in 2aa7e5bb35
.
Fixes #991 .
2015-10-02 22:56:18 +02:00
Antoni Boucher
f0a2128499
Fixed style.
2015-09-12 18:01:04 -04:00
Antoni Boucher
2aa7e5bb35
Fixed issue #934 .
2015-09-12 17:48:36 -04:00
Florian Bruhin
ef9e1bef1b
Improve performance when adding new history item.
...
Fixes #919 .
There were two issues here:
- CompletionWidget didn't delete the old model when setting a new one. This
means filterAcceptsRow was called for models which aren't even used anymore.
- setChild was used instead of appendRow for the BaseCompletionModel, which
caused Qt to call filterAcceptsRow once for every item of the completion
model instead of only once.
2015-09-06 16:59:43 +02:00
Thorsten Wißmann
830136540d
Hide the border of the completionwidget
...
Having a light Qt theme but a dark qutebrowser theme, one can see an
ugly white border around the completion widget which is some relict from
the underlying Qt widget QTreeView. As qutebrowser has its own theming
settings for the mainwindow, it should hide the Qt theme as far as
possible.
2015-08-25 11:01:25 +02:00
Florian Bruhin
4577659342
Fix crash when there's no completion.
2015-08-24 00:08:55 +02:00
Florian Bruhin
fc6c49f57c
Cleanup
2015-08-22 22:59:41 +02:00
Alexander Cogneau
7ed4977d64
Change parent of filter models
2015-08-21 16:56:36 +02:00
Alexander Cogneau
729c10e0a9
Fix PEP issue
2015-08-21 16:23:28 +02:00
Alexander Cogneau
387c84beff
Completion model filters are now per-window (via completer.py)
2015-08-21 16:05:33 +02:00
Alexander Cogneau
8be433f5f6
Add tests:
...
- sum of column widths equals 100
- column widths tuple has 3 elements
2015-08-11 09:17:46 +02:00
Alexander Cogneau
753f87aa15
Default size of third column is now 0
2015-08-08 23:49:54 +02:00
Alexander Cogneau
e29c642bc2
Fix wrong propertyname
2015-08-08 18:12:51 +02:00
Alexander Cogneau
f2c3cc6a3e
Module import of completion.models instead of class.
2015-08-08 17:58:12 +02:00
Alexander Cogneau
0e9f268817
CompletionView:
...
- column_widths -> _column_widths
- removed if-statement to verify if source model has 'column_widths'-property
2015-08-08 17:47:18 +02:00
Alexander Cogneau
36372418ca
Added the default column_widths as a class attribute instead of a config option.
2015-08-08 17:27:21 +02:00
Alexander Cogneau
5c2d3ec96a
Add a column_widths property to the base class for completion models.
2015-08-08 16:46:57 +02:00
Florian Bruhin
5a25f0b98b
Don't crash on :completion-item-del with no item.
...
If :completion-item-del was invoked with no item selected (e.g. directly after
pressing 'o'), there was a crash because the currentIndex was invalid.
/cc @antoyo (but I believe one of my changes on top of yours caused this)
2015-08-05 06:55:39 +02:00
Florian Bruhin
cc66feac09
Handle invalid history timestamps.
2015-08-01 00:57:34 +02:00
Florian Bruhin
57e79db136
Fix undefined name error.
2015-07-29 15:04:07 +02:00
Florian Bruhin
d9d68db5df
Simplify delete_cur_item for UrlCompletionModel.
2015-07-29 12:44:38 +02:00
Florian Bruhin
08fe1d59e6
Get rid of bookmark_by_title completion.
2015-07-29 12:36:45 +02:00
Florian Bruhin
69ade32cb9
Get rid of quickmark_by_name completion.
2015-07-29 12:35:43 +02:00
Florian Bruhin
b962fff7f1
Don't show message when deleting items.
2015-07-26 18:48:00 +02:00
Florian Bruhin
ecf3e166ff
Fix wrong column attribute.
2015-07-26 18:47:02 +02:00
Florian Bruhin
660b5531e5
Share code between on_{quick,book}mark_removed.
2015-07-26 18:43:01 +02:00
Florian Bruhin
b5a9467b5c
Get rid of _add_*mark_entry in urlmodel.
2015-07-26 18:35:49 +02:00
Florian Bruhin
2d2779d6f3
Clean up column handling in urlmodel.
2015-07-26 18:23:12 +02:00
Florian Bruhin
aaa523ce7c
Filter by cols_to_filter in CompletionFilterModel.
2015-07-26 17:41:32 +02:00
Florian Bruhin
3b0125e8cd
Rename cols_to_highlight to _filter and simplify.
2015-07-26 17:22:45 +02:00
Florian Bruhin
c7f88c93b2
Style fix.
2015-07-26 17:11:34 +02:00
Florian Bruhin
2f11b41ae6
Merge bookmarks and quickmarks into urlmarks.
2015-07-26 16:37:10 +02:00
Antoni Boucher
91561e2c5b
Fixed style.
2015-07-12 20:46:40 -04:00
Antoni Boucher
5bca951c21
Removed casefold() function call when using a custom filter.
2015-07-12 20:29:40 -04:00
Antoni Boucher
1b24cfd618
Removed useless bookmark by title model.
2015-07-12 20:21:49 -04:00
Antoni Boucher
d4c91f7b0c
Fixed completion highlighting.
2015-07-12 20:18:32 -04:00
Antoni Boucher
96a2178a25
Renamed bookmark_del to delete in bookmark manager.
2015-07-11 19:23:21 -04:00
Antoni Boucher
8159c5f567
Fixed last merge.
2015-07-11 18:56:19 -04:00
Antoni Boucher
fe829699be
Merge remote-tracking branch 'upstream/master'
2015-07-11 17:40:43 -04:00
Florian Bruhin
7b8490b6c0
Fix 'an user' spelling.
2015-06-29 17:49:19 +02:00
Florian Bruhin
bf4e968c67
Add new completion -> auto-open option.
...
Closes #557 .
2015-06-27 19:55:04 +02:00
Florian Bruhin
c64d9520ff
Fix lint.
...
Thanks to @Carpetsmoker for spotting this in #705 .
2015-06-18 08:10:14 +02:00
Florian Bruhin
dfe98d1053
completion: Fix initial _cursor_part value.
...
Fixes #749 .
2015-06-16 13:22:55 +02:00
Florian Bruhin
a545b919f7
Do history loading after qutebrowser has started.
2015-06-16 07:06:56 +02:00
Florian Bruhin
f17131f6c2
Change Qt links to point to qt.io.
2015-06-12 16:59:33 +02:00
Antoni Boucher
57a72a7120
Refactored bookmark removal to use a command.
2015-06-07 19:36:19 -04:00
Antoni Boucher
cf4b89efe3
Merge remote-tracking branch 'upstream/master'
2015-06-07 14:38:17 -04:00
Florian Bruhin
622938e3d3
Fix completion performance with shrink=True.
...
Before, the completion was shrinked every time any item was removed/added to
the completion (rowsRemoved/rowsInserted signals), which was >3000 times when
completing history.
Also, the signals got connected multiple times if setting the same model, which
made the situation worse.
Fixes #734 .
2015-06-05 07:16:33 +02:00
Antoni Boucher
8b14145a4d
Fixed style.
2015-06-03 19:31:31 -04:00
Antoni Boucher
f1874ff44f
Added possibility to remove bookmarks and quickmarks.
2015-06-01 20:00:21 -04:00
Antoni Boucher
5085844550
Added highlighting for completion in name column.
2015-06-01 17:55:09 -04:00
Antoni Boucher
e92c493b07
Fixed bug making the application crash.
2015-05-30 12:37:21 -04:00
Antoni Boucher
cbc4ec6531
Added filter bookmarks by name as well as url.
2015-05-28 19:55:29 -04:00
Antoni Boucher
ece32e930c
Added bookmarks command.
2015-05-24 19:18:40 -04:00
Antoni Boucher
0ee7e40e69
Fixed broken quickmarks completion.
2015-05-23 15:57:52 -04:00
Antoni Boucher
2c0c2e220e
Fixed style issue.
2015-05-21 19:38:30 -04:00
Antoni Boucher
28caf45707
First version of bookmarks.
2015-05-21 18:17:22 -04:00
Florian Bruhin
8eb483d66b
Set Qt.ItemNeverHasChildren for leaf model items.
...
This allows Qt to do some optimizations.
2015-05-18 21:35:14 +02:00
Florian Bruhin
f85ba8645f
Handle a missing session folder at some places.
2015-04-13 08:38:12 +02:00
Florian Bruhin
e24b06cdf9
Refactor and fix split commands in CommandRunner.
...
- split() now returns a ParseResult namedtuple with (cmd, args, cmdline)
arguments instead of only returning cmdline and setting self._cmd/self._args.
- Handling of split commands (;;) is now done in a separate parse_all()
function instead of run() to make testing easier.
See #615 .
2015-04-13 07:38:25 +02:00
Florian Bruhin
2876ba5cfa
Pass a parent to global QObjects.
2015-04-06 00:10:37 +02:00
Florian Bruhin
a504bd1436
Don't quote completions for maxsplit-commands.
...
Fixes #564 .
Obsoletes #313 and #453 .
2015-04-03 19:03:30 +02:00
Florian Bruhin
214347497a
Fix handling of first :completion-item-prev call.
...
Before, the first item was unconditionally selected when none was selected
before. With :completion-item-prev (e.g. Shift-Tab), it makes more sense to
select the *last* one.
2015-04-02 07:41:56 +02:00
Florian Bruhin
37ab5296a7
Adjust URL completion when quickmarks are changed.
...
Fixes #590 .
2015-04-02 07:40:00 +02:00
Florian Bruhin
068e1c14b6
Don't display internal sessions in completion.
2015-04-01 22:32:41 +02:00
Florian Bruhin
8ebac8d38c
Various spelling fixes.
2015-03-31 21:11:47 +02:00
Florian Bruhin
94bc10405a
Merge branch 'histcomplete'
2015-03-17 06:16:26 +01:00
Florian Bruhin
59bbca9b40
Fix updating of existing items in hist-completion.
...
Before we limited the history items we could simply call WebHistory's
historyContains before iterating through all items in the history completion.
Now however it's possible an item is in the real WebHistory, but not actually
in the completion - so we always have to check the whole completion.
2015-03-16 09:20:09 +01:00
Florian Bruhin
3df5e13c65
Fix exception in filtermodel if model has no items.
2015-03-16 07:42:21 +01:00
Florian Bruhin
503060881a
Compare history items based on QUrl.
2015-03-16 07:42:10 +01:00
Florian Bruhin
693ea0c312
Cleanup
2015-03-16 07:10:06 +01:00
Florian Bruhin
553d8cf986
Also save the QUrl in a HistoryEntry.
...
We also use QUrl::toDisplayString for the completion so things like spaces or
umlauts are decoded properly.
2015-03-16 07:03:30 +01:00
Florian Bruhin
001bf982e5
Alternate row colors in completion.
2015-03-15 23:16:57 +01:00
Florian Bruhin
d266665955
Fix adding of URLs to history completion.
...
Before, the item_added signal was emitted *after* an item was added, which
means the on_history_item_added slot always assumed the item already is in the
history.
2015-03-15 21:16:45 +01:00
Florian Bruhin
9512a52d21
completion: Don't unnecessarily expand all items.
...
Instead of calling expandAll() and iterating through all items, we can just
force the top-level items to be expanded.
2015-03-14 22:51:53 +01:00
Florian Bruhin
cdbb118238
Also measure the time it takes to set the pattern.
2015-03-14 13:35:32 +01:00
Florian Bruhin
70cd8e74eb
Measure time it takes to init URL completion.
2015-03-14 13:32:47 +01:00
Florian Bruhin
833830d5e9
Limit the count of history items in the completion.
2015-03-13 19:50:08 +01:00
Florian Bruhin
96da7d9fe6
Fix lint.
2015-03-13 16:26:27 +01:00
Florian Bruhin
74892ac8e4
Initialize completions lazily and only once.
...
Before, we initialized the completions once for every window spawned, which was
a waste of CPU-time and RAM.
Now we only initialize them once, when the user uses the completion for the
first time.
2015-03-13 16:25:13 +01:00
Florian Bruhin
389feab1df
Make sure args are not int in new_item().
...
Otherwise we would construct a QStandardItem with the
QStandardItem(int rows, int columns = 1) constructor, which will most likely
not do what we want.
2015-03-12 15:35:53 +01:00
Florian Bruhin
dbd121a079
Set data of existing item.
2015-03-12 15:34:32 +01:00
Florian Bruhin
97dd86735a
Improve types of history model values.
...
- HistoryItem.atime now always should be an int/float.
- The data for the sort role should also be an int, not a string.
A float would also work, but maybe be slower for no real benefit.
2015-03-12 15:34:32 +01:00
Florian Bruhin
8023b1456d
Make it possible to configure the timestamp format.
2015-03-12 15:25:39 +01:00
Florian Bruhin
7a28b6c821
Fix lint.
2015-03-12 14:55:54 +01:00