rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity
16,714 Commits 1 Branch 0 Tags 112 MiB
5514ddeed5
Commit Graph

4438 Commits

Author SHA1 Message Date
Florian Bruhin
935d93d10e Add tests for HistoryProgress 2018-09-06 17:26:28 +02:00
Florian Bruhin
d4f16f88b6 Remove support for importing pre-v1.0.0 history 2018-09-06 17:26:28 +02:00
Florian Bruhin
ec774379bd Add tests for history progress 2018-09-06 17:13:46 +02:00
Florian Bruhin
e4b7786bcc Factor out GUI stuff to a HistoryProgress object 2018-09-06 17:04:26 +02:00
Florian Bruhin
c8be2d4f7e Fix pylint issues with config cache 2018-09-06 16:43:10 +02:00
Florian Bruhin
108cc65bc6 Merge remote-tracking branch 'origin/pr/4185' 2018-09-06 16:15:16 +02:00
Jay Kamat
8e82adc306
Refactor configcache to cache 
Also fix and improve configcache tests
 2018-09-05 22:26:12 -07:00
Florian Bruhin
6293bc5178 Fix lint and test 2018-09-04 23:46:34 +02:00
Florian Bruhin
58793d95d7 Further clean up error handling 2018-09-04 23:05:59 +02:00
Florian Bruhin
92fcc523c5 WIP: Properly signal scheme errors 2018-09-04 23:03:10 +02:00
Florian Bruhin
2fcdc5a0c9 Merge branch 'blacklist-history' 2018-09-04 22:19:52 +02:00
Jay Kamat
d4cf5045ab
Fix tests for configcache 2018-09-02 18:03:36 -07:00
Jay Kamat
067d76616b
Implement config cache system 2018-09-02 14:23:00 -07:00
Florian Bruhin
5b0c10d430 Fix docstrings 2018-09-02 15:46:57 +02:00
Florian Bruhin
8a42256cff Merge remote-tracking branch 'origin/pr/4178' 2018-09-02 15:45:48 +02:00
Florian Bruhin
b0185e3c8a Use config_stub.val instead of config_stub.set_obj in tests 2018-09-02 14:42:47 +02:00
Florian Bruhin
dbdeb6a9c7 Rename history.exclude to completion.web_history.exclude 
If the blacklist is only valid for the completion, the setting should also be
under completion.

This also un-renames history.gap_interval and renames
completion.web_history_max_items.
 2018-09-02 14:42:47 +02:00
Florian Bruhin
4f56355fbe Don't affect qute://history with history.exclude 2018-09-02 14:42:47 +02:00
Florian Bruhin
67b4b7d490 Handle :// as URL pattern 2018-09-02 11:58:34 +02:00
Florian Bruhin
37396d68f3 Define names for sqlite error codes 2018-09-01 22:25:22 +02:00
Florian Bruhin
f5c92ded41 Merge Sql{Environment,Bug}Error with Sqlite{Environment,Bug}Error 2018-09-01 22:25:22 +02:00
Florian Bruhin
50ae2bf2f9 Redesign SQL error handling 
Instead of having an environmental attribute on exceptions, we now have two
different exception classes.

Fixes #3341
See #3073
 2018-09-01 22:25:22 +02:00
Florian Bruhin
71a2dad570 Add a history.exclude setting 
This allows to exclude URL patterns from being displayed in the completion or
in qute://history.
 2018-09-01 22:25:22 +02:00
Florian Bruhin
7fb2224640 Add a UrlPattern config type 
For some settings it makes sense to have a list of URL patterns in the config,
rather than having a per-domain boolean setting.
 2018-09-01 18:25:58 +02:00
Florian Bruhin
3f2a468750 Also detect missing bound values for sql.Query.run_batch 2018-09-01 18:25:58 +02:00
Florian Bruhin
fa1fe63a93 Add some more sql.Query tests 2018-09-01 18:25:58 +02:00
Florian Bruhin
0e284944e7 Use composition instead of inheritance for sql.Query 
This means we're more loosely coupled to Qt's QSqlQuery, and also can move some
logic for handling batch queries from the table to there.
 2018-09-01 18:25:58 +02:00
Florian Bruhin
6b719fb218 Make sure queries don't have any missing bindings 2018-09-01 18:25:58 +02:00
Florian Bruhin
1d6282fd6c Add some tests for sql.Query 2018-09-01 18:25:58 +02:00
Florian Bruhin
806d65be8e Add test for no-sql-history flag 2018-09-01 18:25:58 +02:00
Florian Bruhin
c2f8b6531d Reorganize test_history 2018-09-01 18:25:58 +02:00
Florian Bruhin
9fb794656b Make it possible to force a history rebuild 
This adds a new CompletionMetaInfo table which is a simple key/value store.

Thanks to Python/sqlite duck typing, we can use that to store values of any
type, even new ones in the future.

Currently, the only allowed key is force_rebuild, which forces a rebuild of the
CompletionHistory table. This will be needed for a future change.
 2018-09-01 18:25:58 +02:00
Vasilij Schneidermann
3fa6d94893 Display value when calling :set without a value 
This change brings Qutebrowser closer to Vim's behavior of `:set
foo?` *and* `:set foo` displaying the current value of `foo`.
 2018-08-31 21:34:42 +02:00
Florian Bruhin
1815070dab Make sure the host blocker doesn't block 0.0.0.0 2018-08-31 16:48:45 +02:00
Florian Bruhin
d337ed885a Re-add :stop test in misc.feature 
For some reason I don't comprehend right now, disabling it breaks
test_focusing_download_widget_via_tab. I'm having exams tomorrow and the day
after that, so meh, let's just re-enable that test for now as a stopgap
solution.
 2018-08-28 22:56:50 +02:00
Florian Bruhin
8459afb76e Recognize "Command"/"Cmd" in keybindings 2018-08-28 18:57:47 +02:00
Florian Bruhin
3fa01ae84d Handle more flaky tests 2018-08-28 09:21:03 +02:00
Florian Bruhin
1a7efd92d7 Merge remote-tracking branch 'origin/pr/4140' 2018-08-27 10:06:04 +02:00
Florian Bruhin
a370a00194 Remove more useless-return suppressions 2018-08-19 10:53:01 +02:00
Jimmy
b192164f2e Don't alphabetically sort tab completion. 
`ListCategory` sorts its completion by default, we are already building
the categories in the right order so don't need that.

The test tests the case of where you have 11 tabs and if the model was
sorted the tabs with index 10 and 11 would be sorted before the one with
index 2.

The `random.sample` bit for the tab url and title is to also make sure
the model isn't being sorted on those columns, whithout haveng to write
and all ten lines.
 2018-08-19 16:42:36 +12:00
Jay Kamat
b962c5c4d9
Merge pull request #4118 from DerJesko/master 
Tests for ipv6 support in urlmatch
 2018-08-13 14:33:53 -07:00
wishfort36
0e3e41a5e8 Handle nitpicks 2018-08-13 07:50:54 +02:00
wishfort36
b05738dd6c Keep $QUTE_COUNT unset if a count is not given 2018-08-12 22:39:32 +02:00
wishfort36
a9725ddb4a Add tests for $QUTE_COUNT 2018-08-12 22:31:12 +02:00
Florian Bruhin
58dffafb1e Merge remote-tracking branch 'origin/pr/4126' 2018-08-12 20:24:56 +02:00
Florian Bruhin
bddc021295 Mark more :follow-selected tests as flaky 2018-08-12 20:24:31 +02:00
farlusiva
8e2307c546 Docstring things, change test 
- Update the docstring for repeat
 - Remove the blank line after the docstring
 - Update the docstring with scripts/dev/src2asciidoc.py
 - Simplify the test
 2018-08-11 19:32:41 +02:00
wishfort36
adb371f305 Add test 2018-08-11 19:04:18 +02:00
Jesko
a676cca6c5 changing the texts of the errors 2018-08-10 20:49:20 +02:00
Jesko
0b51437346 fixing indentation 2018-08-10 19:05:15 +02:00
Florian Bruhin
57d3ed95f2 Mark another test as flaky 2018-08-10 08:40:24 +02:00
Jesko
972b3ae960 changing suggested flaws 2018-08-08 18:30:12 +02:00
Jesko
484a22f111 now declining more wrong ipv6 addresses and cleaning up code 2018-08-08 17:53:14 +02:00
Jesko
4ce5d99b24 match minimizes ipv6 urls 2018-08-08 16:55:43 +02:00
Jesko
599ac5ca23 Adding parser tests for IPv4 2018-08-07 22:35:00 +02:00
Jesko
790b34dc56 Adding match pattern test esp. IPv6 2018-08-07 21:59:15 +02:00
Florian Bruhin
9eeaa4f45d Fix lineparser tests 2018-08-07 17:53:26 +02:00
Florian Bruhin
70addc93b3 Add missing yaml_value fixture 2018-08-06 19:57:38 +02:00
Florian Bruhin
c1d06c8abb Skip another test 2018-08-06 09:55:49 +02:00
Florian Bruhin
4c23fb9e2f Another flaky test 2018-07-28 09:57:42 +02:00
Florian Bruhin
5269c5ac2b Another flaky test 2018-07-28 09:52:45 +02:00
Florian Bruhin
6fa07703db More flaky tests 2018-07-24 19:56:34 +02:00
Florian Bruhin
12e5375931 Handle more test flakiness 2018-07-24 17:36:07 +02:00
Florian Bruhin
8b814e3072 Increase qute://history delay in tests 2018-07-24 16:51:36 +02:00
Florian Bruhin
98cf1e5b2c Kill some more tests 2018-07-22 17:19:12 +02:00
Florian Bruhin
463dd911a3 More flaky tests 2018-07-22 15:46:24 +02:00
Florian Bruhin
40e58126aa About everything is flaky 
Did I already mention that I'm starting to hate those tests I wrote in the past
with a passion?
 2018-07-22 14:05:40 +02:00
Florian Bruhin
c1c182d958 Mark more tests as flaky 2018-07-22 13:03:25 +02:00
Florian Bruhin
0304036d7d Skip test which is too flaky 2018-07-22 12:05:55 +02:00
Florian Bruhin
13f688eeb8 "Fix" more flaky tests 2018-07-22 11:24:06 +02:00
Florian Bruhin
a7170fefe9 Turn off hypothesis deadline if on CI 2018-07-22 10:13:06 +02:00
Florian Bruhin
31a6374e0e Mark some more flaky tests as flaky 
I really want end2end tests to die...
 2018-07-21 23:36:45 +02:00
Florian Bruhin
733625e140 Stabilize test_qute_settings_persistence 2018-07-21 23:36:45 +02:00
Florian Bruhin
8a748741ba Fix checks for Nouveau workaround 2018-07-19 00:28:12 +02:00
Florian Bruhin
8e6aa9e3e1 Locally disable assignment-from-no-return for pylint 2.0 2018-07-16 14:53:30 +02:00
Florian Bruhin
e50b6912a7 Fix pylint 2.0 useless-return cases 
See https://github.com/PyCQA/pylint/issues/2300
 2018-07-16 14:33:11 +02:00
Florian Bruhin
43e58ac865 CVE-2018-10895: Fix CSRF issues with qute://settings/set URL 
In ffc29ee043 (part of v1.0.0), a
qute://settings/set URL was added to change settings.

Contrary to what I apparently believed at the time, it *is* possible for
websites to access `qute://*` URLs (i.e., neither QtWebKit nor QtWebEngine
prohibit such requests, other than the usual cross-origin rules).

In other words, this means a website can e.g. have an `<img>` tag which loads a
`qute://settings/set` URL, which then sets `editor.command` to a bash script.
The result of that is arbitrary code execution.

Fixes #4060
See #2332
 2018-07-11 17:05:23 +02:00
Florian Bruhin
274b66ec46 Strip trailing newlines from pastebin URL 2018-07-08 22:09:56 +02:00
Florian Bruhin
42a3622906 Ignore a new Qt 5.11 lowlevel message 2018-07-03 15:38:29 +02:00
Florian Bruhin
a0f36c5cbf Skip JS test which is too flaky 2018-07-03 14:15:08 +02:00
Florian Bruhin
4d1e56a8c6 Ignore "Lost UI shared context" error happening on AppVeyor 2018-07-03 13:39:34 +02:00
Florian Bruhin
7e8c741937 Set compiled=False for BDD Qt comparisons 
We often check for bugs and not APIs there.
 2018-07-03 13:10:15 +02:00
Florian Bruhin
641f7eb3c5 Don't import test_file on Windows 
See https://github.com/pytest-dev/pytest/issues/3650
 2018-07-03 13:08:54 +02:00
Florian Bruhin
26d6cf8ef6 Stabilize URL escaping test 2018-07-03 10:29:28 +02:00
Florian Bruhin
f6f713bbfe Skip key forwarding tests on Qt 5.11.1 
See #4036
 2018-07-02 23:19:57 +02:00
Florian Bruhin
6ca11ed95b Adjust SSL test for Qt 5.11 2018-07-02 23:15:04 +02:00
Florian Bruhin
41303ecfcf Make sure temporary dir exists 
This seems to be enforced with Qt 5.12
See #4025
 2018-07-02 22:32:59 +02:00
Florian Bruhin
9a14574c9f Skip invalid links on any Qt 5.11 version 
See #3661
 2018-07-02 22:32:59 +02:00
Florian Bruhin
d861c097b1 Support new dead keys added in Qt 5.11 properly 
See https://codereview.qt-project.org/#/c/207231/
 2018-07-02 22:32:59 +02:00
Florian Bruhin
77fe2e1c85 Fix test_set_wrong_backend 2018-07-02 22:32:59 +02:00
Florian Bruhin
c3455d9082 Add a wrapper around sip 
Starting with PyQt 5.11, the sip module now is bundled with PyQt as PyQt.sip.
Having a qutebrowser.qt also helps with #3625, see #995
 2018-07-02 22:32:59 +02:00
Florian Bruhin
e857400c2c Add missing str() 2018-06-28 13:26:45 +02:00
Florian Bruhin
a804300dc0 Add missing tests for spell.init() 2018-06-26 16:56:22 +02:00
Florian Bruhin
3312c221c4 Stabilize ssl_strict test 2018-06-26 10:26:17 +02:00
Florian Bruhin
85a9f6a08a Fix lint 2018-06-26 10:23:48 +02:00
Florian Bruhin
1bc3d444b6 Stabilize escaping URLs test 2018-06-25 23:02:50 +02:00
Florian Bruhin
87778277e0 Fix SSL error page tests 2018-06-25 22:51:48 +02:00
Florian Bruhin
fc19262eaa Fix test_shared.py 2018-06-24 22:31:27 +02:00
Florian Bruhin
a02c25dfb1 Don't escape URLs for qute://history 
We only use the URL to set a 'href' attribute, which does not need escaping.

See #4011
Fixes #4012
 2018-06-23 14:27:07 +02:00
Florian Bruhin
9a5439e5d0 Re-add waiting for QQuickWidget 
Apparently this is still needed on some PyQt versions.
 2018-06-21 22:22:04 +02:00
Florian Bruhin
5a7869f2fe Fix XSS issue on qute://history 
Fixes #4011
 2018-06-21 21:20:19 +02:00
Florian Bruhin
62d8b5b574 Don't depend on PyQt5.QtQuickWidgets to get RWHV 
Some distributions (at least FreeBSD) don't package that module, so let's not
rely on it.
 2018-06-21 17:14:29 +02:00
Florian Bruhin
4887385bdd Fix test_dictionary_dir 2018-06-21 01:40:36 +02:00
Florian Bruhin
b1b06fcb43 Fix restore test 2018-06-14 17:42:33 +02:00
Florian Bruhin
746c2986f0 Fix test_stylesheet on Qt 5.11 2018-06-14 16:42:24 +02:00
Florian Bruhin
11fce30ed0 Stabilize mode_on_change tests 2018-06-14 15:56:48 +02:00
Florian Bruhin
1335fccba1 Merge remote-tracking branch 'origin/pr/3590' into tab-mode 2018-06-14 15:40:58 +02:00
Florian Bruhin
cec63ea449 Merge remote-tracking branch 'origin/pr/3906' 2018-06-14 14:49:30 +02:00
Florian Bruhin
fd4ae2fabe Fix test_set_wrong_backend 2018-06-12 14:17:50 +02:00
Florian Bruhin
6faff11243 Improve error messages with backend conditionals 2018-06-12 11:10:03 +02:00
Florian Bruhin
e066f83a7c Make configinit tests run with all setups 2018-06-12 10:52:22 +02:00
Florian Bruhin
5b5657b0d5 Make sure debug_flags is available for unit tests 2018-06-12 10:38:19 +02:00
Florian Bruhin
093f07f552 Add content.canvas_reading setting 
See #2377
Closes #2235
 2018-06-11 23:28:04 +02:00
Florian Bruhin
69abc9a1a1 Add a content.webrtc_public_interfaces_only option 
See #3010
Fixes #2163
 2018-06-11 19:44:45 +02:00
Florian Bruhin
3bf89bcea4 Add content.autoplay option 
See #3010
Closes #1643
 2018-06-11 19:32:34 +02:00
Florian Bruhin
b7c1d7fe37 Fix broken tests 2018-06-11 18:38:22 +02:00
Florian Bruhin
263d298449 Remove the content.developer_extras setting 2018-06-11 18:09:24 +02:00
Florian Bruhin
98c82859b5 Skip "History with view-source URL" on QtWebKit 2018-06-11 15:36:48 +02:00
Florian Bruhin
b5d1614c48 Add audio attribute to FakeWebTab 2018-06-11 12:41:55 +02:00
Florian Bruhin
4dcba2343d Add expected_names to test arguments 2018-06-11 12:37:48 +02:00
Florian Bruhin
e36b6b13e0 Edit docstring :D 2018-06-11 12:35:49 +02:00
Florian Bruhin
2934f4a1ca Merge remote-tracking branch 'origin/pr/3973' 2018-06-11 12:34:18 +02:00
Jimmy
b7929ef747 Add tests for suppressing debug log records. 
For the LogFilter tests I just copied some of the examples that were
already being used and reversed them. To do that without even more
duplication I had to add another parameter to the test.
 2018-06-11 21:56:59 +12:00
Florian Bruhin
649c9f37cd Fix import 2018-06-11 11:35:37 +02:00
Florian Bruhin
7f69920158 Merge remote-tracking branch 'origin/pr/3947' 2018-06-11 11:29:14 +02:00
Florian Bruhin
1ba2e3e24b Implement Qt 5.11 devtools support 
See #3010
 2018-06-11 11:07:14 +02:00
Florian Bruhin
c4add62301 Merge remote-tracking branch 'origin/pr/3825' 2018-06-10 17:30:44 +02:00
Florian Bruhin
50fa7743ba Only use OS-specific line separator for hints 2018-06-10 17:21:31 +02:00
Florian Bruhin
829a6855a3 Make sure test_env_vars restores variables correctly 
Otherwise, we'd get a segfault inside Qt in test_stylesheet, since
88f2873a79.
 2018-06-10 15:49:24 +02:00
Florian Bruhin
ca8d3903e3 Improve configinit tests 2018-06-10 10:49:26 +02:00
Jay Kamat
de127497a2
Press enter to follow links instead of using js 
This codepath may trigger a crash which was fixed by
0e75f3272d.
However, this commit does not make it more likely to happen, and this
patch was backported into arch (at least).

In the future, we may be able to use <enter> on qtwebkit with js,
without triggering this crash
 2018-06-09 15:42:44 -07:00
Florian Bruhin
c9fddfe458 Fix lint 2018-06-09 23:00:57 +02:00
Florian Bruhin
7fdeeb25b7 Merge remote-tracking branch 'origin/pr/3793' 2018-06-09 22:59:52 +02:00
Florian Bruhin
dcb1191f93 Remove the deprecated :tab-detach 2018-06-09 21:25:09 +02:00
Florian Bruhin
ec88c15390 Fix waiting for initial focus object with Qt 5.11 workarounds 
This was broken in d32d541ac0 because now
apparently PyQt knows it's a QQuickWidget.
 2018-06-09 20:05:26 +02:00
Florian Bruhin
40b1be6925 Fix test_disable_gpu with QtWebKit 2018-06-09 19:59:11 +02:00
Florian Bruhin
41b5fca9b7 Add additional test 2018-06-09 19:57:22 +02:00
Florian Bruhin
88f2873a79 Allow more values for the qt.force_software_rendering setting 2018-06-09 16:21:10 +02:00
Florian Bruhin
a13618fe2a Merge branch 'pyup-scheduled-update-2018-06-04' 2018-06-07 22:57:48 +02:00
Florian Bruhin
8bf7cb539a Mark modal window test as flaky 2018-06-07 22:57:16 +02:00
Florian Bruhin
11b957f24b tests: Adjust getting markers for pytest 3.6 2018-06-07 19:29:01 +02:00
Florian Bruhin
596041c40e Go back to using an invalid scheme for invalid_link.html 
Otherwise, this breaks the tests on Qt 5.10
 2018-06-07 15:30:28 +02:00
Florian Bruhin
999513d5d8 Skip invalid link tests on Qt 5.11 
Qt 5.11 just loads about:blank and doesn't let us catch this in
acceptNavigationRequest, but the same happens in Chromium as well.

See #3661
 2018-06-07 13:49:28 +02:00
Florian Bruhin
d059197bc9 Use a valid scheme in invalid_link.html 
This is to avoid triggering QTBUG-63378 which fails differently with a custom
scheme.

See #3661
 2018-06-07 13:49:22 +02:00
Florian Bruhin
0e9159e8e8 Revert "Fix Qt 5.11 issues with clicking invalid links" 
This reverts commit 1956590df84a72c7f9a516e805d01529291fccf8.

Turns out the actual issue wasn't due to *invalid* links - it's with links
which have an unknown scheme.

There's still a change in behavior between Qt 5.10 and 5.11 though: Invalid
links are apparently not passed to acceptNavigationRequest (sometimes?) so we
don't show an error message. Instead, we just load about:blank. However,
Chromium does that too and we can't handle a real click easily, so let's just
ignore that one.

See #3661
 2018-06-07 13:49:13 +02:00
Florian Bruhin
3d53d0d2c5 Fix Qt 5.11 issues with clicking invalid links 
See #3661
 2018-06-07 13:48:04 +02:00
Florian Bruhin
8cc3804119 Don't run test with failed download on Qt 5.11 
Looks like we can't use an <a> tag with download-attribute to trigger a failed
download in the test on Qt 5.11...

See #2298, #3661
 2018-06-06 21:12:23 +02:00
Jay Kamat
c33a887b2d
Add support for following tab selected elements to :follow-selected 2018-05-25 12:39:36 -07:00
Jay Kamat
74ea696a5c
Merge branch 'master' of https://github.com/qutebrowser/qutebrowser into jay/tab-bg-focus 2018-05-22 23:17:52 -07:00
Florian Bruhin
29ad252278 Handle ² keypress correctly 
Turns out str.isdigit() also handles ² as a digit, but int('²') causes a
ValueError.

Here we use `string.digits` instead, which is '0123456789'.

Fixes #3743
 2018-05-22 12:25:45 +02:00