Commit Graph

14327 Commits

Author SHA1 Message Date
Florian Bruhin
6b65d96fe1 Reformat comment 2017-12-04 06:32:54 +01:00
Florian Bruhin
fe60556a34 Merge remote-tracking branch 'origin/pr/3349' 2017-12-04 06:32:46 +01:00
Florian Bruhin
a137a29cce Style improvements
This adds a blank line and makes Completer arguments keyword-only to make their
meaning more clear.
2017-12-03 22:32:17 +01:00
Florian Bruhin
9dfff43d99 Merge remote-tracking branch 'origin/pr/3357' 2017-12-03 22:30:47 +01:00
Florian Bruhin
bbc2f14e45 Merge remote-tracking branch 'origin/pr/3356' 2017-12-03 22:30:30 +01:00
Ryan Farley
38b2d42b40 cleanup PYTEST_ADDOPTS for pytest subprocess
See https://github.com/qutebrowser/qutebrowser/pull/3349
2017-12-03 15:09:47 -06:00
Ryan Roden-Corrent
b610563e7f Don't show current window for :tab-give/:tab-take.
Resolves #3144.
2017-12-03 08:03:54 -05:00
Florian Bruhin
97054ca35d Don't hide report dialog early
It looks like hiding it already causes it to be accepted.
Fixes #1128
2017-12-03 13:04:08 +01:00
Florian Bruhin
f07301cfb5 Revert "Restart correctly after reporting crash."
This reverts commit 7001f068b3.
2017-12-03 12:48:29 +01:00
François Chavant
59c9a2b243 Ignore shellcheck false positive 2017-12-03 11:30:59 +01:00
François Chavant
22e4a800a1 Refactor format_json userscript to not parse 'ls' output
The script now also works under MacOS
2017-12-03 10:50:54 +01:00
François Chavant
ccb8e74998 Use koalaman/shellcheck:latest 2017-12-03 09:29:38 +01:00
François Chavant
dd589f180b Fix remaining shellcheck warnings 2017-12-02 21:09:24 +01:00
François Chavant
31710b7045 Trivial fixes for shellcheck warnings 2017-12-02 19:37:20 +01:00
François Chavant
595a53ad3b Apply patch from #1697 2017-12-02 19:37:18 +01:00
François Chavant
b91a39be22 Run shellcheck on Travis CI 2017-12-02 19:37:10 +01:00
Florian Bruhin
ce46b30a1e Show error instead of warning 2017-12-02 14:49:06 +01:00
Florian Bruhin
f1f573d651 Update changelog 2017-12-02 14:48:31 +01:00
Florian Bruhin
003ec31848 Merge remote-tracking branch 'origin/pr/3333' 2017-12-02 14:47:24 +01:00
Florian Bruhin
a41db970e8 Update changelog
[ci skip]
2017-12-02 14:42:14 +01:00
Florian Bruhin
689fe96393 Improve workaround comment 2017-12-02 14:37:59 +01:00
Florian Bruhin
e9be357104 Merge remote-tracking branch 'origin/pr/3352' 2017-12-02 14:37:01 +01:00
Ryan Farley
fbd325f8d1 Revert "update tox env name in CI config"
This reverts commit 2f231c86ac.
2017-12-01 10:55:08 -06:00
Ryan Farley
5607cc2be8 Revert "update contributing.asciidoc with -pyqtlink envs"
This reverts commit 6b76203780.
2017-12-01 10:52:58 -06:00
Ryan Farley
df6ff55b7a allow pytest to default to link_pyqt
link_pyqt now checks for LINK_PYQT_SKIP, allowing pytest env names like
`py36` to work properly without negative conditionals in tox.ini
2017-12-01 10:51:41 -06:00
Ryan Roden-Corrent
780ac3f4c2 Remove needles quteproc/server fixture deps.
A few step definitions listed these in the parameters although they were
unused.
2017-12-01 11:34:47 -05:00
Ryan Roden-Corrent
3cfa0f7586 Make pylint happy for test_editor_bdd.
windows has no SIGUSR1, but we don't run this on windows anyways
for posix, there IS a member so we need to ignore useless-suppression
2017-12-01 08:41:08 -05:00
Ryan Roden-Corrent
1102ae4d7e Skip editor orphaned test on windows.
Tried SIGINT/SIGTERM, neither worked. Just skip this test on windows and
go back to SIGUSR1 otherwise.
2017-12-01 07:35:13 -05:00
Ryan Roden-Corrent
822f6bae2c Fix webkitelem test.
Now that it checks tab.is_deleted we need to mock that.
2017-12-01 07:28:02 -05:00
Ryan Farley
49485ca220 tox.ini: fix conditional syntax errors
`{[testenv]deps}` was passing conditionals in their raw form; this
simply lists them manually to avoid this.
2017-11-30 16:58:14 -06:00
Ryan Farley
6b76203780 update contributing.asciidoc with -pyqtlink envs 2017-11-30 14:21:37 -06:00
Ryan Farley
a5d0b9851a tox.ini: remove pyqt5.6, use requirements-pyqt.txt 2017-11-30 14:14:11 -06:00
mhm@mhm.com
b58cfead05 style fixed 2017-11-30 16:05:01 +01:00
Ryan Farley
2f231c86ac update tox env name in CI config
Use py36-pyqtlink instead of py36 for macOS
2017-11-30 08:35:02 -06:00
Ryan Farley
f7b0ac503e generate pytest envs with tox factors
This eliminates all separate pytest envs in favor of conditionals in
[testenv]. This requires renaming some environments to make the lack of
certain functionality explicit:

- instead of omitting pyqt{version}, use pyqtlink to use host PyQt

tox.ini: eliminate -nocov

It is possible to set the `PYTEST_ADDOPTS` environment variable to
enable coverage checks, rather than a new command.
2017-11-30 08:29:00 -06:00
Ryan Roden-Corrent
4497f710f9 Try SIGINT instead of SIGTERM for windows. 2017-11-30 07:56:37 -05:00
Florian Bruhin
45a1989a1f Add some more links to initial readme line
[ci skip]
2017-11-30 01:26:44 +01:00
mhm@mhm.com
d29cf1ee4d lazy sessions, restore if visible, forward user after restore 2017-11-30 00:09:28 +01:00
Florian Bruhin
ac89ab23a9 Revert "Add nEXT to list of alternatives"
It uses a buggy legacy WebKit...
This reverts commit 814a88b741.
2017-11-29 22:36:06 +01:00
Florian Bruhin
2752055281 Fix lint in webserver_sub.py 2017-11-29 22:17:48 +01:00
Ryan Roden-Corrent
b465c109ee Fix test_editor_bdd.py for windows.
- Use a raw string to handle windows path separators
- Use SIGTERM instead of SIGUSR1
2017-11-29 07:42:12 -05:00
Ryan Roden-Corrent
fcad40ceb7 Add orphaned tab check to WebKit as well.
This implements the orphaned editor fix for WebKit. Webkit wasn't
crashing before, but this causes webkit to show the same warning
webengine does if the editor is orhpaned (rather than silently
continuing). This allows the same BDD test to pass for both webkit and
webengine.
2017-11-29 07:35:11 -05:00
Ryan Roden-Corrent
e09a8c77e9 Simplify check for orphaned editor.
Instead of rewiring signals on tab.shutting_down, have the webelem check
if its parent tab is deleted, and throw a specific exception.

This is only necessary in WebEngine, Webkit does not crash when the
editor is orphaned.

I tried to write a test for is_deleted, but could not get it to pass:
```
def test_is_deleted(qtbot, view, config_stub, tab_registry, mode_manager):
    tab_w = Tab(win_id=0, mode_manager=mode_manager)
    qtbot.add_widget(tab_w)
    tab_w._set_widget(view)
    assert not tab_w.is_deleted()
    sip.delete(view)
    #assert tab_w.is_deleted()
```

The qtbot post-test cleanup would error due to the deleted view.
2017-11-29 07:01:48 -05:00
Florian Bruhin
81045fb1bd Drop unneeded parens 2017-11-29 10:44:50 +01:00
Florian Bruhin
af638ec430 Move hint unittests to their own file 2017-11-29 10:44:32 +01:00
Florian Bruhin
911616707e Merge remote-tracking branch 'origin/pr/3329' 2017-11-29 10:40:40 +01:00
Florian Bruhin
edba3f83bc Bump open_url_in_instance version to 1.0.4 2017-11-29 10:38:09 +01:00
Florian Bruhin
e7c4df7a9c Merge remote-tracking branch 'origin/pr/3332' 2017-11-29 10:38:06 +01:00
Rouji
afb4a6be51 bump _qb_version 2017-11-29 08:43:46 +01:00
Rouji
938198e92a quote _qute_bin (paths may contain whitespace), remove unnecessary --backend
argument
2017-11-29 08:43:02 +01:00