From ffddf9a15fa8e964abc7d9150af1909323bb929b Mon Sep 17 00:00:00 2001
From: George Edward Bulmer <gebulmer@googlemail.com>
Date: Sat, 10 Feb 2018 15:14:07 +0000
Subject: [PATCH] Code style review changes

---
 qutebrowser/html/version.html |  6 +++---
 qutebrowser/utils/utils.py    |  1 +
 qutebrowser/utils/version.py  | 10 +++++-----
 3 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/qutebrowser/html/version.html b/qutebrowser/html/version.html
index 9532c3d62..a69e6f9de 100644
--- a/qutebrowser/html/version.html
+++ b/qutebrowser/html/version.html
@@ -1,8 +1,8 @@
 {% extends "base.html" %}
 
 {% block script %}
-var paste_version = function(){
-  xhr = new XMLHttpRequest();
+function paste_version() {
+  const xhr = new XMLHttpRequest();
   xhr.open("GET", "qute://pastebin-version");
   xhr.send();
 }
@@ -36,5 +36,5 @@ You should have received a copy of the GNU General Public License
 along with this program.  If not, see <a href="http://www.gnu.org/licenses/">
 http://www.gnu.org/licenses/</a> or open <a href="qute://gpl">qute://gpl</a>.
 </p>
-<button id="paste" onclick="paste_version()">Pastebin Version Info</button>
+<button id="paste" onclick="paste_version()">Yank Pastebin URL for Version Info</button>
 {% endblock %}
diff --git a/qutebrowser/utils/utils.py b/qutebrowser/utils/utils.py
index 2d96613ee..079866920 100644
--- a/qutebrowser/utils/utils.py
+++ b/qutebrowser/utils/utils.py
@@ -50,6 +50,7 @@ except ImportError:  # pragma: no cover
 import qutebrowser
 from qutebrowser.utils import qtutils, log, debug
 
+
 fake_clipboard = None
 log_clipboard = False
 
diff --git a/qutebrowser/utils/version.py b/qutebrowser/utils/version.py
index 67bf5f423..09a1a6efa 100644
--- a/qutebrowser/utils/version.py
+++ b/qutebrowser/utils/version.py
@@ -66,7 +66,7 @@ class DistributionInfo:
     pretty = attr.ib()
 
 
-PASTEBIN_URL = None
+pastebin_url = None
 Distribution = enum.Enum(
     'Distribution', ['unknown', 'ubuntu', 'debian', 'void', 'arch',
                      'gentoo', 'fedora', 'opensuse', 'linuxmint', 'manjaro'])
@@ -460,18 +460,18 @@ def pastebin_version():
         message.info("Version url {} yanked to clipboard.".format(url))
 
     def _on_paste_version_success(url):
-        global PASTEBIN_URL
+        global pastebin_url
         _yank_url(url)
         pbclient.deleteLater()
-        PASTEBIN_URL = url
+        pastebin_url = url
 
     def _on_paste_version_err(text):
         message.error("Failed to pastebin version"
                       " info: {}".format(text))
         pbclient.deleteLater()
 
-    if PASTEBIN_URL:
-        _yank_url(PASTEBIN_URL)
+    if pastebin_url:
+        _yank_url(pastebin_url)
         return
 
     app = QApplication.instance()