From fe910fce493e7c0197689163fe1f898ca7dd5535 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sun, 7 Oct 2018 12:24:05 +0200 Subject: [PATCH] Speculative fix for test_caret teardown issues --- tests/helpers/fixtures.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tests/helpers/fixtures.py b/tests/helpers/fixtures.py index 83e606706..5bf841643 100644 --- a/tests/helpers/fixtures.py +++ b/tests/helpers/fixtures.py @@ -226,7 +226,10 @@ def webengine_tab(web_tab_setup, qtbot, redirect_webengine_data, tab = webenginetab.WebEngineTab(win_id=0, mode_manager=mode_manager, private=False) widget_container.set_widget(tab) - return tab + yield tab + # If a page is still loading here, _on_load_finished could get called + # during teardown when session_manager_stub is already deleted. + tab.stop() @pytest.fixture(params=['webkit', 'webengine'])