From fce825f9dfaf443c43396934dbb4b4960595569c Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 12 Jul 2016 13:22:47 +0200 Subject: [PATCH] Remove redundant "Given a new tmpdir" step With the (tmpdir) replacement we'll get a temporary directory no matter what, so this is unnecessary. --- tests/end2end/features/misc.feature | 1 - tests/end2end/features/test_misc_bdd.py | 5 ----- 2 files changed, 6 deletions(-) diff --git a/tests/end2end/features/misc.feature b/tests/end2end/features/misc.feature index 5842a12a5..a0f3eced5 100644 --- a/tests/end2end/features/misc.feature +++ b/tests/end2end/features/misc.feature @@ -340,7 +340,6 @@ Feature: Various utility commands. Then no crash should happen Scenario: print pdf - Given a new tmpdir When I open data/hello.txt And I run :print --pdf (tmpdir)/hello.pdf And I wait for "Print to file: *" in the log or skip the test diff --git a/tests/end2end/features/test_misc_bdd.py b/tests/end2end/features/test_misc_bdd.py index 7a28d059c..9ada5e484 100644 --- a/tests/end2end/features/test_misc_bdd.py +++ b/tests/end2end/features/test_misc_bdd.py @@ -75,11 +75,6 @@ def check_cookie(quteproc, name, value): assert data['cookies'][name] == value -@bdd.given(bdd.parsers.parse('a new tmpdir')) -def tmpdir(tmpdir_factory): - return tmpdir_factory.mktemp('tmpdir') - - @bdd.then(bdd.parsers.parse('the file {filename} should exist in the tmpdir')) def file_exists(quteproc, tmpdir, filename): path = tmpdir / filename