From fcad40ceb709988ac3a8c4a30e32c95d7ba87a45 Mon Sep 17 00:00:00 2001 From: Ryan Roden-Corrent Date: Wed, 29 Nov 2017 07:35:11 -0500 Subject: [PATCH] Add orphaned tab check to WebKit as well. This implements the orphaned editor fix for WebKit. Webkit wasn't crashing before, but this causes webkit to show the same warning webengine does if the editor is orhpaned (rather than silently continuing). This allows the same BDD test to pass for both webkit and webengine. --- qutebrowser/browser/webkit/webkitelem.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qutebrowser/browser/webkit/webkitelem.py b/qutebrowser/browser/webkit/webkitelem.py index 2a1eafc9e..829052798 100644 --- a/qutebrowser/browser/webkit/webkitelem.py +++ b/qutebrowser/browser/webkit/webkitelem.py @@ -118,6 +118,8 @@ class WebKitElement(webelem.AbstractWebElement): def set_value(self, value): self._check_vanished() + if self._tab.is_deleted(): + raise webelem.OrphanedError("Tab containing element vanished") if self.is_content_editable(): log.webelem.debug("Filling {!r} via set_text.".format(self)) self._elem.setPlainText(value)