rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

fix more pep8/pylint complaints

Browse Source
This commit is contained in:
Felix Van der Jeugt 2015-12-19 10:46:49 +01:00
parent d0979b9fac
commit fc06283d91
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
qutebrowser/browser/hints.py
View File

@ -158,7 +158,8 @@ class HintManager(QObject):
def _initialize_word_hints(self): def _initialize_word_hints(self):
if not self._words: if not self._words:
with open(config.get("hints", "dictionary")) as wordfile: dictionary = config.get("hints", "dictionary")
with open(dictionary, encoding="UTF-8") as wordfile:
alphabet = set(ascii_lowercase) alphabet = set(ascii_lowercase)
hints = set() hints = set()
lines = (line.rstrip().lower() for line in wordfile) lines = (line.rstrip().lower() for line in wordfile)
@ -272,6 +273,7 @@ class HintManager(QObject):
"INPUT": ["name"]}) "INPUT": ["name"]})
def extract_tag_words(elem): def extract_tag_words(elem):
"Extract tag words form the given element."
if elem.tagName() == "A": if elem.tagName() == "A":
# link text is a special case, alas. # link text is a special case, alas.
yield str(elem) yield str(elem)
@ -280,7 +282,10 @@ class HintManager(QObject):
if tag in elem) if tag in elem)
def tag_words_to_hints(words): def tag_words_to_hints(words):
for candidate in filter(bool, words): "Takes words and transform them to proper hints if possible."
for candidate in words:
if not candidate:
continue
match = self.FIRST_ALPHABETIC.search(candidate) match = self.FIRST_ALPHABETIC.search(candidate)
if not match: if not match:
continue continue
@ -293,10 +298,11 @@ class HintManager(QObject):
for e in existing) for e in existing)
def new_hint_for(elem, existing): def new_hint_for(elem, existing):
"Returns a hint for elem, without conflicting with the existing."
new = tag_words_to_hints(extract_tag_words(elem)) new = tag_words_to_hints(extract_tag_words(elem))
new = filter(lambda h: not any_prefix(h, existing), new) without_prefixes = (h for h in new if not any_prefix(h, existing))
# either the first good, or None # either the first good, or None
return next(new, None) return next(without_prefixes, None)
hints = [] hints = []
used_hints = set() used_hints = set()