From fb9867b6a7a8c4bdd8a68611c30641ed4fd613b5 Mon Sep 17 00:00:00 2001 From: Marshall Lochbaum Date: Sun, 21 Aug 2016 22:57:16 -0400 Subject: [PATCH] Add tests for completion show with no rows --- tests/unit/completion/test_completionwidget.py | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tests/unit/completion/test_completionwidget.py b/tests/unit/completion/test_completionwidget.py index 9e67a83db..82c0e076a 100644 --- a/tests/unit/completion/test_completionwidget.py +++ b/tests/unit/completion/test_completionwidget.py @@ -170,7 +170,7 @@ def test_completion_item_focus(which, tree, count, expected, completionview): @pytest.mark.parametrize('show', ['always', 'auto', 'never']) -@pytest.mark.parametrize('rows', [['Aa'], ['Aa', 'Bb']]) +@pytest.mark.parametrize('rows', [[], ['Aa'], ['Aa', 'Bb']]) @pytest.mark.parametrize('quick_complete', [True, False]) def test_completion_show(show, rows, quick_complete, completionview, config_stub): @@ -194,9 +194,10 @@ def test_completion_show(show, rows, quick_complete, completionview, assert not completionview.isVisible() completionview.set_model(filtermodel) - assert completionview.isVisible() == (show == 'always') + assert completionview.isVisible() == (show == 'always' and len(rows) > 0) completionview.completion_item_focus('next') - expected = show != 'never' and not (quick_complete and len(rows) == 1) + expected = (show != 'never' and len(rows) > 0 and + not (quick_complete and len(rows) == 1)) assert completionview.isVisible() == expected completionview.set_model(None) assert not completionview.isVisible()