From f9b046d766eb6ecadd3787fbdad2f04d097fd1cc Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 6 Jun 2017 16:15:25 +0200 Subject: [PATCH] Get proper settings object in WebEngineElement._click_js --- qutebrowser/browser/webengine/webengineelem.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/webengine/webengineelem.py b/qutebrowser/browser/webengine/webengineelem.py index f7ab41ead..12744cedb 100644 --- a/qutebrowser/browser/webengine/webengineelem.py +++ b/qutebrowser/browser/webengine/webengineelem.py @@ -199,7 +199,10 @@ class WebEngineElement(webelem.AbstractWebElement): self._move_text_cursor() def _click_js(self, _click_target): - settings = QWebEngineSettings.globalSettings() + # FIXME:qtwebengine Have a proper API for this + # pylint: disable=protected-access + settings = self._tab._widget.settings() + # pylint: enable=protected-access attribute = QWebEngineSettings.JavascriptCanOpenWindows could_open_windows = settings.testAttribute(attribute) settings.setAttribute(attribute, True)