rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update WORKAROUND comments

Browse Source
This commit is contained in:
Florian Bruhin 2017-03-21 10:29:31 +01:00
parent 081abde9cd
commit f8e043214a
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
qutebrowser/browser/webengine/webenginetab.py
View File

@ -369,12 +369,13 @@ class WebEngineHistory(browsertab.AbstractHistory):
return self._history.canGoForward() return self._history.canGoForward()
def serialize(self): def serialize(self):
# WORKAROUND for https://bugreports.qt.io/browse/QTBUG-59599 # WORKAROUND (remove this when we bump the requirements to 5.9)
# https://bugreports.qt.io/browse/QTBUG-59599
if self._history.count() == 0: if self._history.count() == 0:
raise browsertab.WebTabError("Can't serialize page without " raise browsertab.WebTabError("Can't serialize page without "
"history!") "history!")
# WORKAROUND for https://github.com/qutebrowser/qutebrowser/issues/2289 # WORKAROUND (FIXME: remove this when we bump the requirements to 5.9?)
# FIXME:qtwebengine can we get rid of this with Qt 5.8.1? # https://github.com/qutebrowser/qutebrowser/issues/2289
scheme = self._history.currentItem().url().scheme() scheme = self._history.currentItem().url().scheme()
if scheme in ['view-source', 'chrome']: if scheme in ['view-source', 'chrome']:
raise browsertab.WebTabError("Can't serialize special URL!") raise browsertab.WebTabError("Can't serialize special URL!")