rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't override javaScriptPrompt because of PyQt bugs

Browse Source
This commit is contained in:
Florian Bruhin 2014-06-14 23:31:39 +02:00
parent 392784213b
commit f58e702589
1 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
qutebrowser/browser/webpage.py
View File

@ -184,14 +184,18 @@ class BrowserPage(QWebPage):
"""Override javaScriptConsoleMessage to use debug log."""
log.js.debug("[{}:{}] {}".format(source, line, msg))
def javaScriptPrompt(self, _frame, msg, default):
"""Override javaScriptConfirm to use the statusbar."""
answer = message.modular_question(
"js: {}".format(msg), PromptMode.text, default)
if answer is None:
return (False, "")
else:
return (True, answer)
# We don't overwrite javaScriptPrompt as it's completely broken at least in
# PyQt 5.2.1 and 5.3.0:
# http://www.riverbankcomputing.com/pipermail/pyqt/2014-June/034385.html
#def javaScriptPrompt(self, _frame, msg, default):
# """Override javaScriptConfirm to use the statusbar."""
# answer = message.modular_question(
# "js: {}".format(msg), PromptMode.text, default)
# if answer is None:
# return (False, "")
# else:
# return (True, answer)
def chooseFile(self, _frame, suggested_file):
"""Override QWebPage's chooseFile to be able to chose a file to upload.