Separate tests for _get_search_url

This commit is contained in:
gammelon 2018-03-16 11:42:51 +01:00
parent 455f6b8a70
commit f57e47c742

View File

@ -299,19 +299,15 @@ def test_get_search_url(config_stub, url, host, query, open_base_url):
""" """
config_stub.val.url.open_base_url = open_base_url config_stub.val.url.open_base_url = open_base_url
url = urlutils._get_search_url(url) url = urlutils._get_search_url(url)
if open_base_url and not query:
assert not url.path()
assert not url.fragment()
assert url.host() == host assert url.host() == host
assert url.query() == query assert url.query() == query
@pytest.mark.parametrize('url, host, query', [ @pytest.mark.parametrize('url, host', [
('test', 'www.qutebrowser.org', ''), ('test', 'www.qutebrowser.org'),
('test-with-dash', 'www.example.org', ''), ('test-with-dash', 'www.example.org'),
]) ])
def test_get_search_url_open_base_url(config_stub, url, host, query): def test_get_search_url_open_base_url(config_stub, url, host):
"""Test _get_search_url() with url.open_base_url_enabled. """Test _get_search_url() with url.open_base_url_enabled.
Args: Args:
@ -319,7 +315,12 @@ def test_get_search_url_open_base_url(config_stub, url, host, query):
host: The expected search machine host. host: The expected search machine host.
query: The expected search query. query: The expected search query.
""" """
test_get_search_url(config_stub, url, host, query, True) config_stub.val.url.open_base_url = True
url = urlutils._get_search_url(url)
assert not url.path()
assert not url.fragment()
assert not url.query()
assert url.host() == host
@pytest.mark.parametrize('url', ['\n', ' ', '\n ']) @pytest.mark.parametrize('url', ['\n', ' ', '\n '])