rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix changing values in configutils.Values

Browse Source
This commit is contained in:
Florian Bruhin 2018-02-19 15:32:38 +01:00
parent d3e8d46593
commit f43c7fa360
1 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
qutebrowser/config/configutils.py
View File

@ -102,14 +102,8 @@ class Values:
return bool(self._values) return bool(self._values)
def add(self, value, pattern=None): def add(self, value, pattern=None):
"""Add a value with the given pattern to the list of values. """Add a value with the given pattern to the list of values."""
self.remove(pattern)
Currently, we just add this to the end of the list, meaning the same
pattern can be in there multiple times. However, that avoids doing a
search through all values every time a setting is set. We can still
optimize this later when changing the data structure as mentioned in
the class docstring.
"""
scoped = ScopedValue(value, pattern) scoped = ScopedValue(value, pattern)
self._values.append(scoped) self._values.append(scoped)