From f2bba2e4fa2aa0ce97d46fb8c9af8905c07dd9ef Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Tue, 20 Feb 2018 12:25:59 +0100 Subject: [PATCH] Fix navigation handling --- qutebrowser/browser/webkit/webkittab.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/qutebrowser/browser/webkit/webkittab.py b/qutebrowser/browser/webkit/webkittab.py index 2decac683..815dbd286 100644 --- a/qutebrowser/browser/webkit/webkittab.py +++ b/qutebrowser/browser/webkit/webkittab.py @@ -765,6 +765,9 @@ class WebKitTab(browsertab.AbstractTab): @pyqtSlot(usertypes.NavigationRequest) def _on_navigation_request(self, navigation): super()._on_navigation_request(navigation) + if not navigation.accepted: + return + log.webview.debug("target {} override {}".format( self.data.open_target, self.data.override_target)) @@ -781,8 +784,7 @@ class WebKitTab(browsertab.AbstractTab): self.data.open_target = usertypes.ClickTarget.normal navigation.accepted = False - if (navigation.accepted and navigation.navigation_type != - navigation.Type.reloaded): + if navigation.navigation_type != navigation.Type.reloaded: webkitsettings.update_for_tab(self, navigation.url) def _connect_signals(self):