rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Don't die when getting signals for invalid tabs

Browse Source
This commit is contained in:
Florian Bruhin 2014-06-24 07:01:15 +02:00
parent 43bcb2a746
commit f1c0153409
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
qutebrowser/widgets/tabbedbrowser.py
View File

@ -351,7 +351,9 @@ class TabbedBrowser(TabWidget):
""" """
idx = self.indexOf(tab) idx = self.indexOf(tab)
if idx == -1: if idx == -1:
raise ValueError("Tab {} not found!".format(tab)) # We can get signals for tabs we already deleted...
log.webview.debug("Got invalid tab {}!".format(tab))
return
self.setTabIcon(idx, EmptyTabIcon()) self.setTabIcon(idx, EmptyTabIcon())
@pyqtSlot(WebView, str) @pyqtSlot(WebView, str)
@ -368,7 +370,9 @@ class TabbedBrowser(TabWidget):
if text: if text:
idx = self.indexOf(tab) idx = self.indexOf(tab)
if idx == -1: if idx == -1:
raise ValueError("Tab {} not found!".format(tab)) # We can get signals for tabs we already deleted...
log.webview.debug("Got invalid tab {}!".format(tab))
return
self.setTabText(idx, text) self.setTabText(idx, text)
if idx == self.currentIndex(): if idx == self.currentIndex():
self.title_changed.emit('{} - qutebrowser'.format(text)) self.title_changed.emit('{} - qutebrowser'.format(text))
@ -385,7 +389,9 @@ class TabbedBrowser(TabWidget):
""" """
idx = self.indexOf(tab) idx = self.indexOf(tab)
if idx == -1: if idx == -1:
raise ValueError("Tab {} not found!".format(tab)) # We can get signals for tabs we already deleted...
log.webview.debug("Got invalid tab {}!".format(tab))
return
if not self.tabText(idx): if not self.tabText(idx):
self.setTabText(idx, url) self.setTabText(idx, url)
@ -402,7 +408,9 @@ class TabbedBrowser(TabWidget):
return return
idx = self.indexOf(tab) idx = self.indexOf(tab)
if idx == -1: if idx == -1:
raise ValueError("Tab {} not found!".format(tab)) # We can get *_changed signals for tabs we already deleted...
log.webview.debug("Got invalid tab {}!".format(tab))
return
self.setTabIcon(idx, tab.icon()) self.setTabIcon(idx, tab.icon())
@pyqtSlot(str) @pyqtSlot(str)