From f195b7e4d24851035a7c1cf127cd4f52195b4f9f Mon Sep 17 00:00:00 2001 From: Luca Benci Date: Wed, 25 Oct 2017 21:18:53 +0200 Subject: [PATCH] Fix flake8 failures --- qutebrowser/browser/webengine/webengineelem.py | 2 +- qutebrowser/browser/webkit/webkitelem.py | 2 +- qutebrowser/misc/editor.py | 2 +- tests/unit/misc/test_editor.py | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qutebrowser/browser/webengine/webengineelem.py b/qutebrowser/browser/webengine/webengineelem.py index fe8541e77..fb528a93d 100644 --- a/qutebrowser/browser/webengine/webengineelem.py +++ b/qutebrowser/browser/webengine/webengineelem.py @@ -134,7 +134,7 @@ class WebEngineElement(webelem.AbstractWebElement): self._js_call('set_value', value) def caret_position(self): - """Get the text caret position for the current element""" + """Get the text caret position for the current element.""" return self._js_dict.get('caret_position', 0) def insert_text(self, text): diff --git a/qutebrowser/browser/webkit/webkitelem.py b/qutebrowser/browser/webkit/webkitelem.py index 4ddaf5e51..86c701234 100644 --- a/qutebrowser/browser/webkit/webkitelem.py +++ b/qutebrowser/browser/webkit/webkitelem.py @@ -127,7 +127,7 @@ class WebKitElement(webelem.AbstractWebElement): self._elem.evaluateJavaScript("this.value='{}'".format(value)) def caret_position(self): - """Get the text caret position for the current element""" + """Get the text caret position for the current element.""" self._check_vanished() pos = self._elem.evaluateJavaScript('this.selectionStart') assert isinstance(pos, (int, float, type(None))) diff --git a/qutebrowser/misc/editor.py b/qutebrowser/misc/editor.py index bbc4fe25e..2fd1d8597 100644 --- a/qutebrowser/misc/editor.py +++ b/qutebrowser/misc/editor.py @@ -150,7 +150,7 @@ class ExternalEditor(QObject): self._proc.start(executable, args) def _calc_line_and_column(self, text, caret_position): - """Calculate line and column numbers given a text and caret position + r"""Calculate line and column numbers given a text and caret position. Both line and column are 1-based indexes, because that's what most editors use as line and column starting index. By "most" we mean at diff --git a/tests/unit/misc/test_editor.py b/tests/unit/misc/test_editor.py index 62abe7461..683b38841 100644 --- a/tests/unit/misc/test_editor.py +++ b/tests/unit/misc/test_editor.py @@ -190,5 +190,5 @@ def test_modify(qtbot, editor, initial_text, edited_text): ('a\nbb\nccc', 8, (3, 4)), ]) def test_calculation(editor, text, caret_position, result): - """Test calculation for line and column given text and caret_position""" + """Test calculation for line and column given text and caret_position.""" assert editor._calc_line_and_column(text, caret_position) == result