rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

hints: make HintManager.fire private

Browse Source 
It's not called by other classes anymore, it shouldn't be part of public
API because wrong value to the keystr parameter causes KeyError.
This commit is contained in:
Jakub Klinkovský 2016-08-10 18:21:19 +02:00
parent 073e5555ca
commit efb680dfb1
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
qutebrowser/browser/hints.py
View File

@ -824,7 +824,7 @@ class HintManager(QObject):
normal_parser = keyparsers[usertypes.KeyMode.normal] normal_parser = keyparsers[usertypes.KeyMode.normal]
normal_parser.set_inhibited_timeout(timeout) normal_parser.set_inhibited_timeout(timeout)
# unpacking gets us the first (and only) key in the dict. # unpacking gets us the first (and only) key in the dict.
self.fire(*visible) self._fire(*visible)
def handle_partial_key(self, keystr): def handle_partial_key(self, keystr):
"""Handle a new partial keypress.""" """Handle a new partial keypress."""
@ -904,7 +904,7 @@ class HintManager(QObject):
self._handle_auto_follow(filterstr=filterstr, self._handle_auto_follow(filterstr=filterstr,
visible=self._context.elems) visible=self._context.elems)
def fire(self, keystr): def _fire(self, keystr):
"""Fire a completed hint. """Fire a completed hint.
Args: Args:
@ -982,7 +982,7 @@ class HintManager(QObject):
keystring = self._context.to_follow keystring = self._context.to_follow
elif keystring not in self._context.elems: elif keystring not in self._context.elems:
raise cmdexc.CommandError("No hint {}!".format(keystring)) raise cmdexc.CommandError("No hint {}!".format(keystring))
self.fire(keystring) self._fire(keystring)
@pyqtSlot() @pyqtSlot()
def on_contents_size_changed(self): def on_contents_size_changed(self):