From ef439bb916e04989cc13776a8c3b5f246cebebc1 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Mon, 1 Aug 2016 18:19:34 +0200 Subject: [PATCH] Fix ;o/;O default bindings --- CHANGELOG.asciidoc | 1 + qutebrowser/config/configdata.py | 6 ++++-- tests/unit/config/test_config.py | 5 +++++ 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index d748c77a1..9b23f1c18 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -43,6 +43,7 @@ Fixed - Fixed crash when using hints with JS disabled in some rare circumstances. - When hinting input fields (`:t`), also consider input elements without a type. - Fixed crash when opening an invalid URL with a percent-encoded and a real @ in it +- Fixed default `;o` and `;O` bindings v0.8.1 ------ diff --git a/qutebrowser/config/configdata.py b/qutebrowser/config/configdata.py index 447624a8c..b4b0af80e 100644 --- a/qutebrowser/config/configdata.py +++ b/qutebrowser/config/configdata.py @@ -1462,8 +1462,8 @@ KEY_DATA = collections.OrderedDict([ ('hint all hover', [';h']), ('hint images', [';i']), ('hint images tab', [';I']), - ('hint links fill ":open {hint-url}"', [';o']), - ('hint links fill ":open -t {hint-url}"', [';O']), + ('hint links fill :open {hint-url}', [';o']), + ('hint links fill :open -t {hint-url}', [';O']), ('hint links yank', [';y']), ('hint links yank-primary', [';Y']), ('hint --rapid links tab-bg', [';r']), @@ -1654,4 +1654,6 @@ CHANGED_KEY_COMMANDS = [ (re.compile(r'^leave-mode$'), r'clear-keychain ;; leave-mode'), (re.compile(r'^download-remove --all$'), r'download-clear'), + + (re.compile(r'^hint links fill "([^"]*)"$'), r'hint links fill \1'), ] diff --git a/tests/unit/config/test_config.py b/tests/unit/config/test_config.py index cc6633559..a6ad3d119 100644 --- a/tests/unit/config/test_config.py +++ b/tests/unit/config/test_config.py @@ -281,6 +281,11 @@ class TestKeyConfigParser: ('leave-mode ;; foo', None), ('download-remove --all', 'download-clear'), + + ('hint links fill ":open {hint-url}"', + 'hint links fill :open {hint-url}'), + ('hint links fill ":open -t {hint-url}"', + 'hint links fill :open -t {hint-url}'), ] ) def test_migrations(self, old, new_expected):