Add run_js_eval and get :jseval to run

qutebrowser/browser/commands.py

@@ -1107,7 +1107,7 @@ class CommandDispatcher:
                 QWebSettings.JavascriptEnabled):
             if tab:
                 page.open_target = usertypes.ClickTarget.tab
-            page.currentFrame().evaluateJavaScript(
+            widget.run_js_async(
                 'window.getSelection().anchorNode.parentNode.click()')
         else:
             try:
@@ -1698,27 +1698,30 @@ class CommandDispatcher:
             js_code: The string to evaluate.
             quiet: Don't show resulting JS object.
         """
-        frame = self._current_widget().page().mainFrame()
-        out = frame.evaluateJavaScript(js_code)
-
         if quiet:
-            return
+            jseval_cb = None
-
+        else:
+            def jseval_cb(out):
                 if out is None:
-            # Getting the actual error (if any) seems to be difficult. The
+                    # Getting the actual error (if any) seems to be difficult.
-            # error does end up in BrowserPage.javaScriptConsoleMessage(), but
+                    # The error does end up in
-            # distinguishing between :jseval errors and errors from the webpage
+                    # BrowserPage.javaScriptConsoleMessage(), but distinguishing
-            # is not trivial...
+                    # between :jseval errors and errors from the webpage is not
+                    # trivial...
                     message.info(self._win_id, 'No output or error')
                 else:
-            # The output can be a string, number, dict, array, etc. But *don't*
+                    # The output can be a string, number, dict, array, etc. But
-            # output too much data, as this will make qutebrowser hang
+                    # *don't* output too much data, as this will make
+                    # qutebrowser hang
                     out = str(out)
                     if len(out) > 5000:
                         message.info(self._win_id, out[:5000] + ' [...trimmed...]')
                     else:
                         message.info(self._win_id, out)
 
+        self._current_widget().run_js_async(js_code, callback=jseval_cb)
+
+
     @cmdutils.register(instance='command-dispatcher', scope='window')
     def fake_key(self, keystring, global_=False):
         """Send a fake keypress or key string to the website or qutebrowser.

qutebrowser/browser/tab.py

@@ -303,6 +303,14 @@ class AbstractTab(QWidget):
         """
         raise NotImplementedError
 
+    def run_js_async(self, code, callback=None):
+        """Run javascript async.
+
+        The given callback will be called with the result when running JS is
+        complete.
+        """
+        raise NotImplementedError
+
     def shutdown(self):
         raise NotImplementedError
 

qutebrowser/browser/webengine/webenginetab.py

@@ -114,6 +114,12 @@ class WebEngineViewTab(tab.AbstractTab):
         else:
             self._widget.page().toHtml(callback)
 
+    def run_js_async(self, code, callback=None):
+        if callback is None:
+            self._widget.page().runJavaScript(code)
+        else:
+            self._widget.page().runJavaScript(code, callback)
+
     def shutdown(self):
         # TODO
         pass

qutebrowser/browser/webkit/webkittab.py

@@ -378,6 +378,11 @@ class WebViewTab(tab.AbstractTab):
         else:
             callback(frame.toHtml())
 
+    def run_js_async(self, code, callback=None):
+        result = self._widget.page().mainFrame().evaluateJavaScript(code)
+        if callback is not None:
+            callback(result)
+
     def icon(self):
         return self._widget.icon()