rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Unit test CompletionFilterModel.sort.

Browse Source
This commit is contained in:
Ryan Roden-Corrent 2016-08-04 15:37:19 -04:00
parent 83b621b0e6
commit ed69ef86ab
1 changed files with 52 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

56
tests/unit/completion/test_sortfilter.py
View File

@ -21,6 +21,8 @@
import pytest import pytest
from PyQt5.QtCore import Qt
from qutebrowser.completion.models import base, sortfilter from qutebrowser.completion.models import base, sortfilter
@ -153,10 +155,18 @@ def test_count(tree, expected):
[[('foo', '', ''), ('bar', '')]], [[('foo', '', ''), ('bar', '')]],
[[('foo', '', '')]]), [[('foo', '', '')]]),
# TODO # the fourth column is the sort role, which overrides data-based sorting
#('foo', Qt.DescendingOrder, ('', None, [0],
# [['foob', 'fooc', 'fooa']], [[('two', '', '', 2), ('one', '', '', 1), ('three', '', '', 3)]],
# [['fooc', 'foob', 'fooa']]), [[('one', '', ''), ('two', '', ''), ('three', '', '')]]),
('', Qt.AscendingOrder, [0],
[[('two', '', '', 2), ('one', '', '', 1), ('three', '', '', 3)]],
[[('one', '', ''), ('two', '', ''), ('three', '', '')]]),
('', Qt.DescendingOrder, [0],
[[('two', '', '', 2), ('one', '', '', 1), ('three', '', '', 3)]],
[[('three', '', ''), ('two', '', ''), ('one', '', '')]]),
]) ])
def test_set_pattern(pattern, dumb_sort, filter_cols, before, after): def test_set_pattern(pattern, dumb_sort, filter_cols, before, after):
"""Validate the filtering and sorting results of set_pattern.""" """Validate the filtering and sorting results of set_pattern."""
@ -179,3 +189,41 @@ def test_set_pattern(pattern, dumb_sort, filter_cols, before, after):
filter_model.data(cat_idx.child(j, 2)))) filter_model.data(cat_idx.child(j, 2))))
actual.append(entries) actual.append(entries)
assert actual == after assert actual == after
def test_sort():
"""Ensure that a sort argument passed to sort overrides DUMB_SORT.
While test_set_pattern above covers most of the sorting logic, this
particular case is easier to test separately.
"""
source_model = base.BaseCompletionModel()
cat = source_model.new_category('test')
source_model.new_item(cat, 'B', '', '', sort = 1)
source_model.new_item(cat, 'C', '', '', sort = 2)
source_model.new_item(cat, 'A', '', '', sort = 0)
filter_model = sortfilter.CompletionFilterModel(source_model)
filter_model.sort(0, Qt.AscendingOrder)
actual = []
for i in range(0, filter_model.rowCount()):
cat_idx = filter_model.index(i, 0)
entries = []
for j in range(0, filter_model.rowCount(cat_idx)):
entries.append((filter_model.data(cat_idx.child(j, 0)),
filter_model.data(cat_idx.child(j, 1)),
filter_model.data(cat_idx.child(j, 2))))
actual.append(entries)
assert actual == [[('A', '', ''), ('B', '', ''), ('C', '', '')]]
filter_model.sort(0, Qt.DescendingOrder)
actual = []
for i in range(0, filter_model.rowCount()):
cat_idx = filter_model.index(i, 0)
entries = []
for j in range(0, filter_model.rowCount(cat_idx)):
entries.append((filter_model.data(cat_idx.child(j, 0)),
filter_model.data(cat_idx.child(j, 1)),
filter_model.data(cat_idx.child(j, 2))))
actual.append(entries)
assert actual == [[('C', '', ''), ('B', '', ''), ('A', '', '')]]