rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Make it more clear that :messages helps with failing processes

Browse Source
This commit is contained in:
Florian Bruhin 2017-10-24 22:56:04 +02:00
parent cb4aea2f69
commit ed2f473a8e
2 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qutebrowser/misc/guiprocess.py
View File

@ -106,8 +106,8 @@ class GUIProcess(QObject):
assert status == QProcess.NormalExit assert status == QProcess.NormalExit
# We call this 'status' here as it makes more sense to the user - # We call this 'status' here as it makes more sense to the user -
# it's actually 'code'. # it's actually 'code'.
message.error("{} exited with status {}.".format( message.error("{} exited with status {}, see :messages for "
self._what.capitalize(), code)) "details.".format(self._what.capitalize(), code))
stderr = bytes(self._proc.readAllStandardError()).decode('utf-8') stderr = bytes(self._proc.readAllStandardError()).decode('utf-8')
stdout = bytes(self._proc.readAllStandardOutput()).decode('utf-8') stdout = bytes(self._proc.readAllStandardOutput()).decode('utf-8')

3
tests/unit/misc/test_guiprocess.py
View File

@ -195,7 +195,8 @@ def test_exit_unsuccessful(qtbot, proc, message_mock, py_proc, caplog):
proc.start(*py_proc('import sys; sys.exit(1)')) proc.start(*py_proc('import sys; sys.exit(1)'))
msg = message_mock.getmsg(usertypes.MessageLevel.error) msg = message_mock.getmsg(usertypes.MessageLevel.error)
assert msg.text == "Testprocess exited with status 1." expected = "Testprocess exited with status 1, see :messages for details."
assert msg.text == expected
@pytest.mark.parametrize('stream', ['stdout', 'stderr']) @pytest.mark.parametrize('stream', ['stdout', 'stderr'])