rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Do more checks in run_checks.py

Browse Source
This commit is contained in:
Florian Bruhin 2014-02-04 22:10:27 +01:00
parent 1f6ae3e0ed
commit ece03740a0
1 changed files with 19 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
run_checks.py
View File

@ -1,6 +1,6 @@
""" Run different codecheckers over a codebase. """ Run different codecheckers over a codebase.
Runs flake8, pylint and a CRLF-checker by default. Runs flake8, pylint and a CRLF/whitespace/conflict-checker by default.
""" """
import sys import sys
@ -41,27 +41,37 @@ def run(name, args=None):
status[name] = None status[name] = None
print() print()
def check_crlf(): def check_line():
"""Checks a filetree for CRLFs""" """Checks a filetree for CRLFs, conflict markers and weird whitespace"""
print("====== CRLF ======") print("====== line ======")
ret = [] ret = []
try: try:
for (dirpath, dirnames, filenames) in os.walk(testmodule): for (dirpath, dirnames, filenames) in os.walk(testmodule):
for name in [e for e in filenames if e.endswith('.py')]: for name in [e for e in filenames if e.endswith('.py')]:
fn = os.path.join(dirpath, name) fn = os.path.join(dirpath, name)
ret.append(_check_crlf(fn)) ret.append(_check_line(fn))
status['crlf'] = all(ret) status['line'] = all(ret)
except Exception as e: except Exception as e:
print('{}: {}'.format(e.__class__.__name__, e)) print('{}: {}'.format(e.__class__.__name__, e))
status['crlf'] = None status['line'] = None
print() print()
def _check_crlf(fn): def _check_line(fn):
with open(fn, 'rb') as f: with open(fn, 'rb') as f:
for line in f: for line in f:
if b'\r\n' in line: if b'\r\n' in line:
print('Found CRLF in {}'.format(fn)) print('Found CRLF in {}'.format(fn))
return False return False
elif any([line.decode('UTF-8').startswith(c * 7) for c in "<>=|"]):
print('Found conflict marker in {}'.format(fn))
return False
elif any([line.decode('UTF-8').rstrip('\r\n').endswith(c)
for c in " \t"]):
print('Found whitespace at line ending in {}'.format(fn))
return False
elif b' \t' in line or b'\t ' in line:
print('Found tab-space mix in {}'.format(fn))
return False
return True return True
@ -90,7 +100,7 @@ run('pylint', ['--ignore=appdirs.py', '--output-format=colorized',
# FIXME what the hell is the flake8 exit status? # FIXME what the hell is the flake8 exit status?
run('flake8', ['--max-complexity=10', '--exclude=appdirs.py', run('flake8', ['--max-complexity=10', '--exclude=appdirs.py',
'--ignore=' + ''.join(flake8_disable)]) '--ignore=' + ''.join(flake8_disable)])
check_crlf() check_line()
print('Exit status values:') print('Exit status values:')
for (k, v) in status.items(): for (k, v) in status.items():