From ecbebba9e972fb9b6c65c0fa32d9aa64502f10dd Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sun, 16 Nov 2014 00:05:20 +0100 Subject: [PATCH] hints: Ignore TypeError when disconnecting contentsSizeChanged. Fixes #263. --- qutebrowser/browser/hints.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/qutebrowser/browser/hints.py b/qutebrowser/browser/hints.py index 46e0442b5..30ac0e361 100644 --- a/qutebrowser/browser/hints.py +++ b/qutebrowser/browser/hints.py @@ -147,7 +147,14 @@ class HintManager(QObject): log.hints.debug("Disconnecting frame {}".format(f)) if objreg.get('args').debug: sip.dump(f) - f.contentsSizeChanged.disconnect(self.on_contents_size_changed) + try: + f.contentsSizeChanged.disconnect(self.on_contents_size_changed) + except TypeError: + # It seems we can get this here: + # TypeError: disconnect() failed between + # 'contentsSizeChanged' and 'on_contents_size_changed' + # See # https://github.com/The-Compiler/qutebrowser/issues/263 + pass log.hints.debug("Disconnected.") text = self.HINT_TEXTS[self._context.target] message_bridge = objreg.get('message-bridge', scope='window',