rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Update FIXMEs

Browse Source
This commit is contained in:
Florian Bruhin 2018-02-20 23:28:11 +01:00
parent 0d4e20c395
commit ea6a5de374
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
tests/unit/utils/test_urlmatch.py
View File

@ -55,8 +55,8 @@ from qutebrowser.utils import urlmatch
("http:// /", "Pattern without host"), ("http:// /", "Pattern without host"),
# Chromium: PARSE_ERROR_EMPTY_PATH # Chromium: PARSE_ERROR_EMPTY_PATH
# FIXME: should we allow this or not? # We deviate from Chromium and allow this for ease of use
# ("http://bar", "URLPattern::"), # ("http://bar", "..."),
# Chromium: PARSE_ERROR_INVALID_HOST # Chromium: PARSE_ERROR_INVALID_HOST
("http://\0www/", "May not contain NUL byte"), ("http://\0www/", "May not contain NUL byte"),
@ -94,7 +94,7 @@ def test_invalid_patterns(pattern, error):
("http://foo:1234/bar", 1234), ("http://foo:1234/bar", 1234),
("http://*.foo:1234/", 1234), ("http://*.foo:1234/", 1234),
("http://*.foo:1234/bar", 1234), ("http://*.foo:1234/bar", 1234),
# FIXME Why is this valid in Chromium? # https://bugs.chromium.org/p/chromium/issues/detail?id=812543
# ("http://:1234/", 1234), # ("http://:1234/", 1234),
("http://foo:*/", None), ("http://foo:*/", None),
("file://foo:1234/bar", None), ("file://foo:1234/bar", None),