From e927fecbbc12053d2e64deddf4bc89e570f0dcc6 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 8 Aug 2018 20:48:33 +0200 Subject: [PATCH] Make content.webrtc_public_interfaces_only work on Qt 5.11 69abc9a1a1bb6334537b89b5dcf980c40d6b8cbf added the argument for Qt 5.9, but didn't add the QWebEngineSetting for Qt >= 5.11. See #3010, #2163. --- doc/changelog.asciidoc | 2 ++ qutebrowser/browser/webengine/webenginesettings.py | 2 ++ 2 files changed, 4 insertions(+) diff --git a/doc/changelog.asciidoc b/doc/changelog.asciidoc index 89ee0b44d..e3950563a 100644 --- a/doc/changelog.asciidoc +++ b/doc/changelog.asciidoc @@ -41,6 +41,8 @@ Fixed still won't open though, due to missing support in Qt. - Crash when a download directory which can't be created is configured. - Crash in the `importer.py` script when importing Chrome bookmarks from newer Chrome versions. +- The `content.webrtc_public_interfaces_only` option didn't work on Qt 5.11 previously (it now does). + Note it still does not work on Qt 5.10 (due to a Qt bug) and Qt < 5.9.2. v1.4.1 ------ diff --git a/qutebrowser/browser/webengine/webenginesettings.py b/qutebrowser/browser/webengine/webenginesettings.py index da569eef6..77f82526a 100644 --- a/qutebrowser/browser/webengine/webenginesettings.py +++ b/qutebrowser/browser/webengine/webenginesettings.py @@ -166,6 +166,8 @@ class WebEngineSettings(websettings.AbstractSettings): # Qt 5.11 'content.autoplay': ('PlaybackRequiresUserGesture', lambda val: not val), + 'content.webrtc_public_interfaces_only': + ('WebRTCPublicInterfacesOnly', None), } for name, (attribute, converter) in new_attributes.items(): try: