rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Check for read errors in test_configfiles

Browse Source
This commit is contained in:
Florian Bruhin 2017-09-19 13:18:16 +02:00
parent 7d1549aaeb
commit e8ae672c93
1 changed files with 10 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
tests/unit/config/test_configfiles.py
View File

@ -152,6 +152,11 @@ class TestConfigPy:
text = '\n'.join(lines) text = '\n'.join(lines)
self._confpy.write_text(text, 'utf-8', ensure=True) self._confpy.write_text(text, 'utf-8', ensure=True)
def read(self):
"""Read the config.py via configfiles and check for errors."""
api = configfiles.read_config_py(self.filename)
assert not api.errors
@pytest.fixture @pytest.fixture
def confpy(self, tmpdir): def confpy(self, tmpdir):
return self.ConfPy(tmpdir) return self.ConfPy(tmpdir)
@ -162,7 +167,7 @@ class TestConfigPy:
]) ])
def test_set(self, confpy, line): def test_set(self, confpy, line):
confpy.write(line) confpy.write(line)
configfiles.read_config_py(confpy.filename) confpy.read()
assert config.instance._values['colors.hints.bg'] == 'red' assert config.instance._values['colors.hints.bg'] == 'red'
@pytest.mark.parametrize('set_first', [True, False]) @pytest.mark.parametrize('set_first', [True, False])
@ -188,7 +193,7 @@ class TestConfigPy:
else: else:
confpy.write('c.colors.hints.bg = {}'.format(get_line)) confpy.write('c.colors.hints.bg = {}'.format(get_line))
expected = 'green' expected = 'green'
configfiles.read_config_py(confpy.filename) confpy.read()
assert config.instance._values['colors.hints.bg'] == expected assert config.instance._values['colors.hints.bg'] == expected
@pytest.mark.parametrize('line, mode', [ @pytest.mark.parametrize('line, mode', [
@ -198,6 +203,7 @@ class TestConfigPy:
def test_bind(self, confpy, line, mode): def test_bind(self, confpy, line, mode):
confpy.write(line) confpy.write(line)
configfiles.read_config_py(confpy.filename) configfiles.read_config_py(confpy.filename)
confpy.read()
expected = {mode: {',a': 'message-info foo'}} expected = {mode: {',a': 'message-info foo'}}
assert config.instance._values['bindings.commands'] == expected assert config.instance._values['bindings.commands'] == expected
@ -207,13 +213,13 @@ class TestConfigPy:
]) ])
def test_unbind(self, confpy, line, key, mode): def test_unbind(self, confpy, line, key, mode):
confpy.write(line) confpy.write(line)
configfiles.read_config_py(confpy.filename) confpy.read()
expected = {mode: {key: None}} expected = {mode: {key: None}}
assert config.instance._values['bindings.commands'] == expected assert config.instance._values['bindings.commands'] == expected
def test_mutating(self, confpy): def test_mutating(self, confpy):
confpy.write('c.aliases["foo"] = "message-info foo"') confpy.write('c.aliases["foo"] = "message-info foo"')
configfiles.read_config_py(confpy.filename) confpy.read()
assert config.instance._values['aliases']['foo'] == 'message-info foo' assert config.instance._values['aliases']['foo'] == 'message-info foo'
def test_reading_default_location(self, config_tmpdir): def test_reading_default_location(self, config_tmpdir):