rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Rename _frame argument to frame.

Browse Source 
_foo is used to denote unused arguments, so renaming this as it's now used.
This commit is contained in:
Florian Bruhin 2015-05-31 21:40:19 +02:00
parent 018d7a87be
commit e7619477cd
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
qutebrowser/browser/webpage.py
View File

@ -478,22 +478,22 @@ class BrowserPage(QWebPage):
return super().extension(ext, opt, out) return super().extension(ext, opt, out)
return handler(opt, out) return handler(opt, out)
def javaScriptAlert(self, _frame, msg): def javaScriptAlert(self, frame, msg):
"""Override javaScriptAlert to use the statusbar.""" """Override javaScriptAlert to use the statusbar."""
log.js.debug("alert: {}".format(msg)) log.js.debug("alert: {}".format(msg))
if config.get('ui', 'modal-js-dialog'): if config.get('ui', 'modal-js-dialog'):
return super().javaScriptAlert(_frame, msg) return super().javaScriptAlert(frame, msg)
if (self._is_shutting_down or if (self._is_shutting_down or
config.get('content', 'ignore-javascript-alert')): config.get('content', 'ignore-javascript-alert')):
return return
self._ask("[js alert] {}".format(msg), usertypes.PromptMode.alert) self._ask("[js alert] {}".format(msg), usertypes.PromptMode.alert)
def javaScriptConfirm(self, _frame, msg): def javaScriptConfirm(self, frame, msg):
"""Override javaScriptConfirm to use the statusbar.""" """Override javaScriptConfirm to use the statusbar."""
log.js.debug("confirm: {}".format(msg)) log.js.debug("confirm: {}".format(msg))
if config.get('ui', 'modal-js-dialog'): if config.get('ui', 'modal-js-dialog'):
return super().javaScriptConfirm(_frame, msg) return super().javaScriptConfirm(frame, msg)
if self._is_shutting_down: if self._is_shutting_down:
return False return False