rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Split _is_object_editable from is_editable.

Browse Source
This commit is contained in:
Florian Bruhin 2014-06-23 14:48:18 +02:00
parent c71e9e4c83
commit e5e49ed858
1 changed files with 18 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
qutebrowser/utils/webelem.py
View File

@ -179,6 +179,23 @@ def get_child_frames(startframe):
return results return results
def _is_object_editable(elem):
"""Check if an object-element is editable."""
if not elem.hasAttribute('type'):
log.webview.debug("<object> without type clicked...")
return False
objtype = elem.attribute('type')
if objtype.startswith('application/') or elem.hasAttribute('classid'):
# Let's hope flash/java stuff has an application/* mimetype OR
# at least a classid attribute. Oh, and let's hope images/...
# DON'T have a classid attribute. HTML sucks.
log.webview.debug("<object type='{}'> clicked.".format(objtype))
return config.get('input', 'insert-mode-on-plugins')
else:
# Image/Audio/...
return False
def is_editable(elem): def is_editable(elem):
"""Check whether we should switch to insert mode for this element. """Check whether we should switch to insert mode for this element.
@ -205,18 +222,7 @@ def is_editable(elem):
# Flash/Java/... # Flash/Java/...
return config.get('input', 'insert-mode-on-plugins') return config.get('input', 'insert-mode-on-plugins')
elif tag == 'object': elif tag == 'object':
# Could be Flash/Java/..., could be image/audio/... return _is_object_editable(elem)
if not elem.hasAttribute('type'):
log.webview.debug("<object> without type clicked...")
return False
objtype = elem.attribute('type')
if (objtype.startswith('application/') or
elem.hasAttribute('classid')):
# Let's hope flash/java stuff has an application/* mimetype OR
# at least a classid attribute. Oh, and let's hope images/...
# DON'T have a classid attribute. HTML sucks.
log.webview.debug("<object type='{}'> clicked.".format(objtype))
return config.get('input', 'insert-mode-on-plugins')
elif tag == 'div': elif tag == 'div':
log.webview.debug("div with classes {} clicked!".format( log.webview.debug("div with classes {} clicked!".format(
elem.classes())) elem.classes()))