rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

urlutils: Check bogus IPs in _is_url_dns.

Browse Source
This commit is contained in:
Florian Bruhin 2015-05-20 13:22:19 +02:00
parent 40cc354030
commit e590bf26ad
1 changed files with 8 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
qutebrowser/utils/urlutils.py
View File

@ -126,6 +126,14 @@ def _is_url_dns(urlstr):
url = qurl_from_user_input(urlstr) url = qurl_from_user_input(urlstr)
if not url.isValid(): if not url.isValid():
return False return False
if (utils.raises(ValueError, ipaddress.ip_address, urlstr) and
not QHostAddress(urlstr).isNull()):
log.url.debug("Bogus IP URL -> False")
# Qt treats things like "23.42" or "1337" or "0xDEAD" as valid URLs
# which we don't want to.
return False
host = url.host() host = url.host()
log.url.debug("DNS request for {}".format(host)) log.url.debug("DNS request for {}".format(host))
if not host: if not host: