rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Revert "Add a workaround to save cookies on exit"

Browse Source 
This causes sqlite cookie errors from Chromium on shutdown...

See #2263
This reverts commit 8d55d093f2.
This commit is contained in:
Florian Bruhin 2017-02-06 22:16:05 +01:00
parent 2b6b18d7bf
commit e487fe441e
2 changed files with 2 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
CHANGELOG.asciidoc
View File

@ -58,8 +58,6 @@ Fixed
- Crash reports are now re-enabled when using QtWebEngine - Crash reports are now re-enabled when using QtWebEngine
- Fixed crashes when closing tabs while hinting - Fixed crashes when closing tabs while hinting
- Fixed starting on newer PyQt/sip versions with LibreSSL - Fixed starting on newer PyQt/sip versions with LibreSSL
- Worked around a Qt bug which caused cookies newer than 30s not to be saved on
exit with QtWebEngine.
v0.9.1 v0.9.1
------ ------

8
qutebrowser/browser/webengine/webenginesettings.py
View File

@ -26,7 +26,6 @@ Module attributes:
import os import os
from PyQt5.QtNetwork import QNetworkCookie
# pylint: disable=no-name-in-module,import-error,useless-suppression # pylint: disable=no-name-in-module,import-error,useless-suppression
from PyQt5.QtWebEngineWidgets import (QWebEngineSettings, QWebEngineProfile, from PyQt5.QtWebEngineWidgets import (QWebEngineSettings, QWebEngineProfile,
QWebEngineScript) QWebEngineScript)
@ -172,11 +171,8 @@ def init(args):
def shutdown(): def shutdown():
# WORKAROUND for https://bugreports.qt.io/browse/QTBUG-58675 # FIXME:qtwebengine do we need to do something for a clean shutdown here?
# This forces Chromium to flush its cookie store but doesn't actually pass
# delete anything.
cookie = QNetworkCookie()
QWebEngineProfile.defaultProfile().cookieStore().deleteCookie(cookie)
# Missing QtWebEngine attributes: # Missing QtWebEngine attributes: