From e3c6a0b76612c0fc1787527f4210f9c60f647724 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Sun, 3 Jul 2016 18:26:01 +0200 Subject: [PATCH] Handle OSError when closing download fileobj --- CHANGELOG.asciidoc | 5 +++++ qutebrowser/browser/webkit/downloads.py | 5 ++++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index d35038a98..7c65deca8 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -31,6 +31,11 @@ Changed - Aliases can now use `;;` to have an alias which executed multiple commands. - `:edit-url` now does nothing if the URL isn't changed in the spawned editor. +Fixed +----- + +- Fix crash when downloading with a full disk + Removed ------ diff --git a/qutebrowser/browser/webkit/downloads.py b/qutebrowser/browser/webkit/downloads.py index 6cfee6acf..fe3b6f1a9 100644 --- a/qutebrowser/browser/webkit/downloads.py +++ b/qutebrowser/browser/webkit/downloads.py @@ -413,7 +413,10 @@ class DownloadItem(QObject): self.done = True self.data_changed.emit() if self.fileobj is not None: - self.fileobj.close() + try: + self.fileobj.close() + except OSError: + log.downloads.exception("Error while closing file object") def init_reply(self, reply): """Set a new reply and connect its signals.