From e338d4b49ce8ec198ed2f000d1af4ec8cc08a42c Mon Sep 17 00:00:00 2001
From: Florian Bruhin <git@the-compiler.org>
Date: Thu, 15 Sep 2016 14:40:53 +0200
Subject: [PATCH] Add MessageView tests

---
 scripts/dev/check_coverage.py             |   2 +
 tests/unit/mainwindow/test_messageview.py | 105 ++++++++++++++++++++++
 2 files changed, 107 insertions(+)
 create mode 100644 tests/unit/mainwindow/test_messageview.py

diff --git a/scripts/dev/check_coverage.py b/scripts/dev/check_coverage.py
index 8529788f2..06043ea30 100644
--- a/scripts/dev/check_coverage.py
+++ b/scripts/dev/check_coverage.py
@@ -119,6 +119,8 @@ PERFECT_FILES = [
         'qutebrowser/mainwindow/statusbar/prompt.py'),
     ('tests/unit/mainwindow/statusbar/test_url.py',
         'qutebrowser/mainwindow/statusbar/url.py'),
+    ('tests/unit/mainwindow/messageview.py',
+        'qutebrowser/mainwindow/messageview.py'),
 
     ('tests/unit/config/test_configtypes.py',
         'qutebrowser/config/configtypes.py'),
diff --git a/tests/unit/mainwindow/test_messageview.py b/tests/unit/mainwindow/test_messageview.py
new file mode 100644
index 000000000..7dce5f076
--- /dev/null
+++ b/tests/unit/mainwindow/test_messageview.py
@@ -0,0 +1,105 @@
+# vim: ft=python fileencoding=utf-8 sts=4 sw=4 et:
+
+# Copyright 2016 Florian Bruhin (The Compiler) <mail@qutebrowser.org>
+#
+# This file is part of qutebrowser.
+#
+# qutebrowser is free software: you can redistribute it and/or modify
+# it under the terms of the GNU General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# qutebrowser is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
+
+import sip
+import pytest
+
+from qutebrowser.mainwindow import messageview
+from qutebrowser.utils import usertypes
+
+
+@pytest.fixture
+def view(qtbot, config_stub):
+    config_stub.data = {
+        'colors': {
+            'messages.fg.error': 'white',
+            'messages.bg.error': 'red',
+            'messages.border.error': '#bb0000',
+            'messages.fg.warning': 'white',
+            'messages.bg.warning': 'darkorange',
+            'messages.border.warning': '#d47300',
+            'messages.fg.info': 'white',
+            'messages.bg.info': 'black',
+            'messages.border.info': '#333333',
+        },
+        'fonts': {
+            'messages.error': '8pt Monospace',
+            'messages.warning': '8pt Monospace',
+            'messages.info': '8pt Monospace',
+        },
+        'ui': {
+            'message-timeout': 100,
+        }
+    }
+    mv = messageview.MessageView()
+    qtbot.add_widget(mv)
+    return mv
+
+
+@pytest.mark.parametrize('level', [usertypes.MessageLevel.info,
+                                   usertypes.MessageLevel.warning,
+                                   usertypes.MessageLevel.error])
+def test_single_message(qtbot, view, level):
+    view.show_message(level, 'test')
+    qtbot.waitForWindowShown(view)
+    assert view._messages[0].isVisible()
+
+
+def test_message_hiding(qtbot, view):
+    """Messages should be hidden after the timer times out."""
+    with qtbot.waitSignal(view._clear_timer.timeout):
+        view.show_message(usertypes.MessageLevel.info, 'test')
+        message = view._messages[0]
+    assert not view._messages
+
+
+def test_message_height(view):
+    """The message height should increase with more messages."""
+    view.show_message(usertypes.MessageLevel.info, 'test1')
+    height1 = view.message_height()
+    assert height1 > 0
+    view.show_message(usertypes.MessageLevel.info, 'test2')
+    height2 = view.message_height()
+    assert height2 == height1 * 2
+
+
+def test_show_message_twice(view):
+    """Show the same message twice -> only one should be shown."""
+    view.show_message(usertypes.MessageLevel.info, 'test')
+    view.show_message(usertypes.MessageLevel.info, 'test')
+    assert len(view._messages) == 1
+
+
+def test_show_message_twice_after_first_disappears(qtbot, view):
+    """Show the same message twice after the first is gone."""
+    with qtbot.waitSignal(view._clear_timer.timeout):
+        view.show_message(usertypes.MessageLevel.info, 'test')
+    # Just a sanity check
+    assert not view._messages
+
+    view.show_message(usertypes.MessageLevel.info, 'test')
+    assert len(view._messages) == 1
+
+
+def test_changing_timer_with_messages_shown(qtbot, view, config_stub):
+    """When we change ui -> message-timeout, the timer should be restarted."""
+    config_stub['ui']['message-timeout'] = 900000  # 15s
+    view.show_message(usertypes.MessageLevel.info, 'test')
+    with qtbot.waitSignal(view._clear_timer.timeout):
+        config_stub.set('ui', 'message-timeout', 100)