rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Better debugging for editing

Browse Source
This commit is contained in:
Florian Bruhin 2014-07-16 09:28:28 +02:00
parent 0812057cbc
commit e250d42f0b
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qutebrowser/browser/commands.py
View File

@ -737,7 +737,11 @@ class CommandDispatcher:
if elem.isNull(): if elem.isNull():
raise CommandError("Element vanished while editing!") raise CommandError("Element vanished while editing!")
if webelem.is_content_editable(elem): if webelem.is_content_editable(elem):
log.misc.debug("Filling element {} via setPlainText.".format(
webelem.debug_text(elem)))
elem.setPlainText(text) elem.setPlainText(text)
else: else:
log.misc.debug("Filling element {} via javascript.".format(
webelem.debug_text(elem)))
text = webelem.javascript_escape(text) text = webelem.javascript_escape(text)
elem.evaluateJavaScript("this.value='{}'".format(text)) elem.evaluateJavaScript("this.value='{}'".format(text))

7
qutebrowser/utils/webelem.py
View File

@ -249,7 +249,7 @@ def is_editable(elem, strict=False):
# pylint: disable=too-many-return-statements # pylint: disable=too-many-return-statements
roles = ('combobox', 'textbox') roles = ('combobox', 'textbox')
log.misc.debug("Checking if element is editable: {}".format( log.misc.debug("Checking if element is editable: {}".format(
compact_text(elem.toOuterXml(), 500))) debug_text(elem)))
tag = elem.tagName().lower() tag = elem.tagName().lower()
if is_content_editable(elem) and is_writable(elem): if is_content_editable(elem) and is_writable(elem):
return True return True
@ -279,3 +279,8 @@ def focus_elem(frame):
frame: The QWebFrame to search in. frame: The QWebFrame to search in.
""" """
return frame.findFirstElement(SELECTORS[Group.focus]) return frame.findFirstElement(SELECTORS[Group.focus])
def debug_text(elem):
"""Get a text based on an element suitable for debug output."""
return compact_text(elem.toOuterXml(), 500)