From e029139764057289ccc34a73ff39140c41d1637e Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Thu, 25 Sep 2014 06:54:49 +0200 Subject: [PATCH] Fix exception when adding quickmark with empty name. --- qutebrowser/browser/quickmarks.py | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/qutebrowser/browser/quickmarks.py b/qutebrowser/browser/quickmarks.py index fe83df188..4c91438f8 100644 --- a/qutebrowser/browser/quickmarks.py +++ b/qutebrowser/browser/quickmarks.py @@ -78,10 +78,14 @@ def quickmark_add(url, name): url: The url to add as quickmark. name: The name for the new quickmark. """ + # We don't raise cmdexc.CommandError here as this can be called async via + # prompt_save. if not name: - raise cmdexc.CommandError("Can't set mark with empty name!") + message.error("Can't set mark with empty name!") + return if not url: - raise cmdexc.CommandError("Can't set mark with empty URL!") + message.error("Can't set mark with empty URL!") + return def set_mark(): """Really set the quickmark."""