rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Fix overflow handling for QtWebKit scrolling

Browse Source 
If we do "m * val / 100", the value gets bigger, so we need to check for an
overflow afterwards.
This commit is contained in:
Florian Bruhin 2017-10-15 22:30:17 +02:00
parent fa4a66f7b3
commit e003b11670
1 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
qutebrowser/browser/webkit/webkittab.py
View File

@ -422,12 +422,13 @@ class WebKitScroller(browsertab.AbstractScroller):
else: else:
for val, orientation in [(x, Qt.Horizontal), (y, Qt.Vertical)]: for val, orientation in [(x, Qt.Horizontal), (y, Qt.Vertical)]:
if val is not None: if val is not None:
val = qtutils.check_overflow(val, 'int', fatal=False)
frame = self._widget.page().mainFrame() frame = self._widget.page().mainFrame()
m = frame.scrollBarMaximum(orientation) maximum = frame.scrollBarMaximum(orientation)
if m == 0: if maximum == 0:
continue continue
frame.setScrollBarValue(orientation, int(m * val / 100)) pos = int(maximum * val / 100)
pos = qtutils.check_overflow(pos, 'int', fatal=False)
frame.setScrollBarValue(orientation, pos)
def _key_press(self, key, count=1, getter_name=None, direction=None): def _key_press(self, key, count=1, getter_name=None, direction=None):
frame = self._widget.page().mainFrame() frame = self._widget.page().mainFrame()