Fix message.confirm_async calls

This commit is contained in:
Florian Bruhin 2016-10-26 19:50:11 +02:00
parent bc4e340323
commit dff20ffe35
2 changed files with 7 additions and 5 deletions

View File

@ -204,7 +204,8 @@ class QuickmarkManager(UrlMarkManager):
if name in self.marks:
message.confirm_async(
win_id, "Override existing quickmark?", set_mark, default=True)
win_id, title="Override existing quickmark?",
yes_action=set_mark, default=True)
else:
set_mark()

View File

@ -137,11 +137,12 @@ class BrowserPage(QWebPage):
# QDesktopServices::openUrl with info.url directly - however it
# works when we construct a copy of it.
url = QUrl(info.url)
msg = "Open external application for {}-link?\nURL: {}".format(
url.scheme(), url.toDisplayString())
scheme = url.scheme()
message.confirm_async(
self._win_id, msg,
functools.partial(QDesktopServices.openUrl, url))
self._win_id,
title="Open external application for {}-link?".format(scheme),
text="URL: {}".format(url.toDisplayString()),
yes_action=functools.partial(QDesktopServices.openUrl, url))
return True
elif (info.domain, info.error) in ignored_errors:
log.webview.debug("Ignored error on {}: {} (error domain: {}, "