From de5cdf6f0f8620ebb2341bfb2c8e488521a1b72d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Thorsten=20Wi=C3=9Fmann?= <edu@thorsten-wissmann.de>
Date: Thu, 3 Sep 2015 16:33:49 +0200
Subject: [PATCH] Also hide <embed> tags

But only hide those tags that aren't children (or descendants) of other
tags that get replaced anyway. That is needed because sometimes, flash
videos are in <embed> tags, sometimgs in <object> tags and sometimes in
<embed> tags within <object> tags.

Furthermore enforce our "click here" link to have transparent background
(and in future: remove as many properties from website specific CSS
stylesheets).
---
 misc/userscripts/view_in_mpv | 26 +++++++++++++++++++++++---
 1 file changed, 23 insertions(+), 3 deletions(-)

diff --git a/misc/userscripts/view_in_mpv b/misc/userscripts/view_in_mpv
index 358ddcfcc..98e197d4d 100755
--- a/misc/userscripts/view_in_mpv
+++ b/misc/userscripts/view_in_mpv
@@ -2,9 +2,9 @@
 #
 # Behaviour:
 #   Userscript for qutebrowser which views the current web page in mpv using
-#   sensible mpv-flags. While viewing the page in MPV, all <video> and <object>
-#   tags in the original page are temporarily removed. Clicking on such a
-#   removed video restores the respective video.
+#   sensible mpv-flags. While viewing the page in MPV, all <video>, <embed>,
+#   and <object> tags in the original page are temporarily removed. Clicking on
+#   such a removed video restores the respective video.
 #
 #   In order to use this script, just start it using `spawn --userscript` from
 #   qutebrowser. I recommend using an alias, e.g. put this in the
@@ -43,15 +43,34 @@ video_command=( "$MPV_COMMAND"  $MPV_FLAGS )
 js() {
 cat <<EOF
 
+    function descendantOfTagName(child, ancestorTagName) {
+        // tells whether child has some (proper) ancestor
+        // with the tag name ancestorTagName
+        while (child.parentNode != null) {
+            child = child.parentNode;
+            if (typeof child.tagName === 'undefined') break;
+            if (child.tagName.toUpperCase() == ancestorTagName.toUpperCase()) {
+                return true;
+            }
+        }
+        return false;
+    }
+
     var App = {};
 
     var all_videos = [];
     all_videos.push.apply(all_videos, document.getElementsByTagName("video"));
     all_videos.push.apply(all_videos, document.getElementsByTagName("object"));
+    all_videos.push.apply(all_videos, document.getElementsByTagName("embed"));
     App.backup_videos = Array();
     App.all_replacements = Array();
     for (i = 0; i < all_videos.length; i++) {
         var video = all_videos[i];
+        if (descendantOfTagName(video, "object")) {
+            // skip tags that are contained in an object, because we hide
+            // the object anyway.
+            continue;
+        }
         var replacement = document.createElement("div");
         replacement.innerHTML = "
             <p style=\\"margin-bottom: 0.5em\\">
@@ -62,6 +81,7 @@ cat <<EOF
             In order to restore this particular video
             <a style=\\"font-weight: bold;
                         color: white;
+                        background: transparent;
                      \\"
                onClick=\\"restore_video(this, " + i + ");\\"
                href=\\"javascript: restore_video(this, " + i + ")\\"