rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Replace all GitHub links

Browse Source
This commit is contained in:
Florian Bruhin 2017-02-05 00:13:11 +01:00
parent ba5ac6139a
commit de50f30b9b
80 changed files with 165 additions and 165 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.travis.yml
View File

@ -21,7 +21,7 @@ matrix:
- os: osx - os: osx
env: TESTENV=py35 OSX=elcapitan env: TESTENV=py35 OSX=elcapitan
osx_image: xcode7.3 osx_image: xcode7.3
# https://github.com/The-Compiler/qutebrowser/issues/2013 # https://github.com/qutebrowser/qutebrowser/issues/2013
# - os: osx # - os: osx
# env: TESTENV=py35 OSX=yosemite # env: TESTENV=py35 OSX=yosemite
# osx_image: xcode6.4 # osx_image: xcode6.4

14
CHANGELOG.asciidoc
View File

@ -845,7 +845,7 @@ Fixed
- Fixed horrible completion performance when the `shrink` option was set. - Fixed horrible completion performance when the `shrink` option was set.
- Sessions now store zoom/scroll-position correctly. - Sessions now store zoom/scroll-position correctly.
https://github.com/The-Compiler/qutebrowser/releases/tag/v0.2.1[v0.2.1] https://github.com/qutebrowser/qutebrowser/releases/tag/v0.2.1[v0.2.1]
----------------------------------------------------------------------- -----------------------------------------------------------------------
Fixed Fixed
@ -853,7 +853,7 @@ Fixed
- Added missing manpage (doc/qutebrowser.1.asciidoc) to archive. - Added missing manpage (doc/qutebrowser.1.asciidoc) to archive.
https://github.com/The-Compiler/qutebrowser/releases/tag/v0.2.0[v0.2.0] https://github.com/qutebrowser/qutebrowser/releases/tag/v0.2.0[v0.2.0]
----------------------------------------------------------------------- -----------------------------------------------------------------------
Added Added
@ -996,7 +996,7 @@ Fixed
- Add a timeout to pastebin HTTP replies. - Add a timeout to pastebin HTTP replies.
- Various other fixes for small/rare bugs. - Various other fixes for small/rare bugs.
https://github.com/The-Compiler/qutebrowser/releases/tag/v0.1.4[v0.1.4] https://github.com/qutebrowser/qutebrowser/releases/tag/v0.1.4[v0.1.4]
----------------------------------------------------------------------- -----------------------------------------------------------------------
Changed Changed
@ -1040,7 +1040,7 @@ Security
* Stop the icon database from being created when private-browsing is set to true. * Stop the icon database from being created when private-browsing is set to true.
* Disable insecure SSL ciphers. * Disable insecure SSL ciphers.
https://github.com/The-Compiler/qutebrowser/releases/tag/v0.1.3[v0.1.3] https://github.com/qutebrowser/qutebrowser/releases/tag/v0.1.3[v0.1.3]
----------------------------------------------------------------------- -----------------------------------------------------------------------
Changed Changed
@ -1074,7 +1074,7 @@ Security
* Fix for HTTP passwords accidentally being written to debug log. * Fix for HTTP passwords accidentally being written to debug log.
https://github.com/The-Compiler/qutebrowser/releases/tag/v0.1.2[v0.1.2] https://github.com/qutebrowser/qutebrowser/releases/tag/v0.1.2[v0.1.2]
----------------------------------------------------------------------- -----------------------------------------------------------------------
Changed Changed
@ -1106,7 +1106,7 @@ Fixed
* Fix user-stylesheet setting with an empty value. * Fix user-stylesheet setting with an empty value.
https://github.com/The-Compiler/qutebrowser/releases/tag/v0.1.1[v0.1.1] https://github.com/qutebrowser/qutebrowser/releases/tag/v0.1.1[v0.1.1]
----------------------------------------------------------------------- -----------------------------------------------------------------------
Added Added
@ -1164,7 +1164,7 @@ Fixed
* Ensure the docs get included in `freeze.py`. * Ensure the docs get included in `freeze.py`.
* Fix crash with `:zoom`. * Fix crash with `:zoom`.
https://github.com/The-Compiler/qutebrowser/releases/tag/v0.1[v0.1] https://github.com/qutebrowser/qutebrowser/releases/tag/v0.1[v0.1]
------------------------------------------------------------------- -------------------------------------------------------------------
Initial release. Initial release.

12
CONTRIBUTING.asciidoc
View File

@ -34,12 +34,12 @@ this. It might be a good idea to ask on the mailing list or IRC channel to make
sure nobody else started working on the same thing already. sure nobody else started working on the same thing already.
If you want to find something useful to do, check the If you want to find something useful to do, check the
https://github.com/The-Compiler/qutebrowser/issues[issue tracker]. Some https://github.com/qutebrowser/qutebrowser/issues[issue tracker]. Some
pointers: pointers:
* https://github.com/The-Compiler/qutebrowser/labels/easy[Issues which should * https://github.com/qutebrowser/qutebrowser/labels/easy[Issues which should
be easy to solve] be easy to solve]
* https://github.com/The-Compiler/qutebrowser/labels/not%20code[Issues which * https://github.com/qutebrowser/qutebrowser/labels/not%20code[Issues which
require little/no coding] require little/no coding]
There are also some things to do if you don't want to write code: There are also some things to do if you don't want to write code:
@ -55,7 +55,7 @@ qutebrowser uses http://git-scm.com/[git] for its development. You can clone
the repo like this: the repo like this:
---- ----
git clone https://github.com/The-Compiler/qutebrowser.git git clone https://github.com/qutebrowser/qutebrowser.git
---- ----
If you don't know git, a http://git-scm.com/[git cheatsheet] might come in If you don't know git, a http://git-scm.com/[git cheatsheet] might come in
@ -629,7 +629,7 @@ and make sure all bugs marked as resolved are actually fixed.
* Grep for `WORKAROUND` in the code and test if fixed stuff works without the * Grep for `WORKAROUND` in the code and test if fixed stuff works without the
workaround. workaround.
* Check relevant * Check relevant
https://github.com/The-Compiler/qutebrowser/issues?q=is%3Aopen+is%3Aissue+label%3Aqt[qutebrowser https://github.com/qutebrowser/qutebrowser/issues?q=is%3Aopen+is%3Aissue+label%3Aqt[qutebrowser
bugs] and check if they're fixed. bugs] and check if they're fixed.
New PyQt release New PyQt release
@ -659,7 +659,7 @@ qutebrowser release
* `git push origin`; `git push origin v0.$x.$y` * `git push origin`; `git push origin v0.$x.$y`
* If committing on minor branch, cherry-pick release commit to master. * If committing on minor branch, cherry-pick release commit to master.
* Create release on github * Create release on github
* Mark the milestone at https://github.com/The-Compiler/qutebrowser/milestones * Mark the milestone at https://github.com/qutebrowser/qutebrowser/milestones
as closed. as closed.
* Linux: Run `python3 scripts/dev/build_release.py --upload v0.$x.$y` * Linux: Run `python3 scripts/dev/build_release.py --upload v0.$x.$y`

8
FAQ.asciidoc
View File

@ -105,7 +105,7 @@ It also works nicely with rapid hints:
How do I use qutebrowser with mutt?:: How do I use qutebrowser with mutt?::
Due to a Qt limitation, local files without `.html` extensions are Due to a Qt limitation, local files without `.html` extensions are
"downloaded" instead of displayed, see "downloaded" instead of displayed, see
https://github.com/The-Compiler/qutebrowser/issues/566[#566]. You can work https://github.com/qutebrowser/qutebrowser/issues/566[#566]. You can work
around this by using this in your `mailcap`: around this by using this in your `mailcap`:
+ +
---- ----
@ -141,7 +141,7 @@ Experiencing freezing on sites like duckduckgo and youtube.::
This issue could be caused by stale plugin files installed by `mozplugger` This issue could be caused by stale plugin files installed by `mozplugger`
if mozplugger was subsequently removed. if mozplugger was subsequently removed.
Try exiting qutebrowser and removing `~/.mozilla/plugins/mozplugger*.so`. Try exiting qutebrowser and removing `~/.mozilla/plugins/mozplugger*.so`.
See https://github.com/The-Compiler/qutebrowser/issues/357[Issue #357] See https://github.com/qutebrowser/qutebrowser/issues/357[Issue #357]
for more details. for more details.
Experiencing segfaults (crashes) on Debian systems.:: Experiencing segfaults (crashes) on Debian systems.::
@ -155,7 +155,7 @@ Segfaults on Facebook, Medium, Amazon, ...::
visiting these sites. This is caused by various bugs in Qt which have been visiting these sites. This is caused by various bugs in Qt which have been
fixed in Qt 5.4. However Debian and Ubuntu are slow to adopt or upgrade fixed in Qt 5.4. However Debian and Ubuntu are slow to adopt or upgrade
some packages. On Debian Jessie, it's recommended to use the experimental some packages. On Debian Jessie, it's recommended to use the experimental
repos as described in https://github.com/The-Compiler/qutebrowser/blob/master/INSTALL.asciidoc#on-debian--ubuntu[INSTALL]. repos as described in https://github.com/qutebrowser/qutebrowser/blob/master/INSTALL.asciidoc#on-debian--ubuntu[INSTALL].
+ +
Since Ubuntu Trusty (using Qt 5.2.1), Since Ubuntu Trusty (using Qt 5.2.1),
https://bugreports.qt.io/browse/QTBUG-42417?jql=component%20%3D%20WebKit%20and%20resolution%20%3D%20Done%20and%20fixVersion%20in%20(5.3.0%2C%20%225.3.0%20Alpha%22%2C%20%225.3.0%20Beta1%22%2C%20%225.3.0%20RC1%22%2C%205.3.1%2C%205.3.2%2C%205.4.0%2C%20%225.4.0%20Alpha%22%2C%20%225.4.0%20Beta%22%2C%20%225.4.0%20RC%22)%20and%20priority%20in%20(%22P2%3A%20Important%22%2C%20%22P1%3A%20Critical%22%2C%20%22P0%3A%20Blocker%22)[over https://bugreports.qt.io/browse/QTBUG-42417?jql=component%20%3D%20WebKit%20and%20resolution%20%3D%20Done%20and%20fixVersion%20in%20(5.3.0%2C%20%225.3.0%20Alpha%22%2C%20%225.3.0%20Beta1%22%2C%20%225.3.0%20RC1%22%2C%205.3.1%2C%205.3.2%2C%205.4.0%2C%20%225.4.0%20Alpha%22%2C%20%225.4.0%20Beta%22%2C%20%225.4.0%20RC%22)%20and%20priority%20in%20(%22P2%3A%20Important%22%2C%20%22P1%3A%20Critical%22%2C%20%22P0%3A%20Blocker%22)[over
@ -166,7 +166,7 @@ https://bugreports.qt.io/browse/QTBUG-42417?jql=component%20%3D%20WebKit%20and%2
My issue is not listed.:: My issue is not listed.::
If you experience any segfaults or crashes, you can report the issue in If you experience any segfaults or crashes, you can report the issue in
https://github.com/The-Compiler/qutebrowser/issues[the issue tracker] or https://github.com/qutebrowser/qutebrowser/issues[the issue tracker] or
using the `:report` command. using the `:report` command.
If you are reporting a segfault, make sure you read the If you are reporting a segfault, make sure you read the
link:doc/stacktrace.asciidoc[guide] on how to report them with all needed link:doc/stacktrace.asciidoc[guide] on how to report them with all needed

8
INSTALL.asciidoc
View File

@ -25,7 +25,7 @@ Install the dependencies via apt-get:
---- ----
Get the qutebrowser package from the Get the qutebrowser package from the
https://github.com/The-Compiler/qutebrowser/releases[release page] and download https://github.com/qutebrowser/qutebrowser/releases[release page] and download
the https://qutebrowser.org/python3-pypeg2_2.15.2-1_all.deb[PyPEG2 package]. the https://qutebrowser.org/python3-pypeg2_2.15.2-1_all.deb[PyPEG2 package].
Install the packages: Install the packages:
@ -214,7 +214,7 @@ Prebuilt binaries
~~~~~~~~~~~~~~~~~ ~~~~~~~~~~~~~~~~~
Prebuilt standalone packages and MSI installers Prebuilt standalone packages and MSI installers
https://github.com/The-Compiler/qutebrowser/releases[are built] for every https://github.com/qutebrowser/qutebrowser/releases[are built] for every
release. release.
https://chocolatey.org/packages/qutebrowser[Chocolatey package] https://chocolatey.org/packages/qutebrowser[Chocolatey package]
@ -254,7 +254,7 @@ Prebuilt binary
The easiest way to install qutebrowser on OS X is to use the prebuilt `.app` The easiest way to install qutebrowser on OS X is to use the prebuilt `.app`
files from the files from the
https://github.com/The-Compiler/qutebrowser/releases[release page]. https://github.com/qutebrowser/qutebrowser/releases[release page].
This binary is also available through the This binary is also available through the
https://caskroom.github.io/[Homebrew Cask] package manager: https://caskroom.github.io/[Homebrew Cask] package manager:
@ -313,7 +313,7 @@ First of all, clone the repository using http://git-scm.org/[git] and switch
into the repository folder: into the repository folder:
---- ----
$ git clone https://github.com/The-Compiler/qutebrowser.git $ git clone https://github.com/qutebrowser/qutebrowser.git
$ cd qutebrowser $ cd qutebrowser
---- ----

8
README.asciidoc
View File

@ -1,7 +1,7 @@
// If you are reading this in plaintext or on PyPi: // If you are reading this in plaintext or on PyPi:
// //
// A rendered version is available at: // A rendered version is available at:
// https://github.com/The-Compiler/qutebrowser/blob/master/README.asciidoc // https://github.com/qutebrowser/qutebrowser/blob/master/README.asciidoc
qutebrowser qutebrowser
=========== ===========
@ -9,14 +9,14 @@ qutebrowser
// QUTE_WEB_HIDE // QUTE_WEB_HIDE
image:icons/qutebrowser-64x64.png[qutebrowser logo] *A keyboard-driven, vim-like browser based on PyQt5 and QtWebKit.* image:icons/qutebrowser-64x64.png[qutebrowser logo] *A keyboard-driven, vim-like browser based on PyQt5 and QtWebKit.*
image:https://img.shields.io/pypi/l/qutebrowser.svg?style=flat["license badge",link="https://github.com/The-Compiler/qutebrowser/blob/master/COPYING"] image:https://img.shields.io/pypi/l/qutebrowser.svg?style=flat["license badge",link="https://github.com/qutebrowser/qutebrowser/blob/master/COPYING"]
image:https://img.shields.io/pypi/v/qutebrowser.svg?style=flat["version badge",link="https://pypi.python.org/pypi/qutebrowser/"] image:https://img.shields.io/pypi/v/qutebrowser.svg?style=flat["version badge",link="https://pypi.python.org/pypi/qutebrowser/"]
image:https://requires.io/github/The-Compiler/qutebrowser/requirements.svg?branch=master["requirements badge",link="https://requires.io/github/The-Compiler/qutebrowser/requirements/?branch=master"] image:https://requires.io/github/The-Compiler/qutebrowser/requirements.svg?branch=master["requirements badge",link="https://requires.io/github/The-Compiler/qutebrowser/requirements/?branch=master"]
image:https://travis-ci.org/The-Compiler/qutebrowser.svg?branch=master["Build Status", link="https://travis-ci.org/The-Compiler/qutebrowser"] image:https://travis-ci.org/The-Compiler/qutebrowser.svg?branch=master["Build Status", link="https://travis-ci.org/The-Compiler/qutebrowser"]
image:https://ci.appveyor.com/api/projects/status/9gmnuip6i1oq7046?svg=true["AppVeyor build status", link="https://ci.appveyor.com/project/The-Compiler/qutebrowser"] image:https://ci.appveyor.com/api/projects/status/9gmnuip6i1oq7046?svg=true["AppVeyor build status", link="https://ci.appveyor.com/project/The-Compiler/qutebrowser"]
image:https://codecov.io/github/The-Compiler/qutebrowser/coverage.svg?branch=master["coverage badge",link="https://codecov.io/github/The-Compiler/qutebrowser?branch=master"] image:https://codecov.io/github/The-Compiler/qutebrowser/coverage.svg?branch=master["coverage badge",link="https://codecov.io/github/The-Compiler/qutebrowser?branch=master"]
link:https://www.qutebrowser.org[website] | link:https://blog.qutebrowser.org[blog] | link:https://github.com/The-Compiler/qutebrowser/releases[releases] link:https://www.qutebrowser.org[website] | link:https://blog.qutebrowser.org[blog] | link:https://github.com/qutebrowser/qutebrowser/releases[releases]
// QUTE_WEB_HIDE_END // QUTE_WEB_HIDE_END
qutebrowser is a keyboard-focused browser with a minimal GUI. It's based qutebrowser is a keyboard-focused browser with a minimal GUI. It's based
@ -35,7 +35,7 @@ image:doc/img/hints.png["screenshot 4",width=300,link="doc/img/hints.png"]
Downloads Downloads
--------- ---------
See the https://github.com/The-Compiler/qutebrowser/releases[github releases See the https://github.com/qutebrowser/qutebrowser/releases[github releases
page] for available downloads (currently a source archive, and standalone page] for available downloads (currently a source archive, and standalone
packages as well as MSI installers for Windows). packages as well as MSI installers for Windows).

4
doc/qutebrowser.1.asciidoc
View File

@ -127,7 +127,7 @@ defaults.
== BUGS == BUGS
Bugs are tracked in the Github issue tracker at Bugs are tracked in the Github issue tracker at
https://github.com/The-Compiler/qutebrowser/issues. https://github.com/qutebrowser/qutebrowser/issues.
If you found a bug, use the built-in ':report' command to create a bug report If you found a bug, use the built-in ':report' command to create a bug report
with all information needed. with all information needed.
@ -160,7 +160,7 @@ https://lists.schokokeks.org/mailman/listinfo.cgi/qutebrowser
https://lists.schokokeks.org/mailman/listinfo.cgi/qutebrowser-announce https://lists.schokokeks.org/mailman/listinfo.cgi/qutebrowser-announce
* IRC: irc://irc.freenode.org/#qutebrowser[`#qutebrowser`] on * IRC: irc://irc.freenode.org/#qutebrowser[`#qutebrowser`] on
http://freenode.net/[Freenode] http://freenode.net/[Freenode]
* Github: https://github.com/The-Compiler/qutebrowser * Github: https://github.com/qutebrowser/qutebrowser
== AUTHOR == AUTHOR
*qutebrowser* was written by Florian Bruhin. All contributors can be found in *qutebrowser* was written by Florian Bruhin. All contributors can be found in

2
pytest.ini
View File

@ -20,7 +20,7 @@ markers =
qtwebengine_flaky: Tests which are flaky (and currently skipped) with QtWebEngine qtwebengine_flaky: Tests which are flaky (and currently skipped) with QtWebEngine
qtwebengine_osx_xfail: Tests which fail on OS X with QtWebEngine qtwebengine_osx_xfail: Tests which fail on OS X with QtWebEngine
js_prompt: Tests needing to display a javascript prompt js_prompt: Tests needing to display a javascript prompt
issue2183: https://github.com/The-Compiler/qutebrowser/issues/2183 issue2183: https://github.com/qutebrowser/qutebrowser/issues/2183
this: Used to mark tests during development this: Used to mark tests during development
qt_log_level_fail = WARNING qt_log_level_fail = WARNING
qt_log_ignore = qt_log_ignore =

2
qutebrowser/app.py
View File

@ -534,7 +534,7 @@ class Quitter:
if not os.path.isdir(cwd): if not os.path.isdir(cwd):
# Probably running from a python egg. Let's fallback to # Probably running from a python egg. Let's fallback to
# cwd=None and see if that works out. # cwd=None and see if that works out.
# See https://github.com/The-Compiler/qutebrowser/issues/323 # See https://github.com/qutebrowser/qutebrowser/issues/323
cwd = None cwd = None
# Add all open pages so they get reopened. # Add all open pages so they get reopened.

2
qutebrowser/browser/browsertab.py
View File

@ -182,7 +182,7 @@ class AbstractZoom(QObject):
# # FIXME:qtwebengine is this needed? # # FIXME:qtwebengine is this needed?
# # For some reason, this signal doesn't get disconnected automatically # # For some reason, this signal doesn't get disconnected automatically
# # when the WebView is destroyed on older PyQt versions. # # when the WebView is destroyed on older PyQt versions.
# # See https://github.com/The-Compiler/qutebrowser/issues/390 # # See https://github.com/qutebrowser/qutebrowser/issues/390
# self.destroyed.connect(functools.partial( # self.destroyed.connect(functools.partial(
# cfg.changed.disconnect, self.init_neighborlist)) # cfg.changed.disconnect, self.init_neighborlist))

6
qutebrowser/browser/commands.py
View File

@ -652,7 +652,7 @@ class CommandDispatcher:
""" """
tab = self._current_widget() tab = self._current_widget()
if not tab.url().isValid(): if not tab.url().isValid():
# See https://github.com/The-Compiler/qutebrowser/issues/701 # See https://github.com/qutebrowser/qutebrowser/issues/701
return return
if bottom_navigate is not None and tab.scroller.at_bottom(): if bottom_navigate is not None and tab.scroller.at_bottom():
@ -833,7 +833,7 @@ class CommandDispatcher:
""" """
if self._count() == 0: if self._count() == 0:
# Running :tab-prev after last tab was closed # Running :tab-prev after last tab was closed
# See https://github.com/The-Compiler/qutebrowser/issues/1448 # See https://github.com/qutebrowser/qutebrowser/issues/1448
return return
newidx = self._current_index() - count newidx = self._current_index() - count
if newidx >= 0: if newidx >= 0:
@ -853,7 +853,7 @@ class CommandDispatcher:
""" """
if self._count() == 0: if self._count() == 0:
# Running :tab-next after last tab was closed # Running :tab-next after last tab was closed
# See https://github.com/The-Compiler/qutebrowser/issues/1448 # See https://github.com/qutebrowser/qutebrowser/issues/1448
return return
newidx = self._current_index() + count newidx = self._current_index() + count
if newidx < self._count(): if newidx < self._count():

4
qutebrowser/browser/downloads.py
View File

@ -125,7 +125,7 @@ def create_full_filename(basename, filename):
The full absolute path, or None if filename creation was not possible. The full absolute path, or None if filename creation was not possible.
""" """
# Remove chars which can't be encoded in the filename encoding. # Remove chars which can't be encoded in the filename encoding.
# See https://github.com/The-Compiler/qutebrowser/issues/427 # See https://github.com/qutebrowser/qutebrowser/issues/427
encoding = sys.getfilesystemencoding() encoding = sys.getfilesystemencoding()
filename = utils.force_encoding(filename, encoding) filename = utils.force_encoding(filename, encoding)
basename = utils.force_encoding(basename, encoding) basename = utils.force_encoding(basename, encoding)
@ -741,7 +741,7 @@ class AbstractDownloadManager(QObject):
def _remove_item(self, download): def _remove_item(self, download):
"""Remove a given download.""" """Remove a given download."""
if sip.isdeleted(self): if sip.isdeleted(self):
# https://github.com/The-Compiler/qutebrowser/issues/1242 # https://github.com/qutebrowser/qutebrowser/issues/1242
return return
try: try:
idx = self.downloads.index(download) idx = self.downloads.index(download)

4
qutebrowser/browser/downloadview.py
View File

@ -39,8 +39,8 @@ def update_geometry(obj):
Here we check if obj ("self") was deleted and just ignore the event if so. Here we check if obj ("self") was deleted and just ignore the event if so.
Original bug: https://github.com/The-Compiler/qutebrowser/issues/167 Original bug: https://github.com/qutebrowser/qutebrowser/issues/167
Workaround bug: https://github.com/The-Compiler/qutebrowser/issues/171 Workaround bug: https://github.com/qutebrowser/qutebrowser/issues/171
""" """
def _update_geometry(): def _update_geometry():
"""Actually update the geometry if the object still exists.""" """Actually update the geometry if the object still exists."""

2
qutebrowser/browser/history.py
View File

@ -88,7 +88,7 @@ class Entry:
if not url.isValid(): if not url.isValid():
raise ValueError("Invalid URL: {}".format(url.errorString())) raise ValueError("Invalid URL: {}".format(url.errorString()))
# https://github.com/The-Compiler/qutebrowser/issues/670 # https://github.com/qutebrowser/qutebrowser/issues/670
atime = atime.lstrip('\0') atime = atime.lstrip('\0')
if '-' in atime: if '-' in atime:

2
qutebrowser/browser/mouse.py
View File

@ -114,7 +114,7 @@ class MouseEventFilter(QObject):
e: The QWheelEvent. e: The QWheelEvent.
""" """
if self._ignore_wheel_event: if self._ignore_wheel_event:
# See https://github.com/The-Compiler/qutebrowser/issues/395 # See https://github.com/qutebrowser/qutebrowser/issues/395
self._ignore_wheel_event = False self._ignore_wheel_event = False
return True return True

2
qutebrowser/browser/shared.py
View File

@ -158,7 +158,7 @@ def ignore_certificate_errors(url, errors, abort_on):
log.webview.debug("ssl-strict is False, only warning about errors") log.webview.debug("ssl-strict is False, only warning about errors")
for err in errors: for err in errors:
# FIXME we might want to use warn here (non-fatal error) # FIXME we might want to use warn here (non-fatal error)
# https://github.com/The-Compiler/qutebrowser/issues/114 # https://github.com/qutebrowser/qutebrowser/issues/114
message.error('Certificate error: {}'.format(err)) message.error('Certificate error: {}'.format(err))
return True return True
elif ssl_strict is True: elif ssl_strict is True:

4
qutebrowser/browser/webelem.py
View File

@ -161,7 +161,7 @@ class AbstractWebElement(collections.abc.MutableMapping):
Skipping of small rectangles is due to <a> elements containing other Skipping of small rectangles is due to <a> elements containing other
elements with "display:block" style, see elements with "display:block" style, see
https://github.com/The-Compiler/qutebrowser/issues/1298 https://github.com/qutebrowser/qutebrowser/issues/1298
Args: Args:
elem_geometry: The geometry of the element, or None. elem_geometry: The geometry of the element, or None.
@ -312,7 +312,7 @@ class AbstractWebElement(collections.abc.MutableMapping):
# Click the center of the largest square fitting into the top/left # Click the center of the largest square fitting into the top/left
# corner of the rectangle, this will help if part of the <a> element # corner of the rectangle, this will help if part of the <a> element
# is hidden behind other elements # is hidden behind other elements
# https://github.com/The-Compiler/qutebrowser/issues/1005 # https://github.com/qutebrowser/qutebrowser/issues/1005
rect = self.rect_on_view() rect = self.rect_on_view()
if rect.width() > rect.height(): if rect.width() > rect.height():
rect.setWidth(rect.height()) rect.setWidth(rect.height())

2
qutebrowser/browser/webengine/webengineelem.py
View File

@ -110,7 +110,7 @@ class WebEngineElement(webelem.AbstractWebElement):
Skipping of small rectangles is due to <a> elements containing other Skipping of small rectangles is due to <a> elements containing other
elements with "display:block" style, see elements with "display:block" style, see
https://github.com/The-Compiler/qutebrowser/issues/1298 https://github.com/qutebrowser/qutebrowser/issues/1298
Args: Args:
elem_geometry: The geometry of the element, or None. elem_geometry: The geometry of the element, or None.

4
qutebrowser/browser/webkit/mhtml.py
View File

@ -349,8 +349,8 @@ class _Downloader:
# Using the download manager to download host-blocked urls might crash # Using the download manager to download host-blocked urls might crash
# qute, see the comments/discussion on # qute, see the comments/discussion on
# https://github.com/The-Compiler/qutebrowser/pull/962#discussion_r40256987 # https://github.com/qutebrowser/qutebrowser/pull/962#discussion_r40256987
# and https://github.com/The-Compiler/qutebrowser/issues/1053 # and https://github.com/qutebrowser/qutebrowser/issues/1053
host_blocker = objreg.get('host-blocker') host_blocker = objreg.get('host-blocker')
if host_blocker.is_blocked(url): if host_blocker.is_blocked(url):
log.downloads.debug("Skipping {}, host-blocked".format(url)) log.downloads.debug("Skipping {}, host-blocked".format(url))

2
qutebrowser/browser/webkit/network/networkmanager.py
View File

@ -434,7 +434,7 @@ class NetworkManager(QNetworkAccessManager):
tab=self._tab_id) tab=self._tab_id)
current_url = tab.url() current_url = tab.url()
except (KeyError, RuntimeError, TypeError): except (KeyError, RuntimeError, TypeError):
# https://github.com/The-Compiler/qutebrowser/issues/889 # https://github.com/qutebrowser/qutebrowser/issues/889
# Catching RuntimeError and TypeError because we could be in # Catching RuntimeError and TypeError because we could be in
# the middle of the webpage shutdown here. # the middle of the webpage shutdown here.
current_url = QUrl() current_url = QUrl()

2
qutebrowser/browser/webkit/network/webkitqutescheme.py
View File

@ -74,7 +74,7 @@ class JSBridge(QObject):
@pyqtSlot(str, str, str) @pyqtSlot(str, str, str)
def set(self, sectname, optname, value): def set(self, sectname, optname, value):
"""Slot to set a setting from qute:settings.""" """Slot to set a setting from qute:settings."""
# https://github.com/The-Compiler/qutebrowser/issues/727 # https://github.com/qutebrowser/qutebrowser/issues/727
if ((sectname, optname) == ('content', 'allow-javascript') and if ((sectname, optname) == ('content', 'allow-javascript') and
value == 'false'): value == 'false'):
message.error("Refusing to disable javascript via qute:settings " message.error("Refusing to disable javascript via qute:settings "

4
qutebrowser/browser/webkit/rfc6266.py
View File

@ -117,7 +117,7 @@ class Language(str):
"""A language-tag (RFC 5646, Section 2.1). """A language-tag (RFC 5646, Section 2.1).
FIXME: This grammar is not 100% correct yet. FIXME: This grammar is not 100% correct yet.
https://github.com/The-Compiler/qutebrowser/issues/105 https://github.com/qutebrowser/qutebrowser/issues/105
""" """
grammar = re.compile('[A-Za-z0-9-]+') grammar = re.compile('[A-Za-z0-9-]+')
@ -132,7 +132,7 @@ class ValueChars(str):
"""A value of an attribute. """A value of an attribute.
FIXME: Can we merge this with Value? FIXME: Can we merge this with Value?
https://github.com/The-Compiler/qutebrowser/issues/105 https://github.com/qutebrowser/qutebrowser/issues/105
""" """
grammar = re.compile('({}|{})*'.format(attr_char_re, hex_digit_re)) grammar = re.compile('({}|{})*'.format(attr_char_re, hex_digit_re))

4
qutebrowser/browser/webkit/webkitelem.py
View File

@ -162,7 +162,7 @@ class WebKitElement(webelem.AbstractWebElement):
# On e.g. Void Linux with musl libc, the stack size is too small # On e.g. Void Linux with musl libc, the stack size is too small
# for jsc, and running JS will fail. If that happens, fall back to # for jsc, and running JS will fail. If that happens, fall back to
# the Python implementation. # the Python implementation.
# https://github.com/The-Compiler/qutebrowser/issues/1641 # https://github.com/qutebrowser/qutebrowser/issues/1641
return None return None
text = utils.compact_text(self._elem.toOuterXml(), 500) text = utils.compact_text(self._elem.toOuterXml(), 500)
@ -216,7 +216,7 @@ class WebKitElement(webelem.AbstractWebElement):
Skipping of small rectangles is due to <a> elements containing other Skipping of small rectangles is due to <a> elements containing other
elements with "display:block" style, see elements with "display:block" style, see
https://github.com/The-Compiler/qutebrowser/issues/1298 https://github.com/qutebrowser/qutebrowser/issues/1298
Args: Args:
elem_geometry: The geometry of the element, or None. elem_geometry: The geometry of the element, or None.

6
qutebrowser/browser/webkit/webkittab.py
View File

@ -677,7 +677,7 @@ class WebKitTab(browsertab.AbstractTab):
While Qt has a bool "ok" attribute for loadFinished, it always is True While Qt has a bool "ok" attribute for loadFinished, it always is True
when using error pages... See when using error pages... See
https://github.com/The-Compiler/qutebrowser/issues/84 https://github.com/qutebrowser/qutebrowser/issues/84
""" """
self._on_load_finished(not self._widget.page().error_occurred) self._on_load_finished(not self._widget.page().error_occurred)
@ -690,8 +690,8 @@ class WebKitTab(browsertab.AbstractTab):
def _on_frame_created(self, frame): def _on_frame_created(self, frame):
"""Connect the contentsSizeChanged signal of each frame.""" """Connect the contentsSizeChanged signal of each frame."""
# FIXME:qtwebengine those could theoretically regress: # FIXME:qtwebengine those could theoretically regress:
# https://github.com/The-Compiler/qutebrowser/issues/152 # https://github.com/qutebrowser/qutebrowser/issues/152
# https://github.com/The-Compiler/qutebrowser/issues/263 # https://github.com/qutebrowser/qutebrowser/issues/263
frame.contentsSizeChanged.connect(self._on_contents_size_changed) frame.contentsSizeChanged.connect(self._on_contents_size_changed)
@pyqtSlot(QSize) @pyqtSlot(QSize)

2
qutebrowser/browser/webkit/webview.py
View File

@ -59,7 +59,7 @@ class WebView(QWebView):
super().__init__(parent) super().__init__(parent)
if sys.platform == 'darwin' and qtutils.version_check('5.4'): if sys.platform == 'darwin' and qtutils.version_check('5.4'):
# WORKAROUND for https://bugreports.qt.io/browse/QTBUG-42948 # WORKAROUND for https://bugreports.qt.io/browse/QTBUG-42948
# See https://github.com/The-Compiler/qutebrowser/issues/462 # See https://github.com/qutebrowser/qutebrowser/issues/462
self.setStyle(QStyleFactory.create('Fusion')) self.setStyle(QStyleFactory.create('Fusion'))
# FIXME:qtwebengine this is only used to set the zoom factor from # FIXME:qtwebengine this is only used to set the zoom factor from
# the QWebPage - we should get rid of it somehow (signals?) # the QWebPage - we should get rid of it somehow (signals?)

2
qutebrowser/completion/completer.py
View File

@ -239,7 +239,7 @@ class Completer(QObject):
# This is a search or gibberish, so we don't need to complete # This is a search or gibberish, so we don't need to complete
# anything (yet) # anything (yet)
# FIXME complete searches # FIXME complete searches
# https://github.com/The-Compiler/qutebrowser/issues/32 # https://github.com/qutebrowser/qutebrowser/issues/32
completion.set_model(None) completion.set_model(None)
return return

4
qutebrowser/completion/completiondelegate.py
View File

@ -54,7 +54,7 @@ class CompletionItemDelegate(QStyledItemDelegate):
# FIXME this is horribly slow when resizing. # FIXME this is horribly slow when resizing.
# We should probably cache something in _get_textdoc or so, but as soon as # We should probably cache something in _get_textdoc or so, but as soon as
# we implement eliding that cache probably isn't worth much anymore... # we implement eliding that cache probably isn't worth much anymore...
# https://github.com/The-Compiler/qutebrowser/issues/121 # https://github.com/qutebrowser/qutebrowser/issues/121
def __init__(self, parent=None): def __init__(self, parent=None):
self._painter = None self._painter = None
@ -173,7 +173,7 @@ class CompletionItemDelegate(QStyledItemDelegate):
""" """
# FIXME we probably should do eliding here. See # FIXME we probably should do eliding here. See
# qcommonstyle.cpp:viewItemDrawText # qcommonstyle.cpp:viewItemDrawText
# https://github.com/The-Compiler/qutebrowser/issues/118 # https://github.com/qutebrowser/qutebrowser/issues/118
text_option = QTextOption() text_option = QTextOption()
if self._opt.features & QStyleOptionViewItem.WrapText: if self._opt.features & QStyleOptionViewItem.WrapText:
text_option.setWrapMode(QTextOption.WordWrap) text_option.setWrapMode(QTextOption.WordWrap)

2
qutebrowser/completion/completionwidget.py
View File

@ -134,7 +134,7 @@ class CompletionView(QTreeView):
self.setUniformRowHeights(True) self.setUniformRowHeights(True)
self.hide() self.hide()
# FIXME set elidemode # FIXME set elidemode
# https://github.com/The-Compiler/qutebrowser/issues/118 # https://github.com/qutebrowser/qutebrowser/issues/118
def __repr__(self): def __repr__(self):
return utils.get_repr(self) return utils.get_repr(self)

6
qutebrowser/completion/models/configmodel.py
View File

@ -30,7 +30,7 @@ class SettingSectionCompletionModel(base.BaseCompletionModel):
"""A CompletionModel filled with settings sections.""" """A CompletionModel filled with settings sections."""
# https://github.com/The-Compiler/qutebrowser/issues/545 # https://github.com/qutebrowser/qutebrowser/issues/545
# pylint: disable=abstract-method # pylint: disable=abstract-method
COLUMN_WIDTHS = (20, 70, 10) COLUMN_WIDTHS = (20, 70, 10)
@ -52,7 +52,7 @@ class SettingOptionCompletionModel(base.BaseCompletionModel):
_section: The config section this model shows. _section: The config section this model shows.
""" """
# https://github.com/The-Compiler/qutebrowser/issues/545 # https://github.com/qutebrowser/qutebrowser/issues/545
# pylint: disable=abstract-method # pylint: disable=abstract-method
COLUMN_WIDTHS = (20, 70, 10) COLUMN_WIDTHS = (20, 70, 10)
@ -108,7 +108,7 @@ class SettingValueCompletionModel(base.BaseCompletionModel):
_option: The config option this model shows. _option: The config option this model shows.
""" """
# https://github.com/The-Compiler/qutebrowser/issues/545 # https://github.com/qutebrowser/qutebrowser/issues/545
# pylint: disable=abstract-method # pylint: disable=abstract-method
COLUMN_WIDTHS = (20, 70, 10) COLUMN_WIDTHS = (20, 70, 10)

12
qutebrowser/completion/models/miscmodels.py
View File

@ -32,7 +32,7 @@ class CommandCompletionModel(base.BaseCompletionModel):
"""A CompletionModel filled with non-hidden commands and descriptions.""" """A CompletionModel filled with non-hidden commands and descriptions."""
# https://github.com/The-Compiler/qutebrowser/issues/545 # https://github.com/qutebrowser/qutebrowser/issues/545
# pylint: disable=abstract-method # pylint: disable=abstract-method
COLUMN_WIDTHS = (20, 60, 20) COLUMN_WIDTHS = (20, 60, 20)
@ -50,7 +50,7 @@ class HelpCompletionModel(base.BaseCompletionModel):
"""A CompletionModel filled with help topics.""" """A CompletionModel filled with help topics."""
# https://github.com/The-Compiler/qutebrowser/issues/545 # https://github.com/qutebrowser/qutebrowser/issues/545
# pylint: disable=abstract-method # pylint: disable=abstract-method
def __init__(self, parent=None): def __init__(self, parent=None):
@ -87,7 +87,7 @@ class QuickmarkCompletionModel(base.BaseCompletionModel):
"""A CompletionModel filled with all quickmarks.""" """A CompletionModel filled with all quickmarks."""
# https://github.com/The-Compiler/qutebrowser/issues/545 # https://github.com/qutebrowser/qutebrowser/issues/545
# pylint: disable=abstract-method # pylint: disable=abstract-method
def __init__(self, parent=None): def __init__(self, parent=None):
@ -102,7 +102,7 @@ class BookmarkCompletionModel(base.BaseCompletionModel):
"""A CompletionModel filled with all bookmarks.""" """A CompletionModel filled with all bookmarks."""
# https://github.com/The-Compiler/qutebrowser/issues/545 # https://github.com/qutebrowser/qutebrowser/issues/545
# pylint: disable=abstract-method # pylint: disable=abstract-method
def __init__(self, parent=None): def __init__(self, parent=None):
@ -117,7 +117,7 @@ class SessionCompletionModel(base.BaseCompletionModel):
"""A CompletionModel filled with session names.""" """A CompletionModel filled with session names."""
# https://github.com/The-Compiler/qutebrowser/issues/545 # https://github.com/qutebrowser/qutebrowser/issues/545
# pylint: disable=abstract-method # pylint: disable=abstract-method
def __init__(self, parent=None): def __init__(self, parent=None):
@ -249,7 +249,7 @@ class BindCompletionModel(base.BaseCompletionModel):
"""A CompletionModel filled with all bindable commands and descriptions.""" """A CompletionModel filled with all bindable commands and descriptions."""
# https://github.com/The-Compiler/qutebrowser/issues/545 # https://github.com/qutebrowser/qutebrowser/issues/545
# pylint: disable=abstract-method # pylint: disable=abstract-method
COLUMN_WIDTHS = (20, 60, 20) COLUMN_WIDTHS = (20, 60, 20)

2
qutebrowser/config/config.py
View File

@ -233,7 +233,7 @@ def _init_misc():
# doesn't overwrite our config. # doesn't overwrite our config.
# #
# This fixes one of the corruption issues here: # This fixes one of the corruption issues here:
# https://github.com/The-Compiler/qutebrowser/issues/515 # https://github.com/qutebrowser/qutebrowser/issues/515
path = os.path.join(standarddir.config(), 'qsettings') path = os.path.join(standarddir.config(), 'qsettings')
for fmt in [QSettings.NativeFormat, QSettings.IniFormat]: for fmt in [QSettings.NativeFormat, QSettings.IniFormat]:

2
qutebrowser/keyinput/modeman.py
View File

@ -299,7 +299,7 @@ class ModeManager(QObject):
log.modes.debug("Leaving mode {}{}".format( log.modes.debug("Leaving mode {}{}".format(
mode, '' if reason is None else ' (reason: {})'.format(reason))) mode, '' if reason is None else ' (reason: {})'.format(reason)))
# leaving a mode implies clearing keychain, see # leaving a mode implies clearing keychain, see
# https://github.com/The-Compiler/qutebrowser/issues/1805 # https://github.com/qutebrowser/qutebrowser/issues/1805
self.clear_keychain() self.clear_keychain()
self.mode = usertypes.KeyMode.normal self.mode = usertypes.KeyMode.normal
self.left.emit(mode, self.mode, self._win_id) self.left.emit(mode, self.mode, self._win_id)

4
qutebrowser/mainwindow/prompt.py
View File

@ -112,7 +112,7 @@ class PromptQueue(QObject):
if not sip.isdeleted(question): if not sip.isdeleted(question):
# the question could already be deleted, e.g. by a cancelled # the question could already be deleted, e.g. by a cancelled
# download. See # download. See
# https://github.com/The-Compiler/qutebrowser/issues/415 # https://github.com/qutebrowser/qutebrowser/issues/415
self.ask_question(question, blocking=False) self.ask_question(question, blocking=False)
def shutdown(self): def shutdown(self):
@ -153,7 +153,7 @@ class PromptQueue(QObject):
if self._shutting_down: if self._shutting_down:
# If we're currently shutting down we have to ignore this question # If we're currently shutting down we have to ignore this question
# to avoid segfaults - see # to avoid segfaults - see
# https://github.com/The-Compiler/qutebrowser/issues/95 # https://github.com/qutebrowser/qutebrowser/issues/95
log.prompt.debug("Ignoring question because we're shutting down.") log.prompt.debug("Ignoring question because we're shutting down.")
question.abort() question.abort()
return None return None

2
qutebrowser/mainwindow/tabbedbrowser.py
View File

@ -270,7 +270,7 @@ class TabbedBrowser(tabwidget.TabWidget):
# There are some good reasons why a URL could be empty # There are some good reasons why a URL could be empty
# (target="_blank" with a download, see [1]), so we silently ignore # (target="_blank" with a download, see [1]), so we silently ignore
# this. # this.
# [1] https://github.com/The-Compiler/qutebrowser/issues/163 # [1] https://github.com/qutebrowser/qutebrowser/issues/163
pass pass
else: else:
# We display a warnings for URLs which are not empty but invalid - # We display a warnings for URLs which are not empty but invalid -

2
qutebrowser/mainwindow/tabwidget.py
View File

@ -253,7 +253,7 @@ class TabBar(QTabBar):
fixing this would be a lot of effort, so we'll postpone it until we're fixing this would be a lot of effort, so we'll postpone it until we're
reimplementing drag&drop for other reasons. reimplementing drag&drop for other reasons.
https://github.com/The-Compiler/qutebrowser/issues/126 https://github.com/qutebrowser/qutebrowser/issues/126
Attributes: Attributes:
vertical: When the tab bar is currently vertical. vertical: When the tab bar is currently vertical.

2
qutebrowser/misc/earlyinit.py
View File

@ -69,7 +69,7 @@ def _missing_str(name, *, windows=None, pip=None, webengine=False):
'(like Debian/Ubuntu), so you need to start without ' '(like Debian/Ubuntu), so you need to start without '
'--backend webengine there.'), '--backend webengine there.'),
('QtWebEngine is currently unsupported with the OS X .app, see ' ('QtWebEngine is currently unsupported with the OS X .app, see '
'https://github.com/The-Compiler/qutebrowser/issues/1692'), 'https://github.com/qutebrowser/qutebrowser/issues/1692'),
] ]
else: else:
lines = ['<b>If you installed a qutebrowser package for your ' lines = ['<b>If you installed a qutebrowser package for your '

2
qutebrowser/misc/editor.py
View File

@ -107,7 +107,7 @@ class ExternalEditor(QObject):
# Close while the external process is running, as otherwise systems # Close while the external process is running, as otherwise systems
# with exclusive write access (e.g. Windows) may fail to update # with exclusive write access (e.g. Windows) may fail to update
# the file from the external editor, see # the file from the external editor, see
# https://github.com/The-Compiler/qutebrowser/issues/1767 # https://github.com/qutebrowser/qutebrowser/issues/1767
with tempfile.NamedTemporaryFile( with tempfile.NamedTemporaryFile(
mode='w', prefix='qutebrowser-editor-', encoding=encoding, mode='w', prefix='qutebrowser-editor-', encoding=encoding,
delete=False) as fobj: delete=False) as fobj:

2
qutebrowser/misc/ipc.py
View File

@ -222,7 +222,7 @@ class IPCServer(QObject):
try: try:
os.chmod(self._server.fullServerName(), 0o700) os.chmod(self._server.fullServerName(), 0o700)
except FileNotFoundError: except FileNotFoundError:
# https://github.com/The-Compiler/qutebrowser/issues/1530 # https://github.com/qutebrowser/qutebrowser/issues/1530
# The server doesn't actually exist even if ok was reported as # The server doesn't actually exist even if ok was reported as
# True, so report this as an error. # True, so report this as an error.
raise ListenError(self._server) raise ListenError(self._server)

6
qutebrowser/misc/sessions.py
View File

@ -167,7 +167,7 @@ class SessionManager(QObject):
if item.title(): if item.title():
data['title'] = item.title() data['title'] = item.title()
else: else:
# https://github.com/The-Compiler/qutebrowser/issues/879 # https://github.com/qutebrowser/qutebrowser/issues/879
if tab.history.current_idx() == idx: if tab.history.current_idx() == idx:
data['title'] = tab.title() data['title'] = tab.title()
else: else:
@ -306,7 +306,7 @@ class SessionManager(QObject):
if 'zoom' in data: if 'zoom' in data:
# The zoom was accidentally stored in 'data' instead of per-tab # The zoom was accidentally stored in 'data' instead of per-tab
# earlier. # earlier.
# See https://github.com/The-Compiler/qutebrowser/issues/728 # See https://github.com/qutebrowser/qutebrowser/issues/728
user_data['zoom'] = data['zoom'] user_data['zoom'] = data['zoom']
elif 'zoom' in histentry: elif 'zoom' in histentry:
user_data['zoom'] = histentry['zoom'] user_data['zoom'] = histentry['zoom']
@ -314,7 +314,7 @@ class SessionManager(QObject):
if 'scroll-pos' in data: if 'scroll-pos' in data:
# The scroll position was accidentally stored in 'data' instead # The scroll position was accidentally stored in 'data' instead
# of per-tab earlier. # of per-tab earlier.
# See https://github.com/The-Compiler/qutebrowser/issues/728 # See https://github.com/qutebrowser/qutebrowser/issues/728
pos = data['scroll-pos'] pos = data['scroll-pos']
user_data['scroll-pos'] = QPoint(pos['x'], pos['y']) user_data['scroll-pos'] = QPoint(pos['x'], pos['y'])
elif 'scroll-pos' in histentry: elif 'scroll-pos' in histentry:

2
qutebrowser/utils/debug.py
View File

@ -137,7 +137,7 @@ def qflags_key(base, value, add_base=False, klass=None):
Note: Passing a combined value (such as Qt.AlignCenter) will get the names Note: Passing a combined value (such as Qt.AlignCenter) will get the names
for the individual bits (e.g. Qt.AlignVCenter | Qt.AlignHCenter). FIXME for the individual bits (e.g. Qt.AlignVCenter | Qt.AlignHCenter). FIXME
https://github.com/The-Compiler/qutebrowser/issues/42 https://github.com/qutebrowser/qutebrowser/issues/42
Args: Args:
base: The object the flags are in, e.g. QtCore.Qt base: The object the flags are in, e.g. QtCore.Qt

6
qutebrowser/utils/log.py
View File

@ -406,9 +406,9 @@ def qt_message_handler(msg_type, context, msg):
# When enabling debugging with QtWebEngine # When enabling debugging with QtWebEngine
"Remote debugging server started successfully. Try pointing a " "Remote debugging server started successfully. Try pointing a "
"Chromium-based browser to ", "Chromium-based browser to ",
# https://github.com/The-Compiler/qutebrowser/issues/1287 # https://github.com/qutebrowser/qutebrowser/issues/1287
"QXcbClipboard: SelectionRequest too old", "QXcbClipboard: SelectionRequest too old",
# https://github.com/The-Compiler/qutebrowser/issues/2071 # https://github.com/qutebrowser/qutebrowser/issues/2071
'QXcbWindow: Unhandled client message: ""', 'QXcbWindow: Unhandled client message: ""',
# https://codereview.qt-project.org/176831 # https://codereview.qt-project.org/176831
"QObject::disconnect: Unexpected null parameter", "QObject::disconnect: Unexpected null parameter",
@ -551,7 +551,7 @@ class RAMHandler(logging.Handler):
FIXME: We should do all the HTML formatter via jinja2. FIXME: We should do all the HTML formatter via jinja2.
(probably obsolete when moving to a widget for logging, (probably obsolete when moving to a widget for logging,
https://github.com/The-Compiler/qutebrowser/issues/34 https://github.com/qutebrowser/qutebrowser/issues/34
""" """
minlevel = LOG_LEVELS.get(level.upper(), VDEBUG_LEVEL) minlevel = LOG_LEVELS.get(level.upper(), VDEBUG_LEVEL)
lines = [] lines = []

2
qutebrowser/utils/objreg.py
View File

@ -111,7 +111,7 @@ class ObjectRegistry(collections.UserDict):
# #
# With older PyQt-versions (5.2.1) we'll get a "TypeError: # With older PyQt-versions (5.2.1) we'll get a "TypeError:
# pyqtSignal must be bound to a QObject" instead: # pyqtSignal must be bound to a QObject" instead:
# https://github.com/The-Compiler/qutebrowser/issues/257 # https://github.com/qutebrowser/qutebrowser/issues/257
pass pass
del partial_objs[name] del partial_objs[name]

4
qutebrowser/utils/urlutils.py
View File

@ -36,7 +36,7 @@ from qutebrowser.browser.network import pac
# FIXME: we probably could raise some exceptions on invalid URLs # FIXME: we probably could raise some exceptions on invalid URLs
# https://github.com/The-Compiler/qutebrowser/issues/108 # https://github.com/qutebrowser/qutebrowser/issues/108
class InvalidUrlError(ValueError): class InvalidUrlError(ValueError):
@ -297,7 +297,7 @@ def qurl_from_user_input(urlstr):
WORKAROUND - https://bugreports.qt.io/browse/QTBUG-41089 WORKAROUND - https://bugreports.qt.io/browse/QTBUG-41089
FIXME - Maybe https://codereview.qt-project.org/#/c/93851/ has a better way FIXME - Maybe https://codereview.qt-project.org/#/c/93851/ has a better way
to solve this? to solve this?
https://github.com/The-Compiler/qutebrowser/issues/109 https://github.com/qutebrowser/qutebrowser/issues/109
Args: Args:
urlstr: The URL as string. urlstr: The URL as string.

2
qutebrowser/utils/utils.py
View File

@ -400,7 +400,7 @@ def keyevent_to_string(e):
if sys.platform == 'darwin': if sys.platform == 'darwin':
# Qt swaps Ctrl/Meta on OS X, so we switch it back here so the user can # Qt swaps Ctrl/Meta on OS X, so we switch it back here so the user can
# use it in the config as expected. See: # use it in the config as expected. See:
# https://github.com/The-Compiler/qutebrowser/issues/110 # https://github.com/qutebrowser/qutebrowser/issues/110
# http://doc.qt.io/qt-5.4/osx-issues.html#special-keys # http://doc.qt.io/qt-5.4/osx-issues.html#special-keys
modmask2str = collections.OrderedDict([ modmask2str = collections.OrderedDict([
(Qt.MetaModifier, 'Ctrl'), (Qt.MetaModifier, 'Ctrl'),

2
scripts/dev/download_release.sh
View File

@ -14,7 +14,7 @@ fi
cd "$tmpdir" cd "$tmpdir"
mkdir windows mkdir windows
base="https://github.com/The-Compiler/qutebrowser/releases/download/v$1" base="https://github.com/qutebrowser/qutebrowser/releases/download/v$1"
wget "$base/qutebrowser-$1.tar.gz" || exit 1 wget "$base/qutebrowser-$1.tar.gz" || exit 1
wget "$base/qutebrowser-$1.tar.gz.asc" || exit 1 wget "$base/qutebrowser-$1.tar.gz.asc" || exit 1

2
tests/conftest.py
View File

@ -133,7 +133,7 @@ def pytest_collection_modifyitems(config, items):
if item.get_marker('issue2183'): if item.get_marker('issue2183'):
item.add_marker(pytest.mark.xfail( item.add_marker(pytest.mark.xfail(
config.webengine and qtutils.version_check('5.7.1'), config.webengine and qtutils.version_check('5.7.1'),
reason='https://github.com/The-Compiler/qutebrowser/issues/' reason='https://github.com/qutebrowser/qutebrowser/issues/'
'2183')) '2183'))
if deselected: if deselected:

2
tests/end2end/data/downloads/issue1535.html
View File

@ -4,7 +4,7 @@
</head> </head>
<body> <body>
<p>Cancelling a download that belongs to an mhtml download.</p> <p>Cancelling a download that belongs to an mhtml download.</p>
<p>See also <a href="https://github.com/The-Compiler/qutebrowser/issues/1535">GitHub</a></p> <p>See also <a href="https://github.com/qutebrowser/qutebrowser/issues/1535">GitHub</a></p>
<!-- <!--
Use drip so we have a chance to cancel the download before Use drip so we have a chance to cancel the download before
it finishes it finishes

2
tests/end2end/data/downloads/mhtml/complex/complex.html
View File

@ -80,7 +80,7 @@
<h2>...and how?</h2> <h2>...and how?</h2>
<p>See <a href="https://github.com/The-Compiler/qutebrowser/blob/master/CONTRIBUTING.asciidoc"> <p>See <a href="https://github.com/qutebrowser/qutebrowser/blob/master/CONTRIBUTING.asciidoc">
here</a> for more information.</p> here</a> for more information.</p>
<h2>More useless trivia!</h2> <h2>More useless trivia!</h2>

2
tests/end2end/data/downloads/mhtml/complex/complex.mht
View File

@ -96,7 +96,7 @@ the
=20 =20
<h2>...and how?</h2> <h2>...and how?</h2>
=20 =20
<p>See <a href=3D"https://github.com/The-Compiler/qutebrowser/blob/= <p>See <a href=3D"https://github.com/qutebrowser/qutebrowser/blob/=
master/CONTRIBUTING.asciidoc"> master/CONTRIBUTING.asciidoc">
here</a> for more information.</p> here</a> for more information.</p>
=20 =20

10
tests/end2end/features/downloads.feature
View File

@ -100,7 +100,7 @@ Feature: Downloading things from a website.
And I run :close And I run :close
Then qutebrowser should quit Then qutebrowser should quit
# https://github.com/The-Compiler/qutebrowser/issues/2134 # https://github.com/qutebrowser/qutebrowser/issues/2134
@qtwebengine_skip @qtwebengine_skip
Scenario: Downloading, then closing a tab Scenario: Downloading, then closing a tab
When I set storage -> prompt-download-directory to false When I set storage -> prompt-download-directory to false
@ -270,7 +270,7 @@ Feature: Downloading things from a website.
Then "cancelled" should be logged Then "cancelled" should be logged
And "cancelled" should be logged And "cancelled" should be logged
# https://github.com/The-Compiler/qutebrowser/issues/1535 # https://github.com/qutebrowser/qutebrowser/issues/1535
@qtwebengine_todo: :download --mhtml is not implemented yet @qtwebengine_todo: :download --mhtml is not implemented yet
Scenario: Cancelling an MHTML download (issue 1535) Scenario: Cancelling an MHTML download (issue 1535)
When I open data/downloads/issue1535.html When I open data/downloads/issue1535.html
@ -392,7 +392,7 @@ Feature: Downloading things from a website.
And I wait until the download is finished And I wait until the download is finished
Then "Opening *download.bin* with [*python*]" should be logged Then "Opening *download.bin* with [*python*]" should be logged
# https://github.com/The-Compiler/qutebrowser/issues/1728 # https://github.com/qutebrowser/qutebrowser/issues/1728
Scenario: Cancelling a download that should be opened Scenario: Cancelling a download that should be opened
When I set storage -> prompt-download-directory to true When I set storage -> prompt-download-directory to true
@ -402,7 +402,7 @@ Feature: Downloading things from a website.
And I run :download-cancel And I run :download-cancel
Then "* finished but not successful, not opening!" should be logged Then "* finished but not successful, not opening!" should be logged
# https://github.com/The-Compiler/qutebrowser/issues/1725 # https://github.com/qutebrowser/qutebrowser/issues/1725
Scenario: Directly open a download with a very long filename Scenario: Directly open a download with a very long filename
When I set storage -> prompt-download-directory to true When I set storage -> prompt-download-directory to true
@ -455,7 +455,7 @@ Feature: Downloading things from a website.
And I open data/downloads/download2.bin without waiting And I open data/downloads/download2.bin without waiting
Then the download prompt should be shown with "(tmpdir)/downloads/download2.bin" Then the download prompt should be shown with "(tmpdir)/downloads/download2.bin"
# https://github.com/The-Compiler/qutebrowser/issues/2173 # https://github.com/qutebrowser/qutebrowser/issues/2173
Scenario: Remembering the temporary download directory (issue 2173) Scenario: Remembering the temporary download directory (issue 2173)
When I set storage -> prompt-download-directory to true When I set storage -> prompt-download-directory to true

16
tests/end2end/features/hints.feature
View File

@ -159,7 +159,7 @@ Feature: Using hints
# The actual check is already done above # The actual check is already done above
Then no crash should happen Then no crash should happen
# https://github.com/The-Compiler/qutebrowser/issues/1613 # https://github.com/qutebrowser/qutebrowser/issues/1613
Scenario: Hinting inputs with padding Scenario: Hinting inputs with padding
When I open data/hints/input.html When I open data/hints/input.html
And I hint with args "inputs" and follow s And I hint with args "inputs" and follow s
@ -184,7 +184,7 @@ Feature: Using hints
And I hint with args "links normal" and follow a And I hint with args "links normal" and follow a
Then "navigation request: url http://localhost:*/data/hello.txt, type NavigationTypeLinkClicked, *" should be logged Then "navigation request: url http://localhost:*/data/hello.txt, type NavigationTypeLinkClicked, *" should be logged
### FIXME currenly skipped, see https://github.com/The-Compiler/qutebrowser/issues/1525 ### FIXME currenly skipped, see https://github.com/qutebrowser/qutebrowser/issues/1525
@xfail_norun @xfail_norun
Scenario: Using :follow-hint inside a scrolled iframe Scenario: Using :follow-hint inside a scrolled iframe
When I open data/hints/iframe_scroll.html When I open data/hints/iframe_scroll.html
@ -262,7 +262,7 @@ Feature: Using hints
### Number hint mode ### Number hint mode
# https://github.com/The-Compiler/qutebrowser/issues/308 # https://github.com/qutebrowser/qutebrowser/issues/308
Scenario: Renumbering hints when filtering Scenario: Renumbering hints when filtering
When I open data/hints/number.html When I open data/hints/number.html
And I set hints -> mode to number And I set hints -> mode to number
@ -271,7 +271,7 @@ Feature: Using hints
And I run :follow-hint 1 And I run :follow-hint 1
Then data/numbers/7.txt should be loaded Then data/numbers/7.txt should be loaded
# https://github.com/The-Compiler/qutebrowser/issues/576 # https://github.com/qutebrowser/qutebrowser/issues/576
@qtwebengine_flaky @qtwebengine_flaky
Scenario: Keeping hint filter in rapid mode Scenario: Keeping hint filter in rapid mode
When I open data/hints/number.html When I open data/hints/number.html
@ -283,7 +283,7 @@ Feature: Using hints
Then data/numbers/2.txt should be loaded Then data/numbers/2.txt should be loaded
And data/numbers/3.txt should be loaded And data/numbers/3.txt should be loaded
# https://github.com/The-Compiler/qutebrowser/issues/1186 # https://github.com/qutebrowser/qutebrowser/issues/1186
Scenario: Keeping hints filter when using backspace Scenario: Keeping hints filter when using backspace
When I open data/hints/issue1186.html When I open data/hints/issue1186.html
And I set hints -> mode to number And I set hints -> mode to number
@ -294,7 +294,7 @@ Feature: Using hints
And I run :follow-hint 11 And I run :follow-hint 11
Then the error "No hint 11!" should be shown Then the error "No hint 11!" should be shown
# https://github.com/The-Compiler/qutebrowser/issues/674#issuecomment-165096744 # https://github.com/qutebrowser/qutebrowser/issues/674#issuecomment-165096744
Scenario: Multi-word matching Scenario: Multi-word matching
When I open data/hints/number.html When I open data/hints/number.html
And I set hints -> mode to number And I set hints -> mode to number
@ -311,7 +311,7 @@ Feature: Using hints
And I hint with args "all" and follow 00 And I hint with args "all" and follow 00
Then data/numbers/1.txt should be loaded Then data/numbers/1.txt should be loaded
# https://github.com/The-Compiler/qutebrowser/issues/1559 # https://github.com/qutebrowser/qutebrowser/issues/1559
Scenario: Filtering all hints in number mode Scenario: Filtering all hints in number mode
When I open data/hints/number.html When I open data/hints/number.html
And I set hints -> mode to number And I set hints -> mode to number
@ -320,7 +320,7 @@ Feature: Using hints
And I wait for "Leaving mode KeyMode.hint (reason: all filtered)" in the log And I wait for "Leaving mode KeyMode.hint (reason: all filtered)" in the log
Then no crash should happen Then no crash should happen
# https://github.com/The-Compiler/qutebrowser/issues/1657 # https://github.com/qutebrowser/qutebrowser/issues/1657
Scenario: Using rapid number hinting twice Scenario: Using rapid number hinting twice
When I open data/hints/number.html When I open data/hints/number.html
And I set hints -> mode to number And I set hints -> mode to number

2
tests/end2end/features/javascript.feature
View File

@ -27,7 +27,7 @@ Feature: Javascript stuff
# WebModalDialog with QtWebKit, WebDialog with QtWebEngine # WebModalDialog with QtWebKit, WebDialog with QtWebEngine
And "Web*Dialog requested, but we don't support that!" should be logged And "Web*Dialog requested, but we don't support that!" should be logged
# https://github.com/The-Compiler/qutebrowser/issues/906 # https://github.com/qutebrowser/qutebrowser/issues/906
@qtwebengine_skip @qtwebengine_skip
Scenario: Closing a JS window twice (issue 906) - qtwebkit Scenario: Closing a JS window twice (issue 906) - qtwebkit

10
tests/end2end/features/misc.feature
View File

@ -381,7 +381,7 @@ Feature: Various utility commands.
When I run :debug-pyeval --quiet 1+1 When I run :debug-pyeval --quiet 1+1
Then "pyeval output: 2" should be logged Then "pyeval output: 2" should be logged
## https://github.com/The-Compiler/qutebrowser/issues/504 ## https://github.com/qutebrowser/qutebrowser/issues/504
Scenario: Focusing download widget via Tab Scenario: Focusing download widget via Tab
When I open about:blank When I open about:blank
@ -490,13 +490,13 @@ Feature: Various utility commands.
Then qute://log?level=error should be loaded Then qute://log?level=error should be loaded
And the page should contain the plaintext "No messages to show." And the page should contain the plaintext "No messages to show."
## https://github.com/The-Compiler/qutebrowser/issues/1523 ## https://github.com/qutebrowser/qutebrowser/issues/1523
Scenario: Completing a single option argument Scenario: Completing a single option argument
When I run :set-cmd-text -s :-- When I run :set-cmd-text -s :--
Then no crash should happen Then no crash should happen
## https://github.com/The-Compiler/qutebrowser/issues/1386 ## https://github.com/qutebrowser/qutebrowser/issues/1386
Scenario: Partial commandline matching with startup command Scenario: Partial commandline matching with startup command
When I run :message-i "Hello World" (invalid command) When I run :message-i "Hello World" (invalid command)
@ -510,7 +510,7 @@ Feature: Various utility commands.
And I run :command-accept And I run :command-accept
Then the message "Hello World" should be shown Then the message "Hello World" should be shown
## https://github.com/The-Compiler/qutebrowser/issues/1219 ## https://github.com/qutebrowser/qutebrowser/issues/1219
@qtwebengine_todo: private browsing is not implemented yet @qtwebengine_todo: private browsing is not implemented yet
Scenario: Sharing cookies with private browsing Scenario: Sharing cookies with private browsing
@ -521,7 +521,7 @@ Feature: Various utility commands.
And I set general -> private-browsing to false And I set general -> private-browsing to false
Then the cookie qute-test should be set to 42 Then the cookie qute-test should be set to 42
## https://github.com/The-Compiler/qutebrowser/issues/1742 ## https://github.com/qutebrowser/qutebrowser/issues/1742
@qtwebengine_todo: private browsing is not implemented yet @qtwebengine_todo: private browsing is not implemented yet
Scenario: Private browsing is activated in QtWebKit without restart Scenario: Private browsing is activated in QtWebKit without restart

8
tests/end2end/features/prompts.feature
View File

@ -353,7 +353,7 @@ Feature: Prompts
"user": "user4" "user": "user4"
} }
# https://github.com/The-Compiler/qutebrowser/issues/2156 # https://github.com/qutebrowser/qutebrowser/issues/2156
@qtwebkit_skip @qtwebkit_skip
Scenario: Cancellling webpage authentification with QtWebEngine Scenario: Cancellling webpage authentification with QtWebEngine
When I open basic-auth/user5/password5 without waiting When I open basic-auth/user5/password5 without waiting
@ -460,7 +460,7 @@ Feature: Prompts
And I run :prompt-accept prompt-in-command-mode And I run :prompt-accept prompt-in-command-mode
Then "Added quickmark prompt-in-command-mode for *" should be logged Then "Added quickmark prompt-in-command-mode for *" should be logged
# https://github.com/The-Compiler/qutebrowser/issues/1093 # https://github.com/qutebrowser/qutebrowser/issues/1093
@qtwebengine_skip: QtWebEngine doesn't open the second page/prompt @qtwebengine_skip: QtWebEngine doesn't open the second page/prompt
Scenario: Keyboard focus with multiple auth prompts Scenario: Keyboard focus with multiple auth prompts
When I open basic-auth/user5/password5 without waiting When I open basic-auth/user5/password5 without waiting
@ -486,8 +486,8 @@ Feature: Prompts
"user": "user6" "user": "user6"
} }
# https://github.com/The-Compiler/qutebrowser/issues/1249#issuecomment-175205531 # https://github.com/qutebrowser/qutebrowser/issues/1249#issuecomment-175205531
# https://github.com/The-Compiler/qutebrowser/pull/2054#issuecomment-258285544 # https://github.com/qutebrowser/qutebrowser/pull/2054#issuecomment-258285544
@qtwebengine_todo: Notifications are not implemented in QtWebEngine @qtwebengine_todo: Notifications are not implemented in QtWebEngine
Scenario: Interrupting SSL prompt during a notification prompt Scenario: Interrupting SSL prompt during a notification prompt
When I set content -> notifications to ask When I set content -> notifications to ask

2
tests/end2end/features/scroll.feature
View File

@ -231,7 +231,7 @@ Feature: Scrolling
When I run :scroll-perc 0 with count 50 When I run :scroll-perc 0 with count 50
Then the page should be scrolled vertically Then the page should be scrolled vertically
# https://github.com/The-Compiler/qutebrowser/issues/1821 # https://github.com/qutebrowser/qutebrowser/issues/1821
Scenario: :scroll-perc without doctype Scenario: :scroll-perc without doctype
When I open data/scroll/no_doctype.html When I open data/scroll/no_doctype.html
And I run :scroll-perc 100 And I run :scroll-perc 100

2
tests/end2end/features/sessions.feature
View File

@ -194,7 +194,7 @@ Feature: Saving and loading sessions
url: http://localhost:*/data/numbers/3.txt url: http://localhost:*/data/numbers/3.txt
zoom: 1.0 zoom: 1.0
# https://github.com/The-Compiler/qutebrowser/issues/879 # https://github.com/qutebrowser/qutebrowser/issues/879
Scenario: Saving a session with a page using history.replaceState() Scenario: Saving a session with a page using history.replaceState()
When I open data/sessions/history_replace_state.html without waiting When I open data/sessions/history_replace_state.html without waiting

2
tests/end2end/features/spawn.feature
View File

@ -16,7 +16,7 @@ Feature: :spawn
When I run :spawn -u /this_does_not_exist When I run :spawn -u /this_does_not_exist
Then the error "Userscript '/this_does_not_exist' not found" should be shown Then the error "Userscript '/this_does_not_exist' not found" should be shown
# https://github.com/The-Compiler/qutebrowser/issues/1614 # https://github.com/qutebrowser/qutebrowser/issues/1614
@posix @posix
Scenario: Running :spawn with invalid quoting Scenario: Running :spawn with invalid quoting
When I run :spawn ""'"" When I run :spawn ""'""

8
tests/end2end/features/zoom.feature
View File

@ -20,19 +20,19 @@ Feature: Zooming in and out
Then the message "Zoom level: 120%" should be shown Then the message "Zoom level: 120%" should be shown
And the zoom should be 120% And the zoom should be 120%
# https://github.com/The-Compiler/qutebrowser/issues/1118 # https://github.com/qutebrowser/qutebrowser/issues/1118
Scenario: Zooming in with very big count Scenario: Zooming in with very big count
When I run :zoom-in with count 99999999999 When I run :zoom-in with count 99999999999
Then the message "Zoom level: 120%" should be shown Then the message "Zoom level: 120%" should be shown
And the zoom should be 120% And the zoom should be 120%
# https://github.com/The-Compiler/qutebrowser/issues/1118 # https://github.com/qutebrowser/qutebrowser/issues/1118
Scenario: Zooming out with very big count Scenario: Zooming out with very big count
When I run :zoom-out with count 99999999999 When I run :zoom-out with count 99999999999
Then the message "Zoom level: 50%" should be shown Then the message "Zoom level: 50%" should be shown
And the zoom should be 50% And the zoom should be 50%
# https://github.com/The-Compiler/qutebrowser/issues/1118 # https://github.com/qutebrowser/qutebrowser/issues/1118
Scenario: Zooming in with very big count and snapping in Scenario: Zooming in with very big count and snapping in
When I run :zoom-in with count 99999999999 When I run :zoom-in with count 99999999999
And I run :zoom-out And I run :zoom-out
@ -86,7 +86,7 @@ Feature: Zooming in and out
Then the message "Zoom level: 120%" should be shown Then the message "Zoom level: 120%" should be shown
And the zoom should be 120% And the zoom should be 120%
# https://github.com/The-Compiler/qutebrowser/issues/2183 # https://github.com/qutebrowser/qutebrowser/issues/2183
@qtwebengine_flaky @qtwebengine_flaky
Scenario: Setting a default zoom Scenario: Setting a default zoom
When I set ui -> default-zoom to 200% When I set ui -> default-zoom to 200%

8
tests/end2end/test_invocations.py
View File

@ -72,8 +72,8 @@ def temp_basedir_env(tmpdir, short_tmpdir):
def test_ascii_locale(request, httpbin, tmpdir, quteproc_new): def test_ascii_locale(request, httpbin, tmpdir, quteproc_new):
"""Test downloads with LC_ALL=C set. """Test downloads with LC_ALL=C set.
https://github.com/The-Compiler/qutebrowser/issues/908 https://github.com/qutebrowser/qutebrowser/issues/908
https://github.com/The-Compiler/qutebrowser/issues/1726 https://github.com/qutebrowser/qutebrowser/issues/1726
""" """
if request.config.webengine: if request.config.webengine:
pytest.skip("Downloads are not implemented with QtWebEngine yet") pytest.skip("Downloads are not implemented with QtWebEngine yet")
@ -108,8 +108,8 @@ def test_misconfigured_user_dirs(request, httpbin, temp_basedir_env,
tmpdir, quteproc_new): tmpdir, quteproc_new):
"""Test downloads with a misconfigured XDG_DOWNLOAD_DIR. """Test downloads with a misconfigured XDG_DOWNLOAD_DIR.
https://github.com/The-Compiler/qutebrowser/issues/866 https://github.com/qutebrowser/qutebrowser/issues/866
https://github.com/The-Compiler/qutebrowser/issues/1269 https://github.com/qutebrowser/qutebrowser/issues/1269
""" """
if request.config.webengine: if request.config.webengine:
pytest.skip("Downloads are not implemented with QtWebEngine yet") pytest.skip("Downloads are not implemented with QtWebEngine yet")

2
tests/manual/hints/hide_unmatched_rapid_hints.html
View File

@ -5,7 +5,7 @@
<title>Hide unmatched rapid hints</title> <title>Hide unmatched rapid hints</title>
</head> </head>
<body> <body>
<p>When <code>hints -> hide-unmatched-rapid-hints</code> is set to true (default), rapid hints behave like normal hints, i.e. unmatched hints will be hidden as you type. Setting the option to false will disable hiding in rapid mode, which is sometimes useful (see <a href="https://github.com/The-Compiler/qutebrowser/issues/1799">#1799</a>).</p> <p>When <code>hints -> hide-unmatched-rapid-hints</code> is set to true (default), rapid hints behave like normal hints, i.e. unmatched hints will be hidden as you type. Setting the option to false will disable hiding in rapid mode, which is sometimes useful (see <a href="https://github.com/qutebrowser/qutebrowser/issues/1799">#1799</a>).</p>
<p>Note that when hinting in number mode, the <code>hints -> hide-unmatched-rapid-hints</code> option affects typing the hint string (number), but not the filter (letters).</p> <p>Note that when hinting in number mode, the <code>hints -> hide-unmatched-rapid-hints</code> option affects typing the hint string (number), but not the filter (letters).</p>
<p>Here is couple of invalid links to test the behaviour:</p> <p>Here is couple of invalid links to test the behaviour:</p>
<p><a href="#foo">one</a></p> <p><a href="#foo">one</a></p>

4
tests/manual/hints/issue824.html
View File

@ -7,7 +7,7 @@
<body style="left: 100px; position: absolute;"> <body style="left: 100px; position: absolute;">
<p>When using hints (f) on this page, the hint should be drawn over the <p>When using hints (f) on this page, the hint should be drawn over the
link.</p> link.</p>
<p>See <a href="https://github.com/The-Compiler/qutebrowser/issues/824">#824</a>.</p> <p>See <a href="https://github.com/qutebrowser/qutebrowser/issues/824">#824</a>.</p>
<p>This was fixed by <a href="https://github.com/The-Compiler/qutebrowser/pull/1433">#1433</a>.</p> <p>This was fixed by <a href="https://github.com/qutebrowser/qutebrowser/pull/1433">#1433</a>.</p>
</body> </body>
</html> </html>

2
tests/manual/hints/issue925.html
View File

@ -13,7 +13,7 @@
<p> <p>
When using hints (f) on this page, the hint should have a normal size. When using hints (f) on this page, the hint should have a normal size.
</p> </p>
See <a href="https://github.com/The-Compiler/qutebrowser/issues/925">#925</a>. See <a href="https://github.com/qutebrowser/qutebrowser/issues/925">#925</a>.
</p> </p>
</body> </body>
</html> </html>

10
tests/manual/hints/other.html
View File

@ -8,11 +8,11 @@
<p>Hint issues without minimal reproducers yet:</p> <p>Hint issues without minimal reproducers yet:</p>
<ul> <ul>
<li> <li>
Links should be correctly positioned on <a href="http://www.metafilter.com/">metafilter.com</a> - see <a href="https://github.com/The-Compiler/qutebrowser/issues/824#issuecomment-128231540">#824 (comment)</a>.<br/> Links should be correctly positioned on <a href="http://www.metafilter.com/">metafilter.com</a> - see <a href="https://github.com/qutebrowser/qutebrowser/issues/824#issuecomment-128231540">#824 (comment)</a>.<br/>
Current state: <span style="color: green;">good</span> Current state: <span style="color: green;">good</span>
</li> </li>
<li> <li>
Links should be correctly positioned on <a href="http://www.xkcd.org/">xkcd.org</a> - see <a href="https://github.com/The-Compiler/qutebrowser/issues/824">#824</a>.<br/> Links should be correctly positioned on <a href="http://www.xkcd.org/">xkcd.org</a> - see <a href="https://github.com/qutebrowser/qutebrowser/issues/824">#824</a>.<br/>
Current state: <span style="color: green">good</span> - fixed in <a href="https://github.com/the-compiler/qutebrowser/pull/1433">#1433</a> Current state: <span style="color: green">good</span> - fixed in <a href="https://github.com/the-compiler/qutebrowser/pull/1433">#1433</a>
</li> </li>
<li> <li>
@ -20,15 +20,15 @@
current state: <span style="color: red;">bad</span> current state: <span style="color: red;">bad</span>
</li> </li>
<li> <li>
links should be correctly positioned on this <a href="https://www.ctl.io/developers/blog/post/optimizing-docker-images/">ctl.io page</a> - see <a href="https://github.com/The-Compiler/qutebrowser/issues/824#issuecomment-208859886">#824 (comment)</a>.<br/> links should be correctly positioned on this <a href="https://www.ctl.io/developers/blog/post/optimizing-docker-images/">ctl.io page</a> - see <a href="https://github.com/qutebrowser/qutebrowser/issues/824#issuecomment-208859886">#824 (comment)</a>.<br/>
Current state: <span style="color: green;">good</span> - fixed in <a href="https://github.com/the-compiler/qutebrowser/pull/1433">#1433</a> Current state: <span style="color: green;">good</span> - fixed in <a href="https://github.com/the-compiler/qutebrowser/pull/1433">#1433</a>
</li> </li>
<li> <li>
When clicking titles under the images on <a href="https://www.etsy.com/search?q=test">etsy</a>, the correct item should be selected (sometimes the one on the right is selected instead) - see <a href="https://github.com/The-Compiler/qutebrowser/issues/1005">#1005</a>.<br/> When clicking titles under the images on <a href="https://www.etsy.com/search?q=test">etsy</a>, the correct item should be selected (sometimes the one on the right is selected instead) - see <a href="https://github.com/qutebrowser/qutebrowser/issues/1005">#1005</a>.<br/>
Current state: <span style="color: green;">good</span> - fixed in <a href="https://github.com/the-compiler/qutebrowser/pull/1433">#1433</a> Current state: <span style="color: green;">good</span> - fixed in <a href="https://github.com/the-compiler/qutebrowser/pull/1433">#1433</a>
</li> </li>
<li> <li>
When clicking titles on <a href="http://geizhals.de/?o=9">Geizhals</a>, the correct item should be selected (one of the sub-titles is selected instead) - see <a href="https://github.com/The-Compiler/qutebrowser/issues/1514">#1514</a>.<br/> When clicking titles on <a href="http://geizhals.de/?o=9">Geizhals</a>, the correct item should be selected (one of the sub-titles is selected instead) - see <a href="https://github.com/qutebrowser/qutebrowser/issues/1514">#1514</a>.<br/>
Current state: <span style="color: green;">good</span> - fixed in <a href="https://github.com/the-compiler/qutebrowser/pull/1433">#1433</a> Current state: <span style="color: green;">good</span> - fixed in <a href="https://github.com/the-compiler/qutebrowser/pull/1433">#1433</a>
</li> </li>
</ul> </ul>

2
tests/test_conftest.py
View File

@ -44,7 +44,7 @@ def test_fail_on_warnings():
warnings.warn('test', PendingDeprecationWarning) warnings.warn('test', PendingDeprecationWarning)
@pytest.mark.xfail(reason="https://github.com/The-Compiler/qutebrowser/issues/1070", @pytest.mark.xfail(reason="https://github.com/qutebrowser/qutebrowser/issues/1070",
strict=False) strict=False)
def test_installed_package(): def test_installed_package():
"""Make sure the tests are running against the installed package.""" """Make sure the tests are running against the installed package."""

2
tests/unit/browser/webkit/network/test_pac.py
View File

@ -162,7 +162,7 @@ def test_fail_return():
res.resolve(QNetworkProxyQuery(QUrl("https://example.com/test"))) res.resolve(QNetworkProxyQuery(QUrl("https://example.com/test")))
# See https://github.com/The-Compiler/qutebrowser/pull/1891#issuecomment-259222615 # See https://github.com/qutebrowser/qutebrowser/pull/1891#issuecomment-259222615
try: try:
from PyQt5 import QtWebEngineWidgets from PyQt5 import QtWebEngineWidgets

8
tests/unit/commands/test_cmdutils.py
View File

@ -307,7 +307,7 @@ class TestRegister:
fun(*args, **kwargs) fun(*args, **kwargs)
def test_choices_no_annotation(self): def test_choices_no_annotation(self):
# https://github.com/The-Compiler/qutebrowser/issues/1871 # https://github.com/qutebrowser/qutebrowser/issues/1871
@cmdutils.register() @cmdutils.register()
@cmdutils.argument('arg', choices=['foo', 'bar']) @cmdutils.argument('arg', choices=['foo', 'bar'])
def fun(arg): def fun(arg):
@ -321,7 +321,7 @@ class TestRegister:
cmd._get_call_args(win_id=0) cmd._get_call_args(win_id=0)
def test_choices_no_annotation_kwonly(self): def test_choices_no_annotation_kwonly(self):
# https://github.com/The-Compiler/qutebrowser/issues/1871 # https://github.com/qutebrowser/qutebrowser/issues/1871
@cmdutils.register() @cmdutils.register()
@cmdutils.argument('arg', choices=['foo', 'bar']) @cmdutils.argument('arg', choices=['foo', 'bar'])
def fun(*, arg='foo'): def fun(*, arg='foo'):
@ -350,7 +350,7 @@ class TestRegister:
cmd.get_pos_arg_info(2) cmd.get_pos_arg_info(2)
def test_keyword_only_without_default(self): def test_keyword_only_without_default(self):
# https://github.com/The-Compiler/qutebrowser/issues/1872 # https://github.com/qutebrowser/qutebrowser/issues/1872
def fun(*, target): def fun(*, target):
"""Blah.""" """Blah."""
pass pass
@ -363,7 +363,7 @@ class TestRegister:
assert str(excinfo.value) == expected assert str(excinfo.value) == expected
def test_typed_keyword_only_without_default(self): def test_typed_keyword_only_without_default(self):
# https://github.com/The-Compiler/qutebrowser/issues/1872 # https://github.com/qutebrowser/qutebrowser/issues/1872
def fun(*, target: int): def fun(*, target: int):
"""Blah.""" """Blah."""
pass pass

6
tests/unit/commands/test_runners.py
View File

@ -31,7 +31,7 @@ class TestCommandRunner:
def test_parse_all(self, cmdline_test): def test_parse_all(self, cmdline_test):
"""Test parsing of commands. """Test parsing of commands.
See https://github.com/The-Compiler/qutebrowser/issues/615 See https://github.com/qutebrowser/qutebrowser/issues/615
Args: Args:
cmdline_test: A pytest fixture which provides testcases. cmdline_test: A pytest fixture which provides testcases.
@ -57,8 +57,8 @@ class TestCommandRunner:
def test_parse_empty_with_alias(self, command): def test_parse_empty_with_alias(self, command):
"""An empty command should not crash. """An empty command should not crash.
See https://github.com/The-Compiler/qutebrowser/issues/1690 See https://github.com/qutebrowser/qutebrowser/issues/1690
and https://github.com/The-Compiler/qutebrowser/issues/1773 and https://github.com/qutebrowser/qutebrowser/issues/1773
""" """
cr = runners.CommandRunner(0) cr = runners.CommandRunner(0)
with pytest.raises(cmdexc.NoSuchCommandError): with pytest.raises(cmdexc.NoSuchCommandError):

4
tests/unit/config/test_config.py
View File

@ -136,7 +136,7 @@ class TestConfigParser:
This is done during interpolation in later Python 3.4 versions. This is done during interpolation in later Python 3.4 versions.
See https://github.com/The-Compiler/qutebrowser/issues/968 See https://github.com/qutebrowser/qutebrowser/issues/968
""" """
assert objects.cfg.get('general', 'blabla', fallback='blub') == 'blub' assert objects.cfg.get('general', 'blabla', fallback='blub') == 'blub'
@ -247,7 +247,7 @@ class TestKeyConfigParser:
def test_cmd_binding(self, cmdline_test, config_stub, tmpdir): def test_cmd_binding(self, cmdline_test, config_stub, tmpdir):
"""Test various command bindings. """Test various command bindings.
See https://github.com/The-Compiler/qutebrowser/issues/615 See https://github.com/qutebrowser/qutebrowser/issues/615
Args: Args:
cmdline_test: A pytest fixture which provides testcases. cmdline_test: A pytest fixture which provides testcases.

2
tests/unit/keyinput/test_modeman.py
View File

@ -47,7 +47,7 @@ def modeman(mode_manager):
@pytest.mark.parametrize('key, modifiers, text, filtered', [ @pytest.mark.parametrize('key, modifiers, text, filtered', [
(Qt.Key_A, Qt.NoModifier, 'a', True), (Qt.Key_A, Qt.NoModifier, 'a', True),
(Qt.Key_Up, Qt.NoModifier, '', False), (Qt.Key_Up, Qt.NoModifier, '', False),
# https://github.com/The-Compiler/qutebrowser/issues/1207 # https://github.com/qutebrowser/qutebrowser/issues/1207
(Qt.Key_A, Qt.ShiftModifier, 'A', True), (Qt.Key_A, Qt.ShiftModifier, 'A', True),
(Qt.Key_A, Qt.ShiftModifier | Qt.ControlModifier, 'x', False), (Qt.Key_A, Qt.ShiftModifier | Qt.ControlModifier, 'x', False),
]) ])

6
tests/unit/mainwindow/statusbar/test_progress.py
View File

@ -77,8 +77,8 @@ def test_tab_changed(fake_web_tab, progress_widget, progress, load_status,
def test_progress_affecting_statusbar_height(fake_statusbar, progress_widget): def test_progress_affecting_statusbar_height(fake_statusbar, progress_widget):
"""Make sure the statusbar stays the same height when progress is shown. """Make sure the statusbar stays the same height when progress is shown.
https://github.com/The-Compiler/qutebrowser/issues/886 https://github.com/qutebrowser/qutebrowser/issues/886
https://github.com/The-Compiler/qutebrowser/pull/890 https://github.com/qutebrowser/qutebrowser/pull/890
""" """
expected_height = fake_statusbar.fontMetrics().height() expected_height = fake_statusbar.fontMetrics().height()
assert fake_statusbar.height() == expected_height assert fake_statusbar.height() == expected_height
@ -92,7 +92,7 @@ def test_progress_affecting_statusbar_height(fake_statusbar, progress_widget):
def test_progress_big_statusbar(qtbot, fake_statusbar, progress_widget): def test_progress_big_statusbar(qtbot, fake_statusbar, progress_widget):
"""Make sure the progress bar is small with a big statusbar. """Make sure the progress bar is small with a big statusbar.
https://github.com/The-Compiler/qutebrowser/commit/46d1760798b730852e2207e2cdc05a9308e44f80 https://github.com/qutebrowser/qutebrowser/commit/46d1760798b730852e2207e2cdc05a9308e44f80
""" """
fake_statusbar.hbox.addWidget(progress_widget) fake_statusbar.hbox.addWidget(progress_widget)
progress_widget.show() progress_widget.show()

6
tests/unit/misc/test_ipc.py
View File

@ -443,7 +443,7 @@ class TestHandleConnection:
def connected_socket(qtbot, qlocalsocket, ipc_server): def connected_socket(qtbot, qlocalsocket, ipc_server):
if sys.platform == 'darwin': if sys.platform == 'darwin':
pytest.skip("Skipping connected_socket test - " pytest.skip("Skipping connected_socket test - "
"https://github.com/The-Compiler/qutebrowser/issues/1045") "https://github.com/qutebrowser/qutebrowser/issues/1045")
ipc_server.listen() ipc_server.listen()
with qtbot.waitSignal(ipc_server._server.newConnection): with qtbot.waitSignal(ipc_server._server.newConnection):
qlocalsocket.connectToServer('qute-test') qlocalsocket.connectToServer('qute-test')
@ -577,7 +577,7 @@ class TestSendToRunningInstance:
assert str(excinfo.value) == msg assert str(excinfo.value) == msg
@pytest.mark.not_osx(reason="https://github.com/The-Compiler/qutebrowser/" @pytest.mark.not_osx(reason="https://github.com/qutebrowser/qutebrowser/"
"issues/975") "issues/975")
def test_timeout(qtbot, caplog, qlocalsocket, ipc_server): def test_timeout(qtbot, caplog, qlocalsocket, ipc_server):
ipc_server._timer.setInterval(100) ipc_server._timer.setInterval(100)
@ -831,7 +831,7 @@ class TestSendOrListen:
@pytest.mark.windows @pytest.mark.windows
@pytest.mark.osx @pytest.mark.osx
def test_long_username(monkeypatch): def test_long_username(monkeypatch):
"""See https://github.com/The-Compiler/qutebrowser/issues/888.""" """See https://github.com/qutebrowser/qutebrowser/issues/888."""
username = 'alexandercogneau' username = 'alexandercogneau'
basedir = '/this_is_a_long_basedir' basedir = '/this_is_a_long_basedir'
monkeypatch.setattr('qutebrowser.misc.ipc.standarddir.getpass.getuser', monkeypatch.setattr('qutebrowser.misc.ipc.standarddir.getpass.getuser',

2
tests/unit/misc/test_readline.py
View File

@ -29,7 +29,7 @@ from qutebrowser.misc import readline
# Some functions aren't 100% readline compatible: # Some functions aren't 100% readline compatible:
# https://github.com/The-Compiler/qutebrowser/issues/678 # https://github.com/qutebrowser/qutebrowser/issues/678
# Those are marked with fixme and have another value marked with '# wrong' # Those are marked with fixme and have another value marked with '# wrong'
# which marks the current behavior. # which marks the current behavior.

2
tests/unit/misc/test_sessions.py
View File

@ -353,7 +353,7 @@ class TestLoadTab:
if in_main_data: if in_main_data:
# This information got saved in the main data instead of saving it # This information got saved in the main data instead of saving it
# per item - make sure the old format can still be read # per item - make sure the old format can still be read
# https://github.com/The-Compiler/qutebrowser/issues/728 # https://github.com/qutebrowser/qutebrowser/issues/728
d = {'history': [item], key: val} d = {'history': [item], key: val}
else: else:
item[key] = val item[key] = val

2
tests/unit/utils/test_debug.py
View File

@ -157,7 +157,7 @@ class TestQFlagsKey:
"""Tests for qutebrowser.utils.debug.qflags_key. """Tests for qutebrowser.utils.debug.qflags_key.
https://github.com/The-Compiler/qutebrowser/issues/42 https://github.com/qutebrowser/qutebrowser/issues/42
""" """
fixme = pytest.mark.xfail(reason="See issue #42", raises=AssertionError) fixme = pytest.mark.xfail(reason="See issue #42", raises=AssertionError)

2
tests/unit/utils/test_error.py
View File

@ -67,7 +67,7 @@ def test_no_err_windows(caplog, exc, name, exc_text, fake_args):
# This happens on Xvfb for some reason # This happens on Xvfb for some reason
# See https://github.com/The-Compiler/qutebrowser/issues/984 # See https://github.com/qutebrowser/qutebrowser/issues/984
@pytest.mark.qt_log_ignore(r'^QXcbConnection: XCB error: 8 \(BadMatch\), ' @pytest.mark.qt_log_ignore(r'^QXcbConnection: XCB error: 8 \(BadMatch\), '
r'sequence: \d+, resource id: \d+, major code: 42 ' r'sequence: \d+, resource id: \d+, major code: 42 '
r'\(SetInputFocus\), minor code: 0$', r'\(SetInputFocus\), minor code: 0$',

2
tests/unit/utils/test_jinja.py
View File

@ -120,7 +120,7 @@ def test_utf8():
This was an attempt to get a failing test case for #127 but it seems This was an attempt to get a failing test case for #127 but it seems
the issue is elsewhere. the issue is elsewhere.
https://github.com/The-Compiler/qutebrowser/issues/127 https://github.com/qutebrowser/qutebrowser/issues/127
""" """
data = jinja.render('test.html', var='\u2603') data = jinja.render('test.html', var='\u2603')
assert data == "Hello \u2603" assert data == "Hello \u2603"

2
tests/unit/utils/test_log.py
View File

@ -68,7 +68,7 @@ def restore_loggers():
root_logger.setLevel(original_logging_level) root_logger.setLevel(original_logging_level)
for h in root_handlers: for h in root_handlers:
if not isinstance(h, pytest_catchlog.LogCaptureHandler): if not isinstance(h, pytest_catchlog.LogCaptureHandler):
# https://github.com/The-Compiler/qutebrowser/issues/856 # https://github.com/qutebrowser/qutebrowser/issues/856
root_logger.addHandler(h) root_logger.addHandler(h)
logging._acquireLock() logging._acquireLock()
try: try:

2
tests/unit/utils/test_qtutils.py
View File

@ -512,7 +512,7 @@ class TestSavefileOpen:
def test_line_endings(self, tmpdir): def test_line_endings(self, tmpdir):
"""Make sure line endings are translated correctly. """Make sure line endings are translated correctly.
See https://github.com/The-Compiler/qutebrowser/issues/309 See https://github.com/qutebrowser/qutebrowser/issues/309
""" """
filename = tmpdir / 'foo' filename = tmpdir / 'foo'
with qtutils.savefile_open(str(filename)) as f: with qtutils.savefile_open(str(filename)) as f:

2
tests/unit/utils/test_standarddir.py
View File

@ -271,7 +271,7 @@ class TestCreatingDir:
def test_exists_race_condition(self, mocker, tmpdir, typ): def test_exists_race_condition(self, mocker, tmpdir, typ):
"""Make sure there can't be a TOCTOU issue when creating the file. """Make sure there can't be a TOCTOU issue when creating the file.
See https://github.com/The-Compiler/qutebrowser/issues/942. See https://github.com/qutebrowser/qutebrowser/issues/942.
""" """
(tmpdir / typ).ensure(dir=True) (tmpdir / typ).ensure(dir=True)

4
www/header.asciidoc
View File

@ -13,8 +13,8 @@
<a href="/INSTALL.html">Install</a> <a href="/INSTALL.html">Install</a>
<a href="/CHANGELOG.html">Changelog</a> <a href="/CHANGELOG.html">Changelog</a>
<a href="/CONTRIBUTING.html">Contributing</a> <a href="/CONTRIBUTING.html">Contributing</a>
<a href="https://www.github.com/The-Compiler/qutebrowser">GitHub</a> <a href="https://www.github.com/qutebrowser/qutebrowser">GitHub</a>
<a href="https://github.com/The-Compiler/qutebrowser/releases">Releases</a> <a href="https://github.com/qutebrowser/qutebrowser/releases">Releases</a>
<a href="http://blog.qutebrowser.org/">Blog</a> <a href="http://blog.qutebrowser.org/">Blog</a>
</div> </div>
+++ +++