rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Show hidden commands in help completion.

Browse Source 
Hidden commands are not shown in command completion as they typically
would not be run directly. However, a user might still might like to see
help for them if, for example, they are writing a script or creating a
binding.

Addresses #1707.
This commit is contained in:
Ryan Roden-Corrent 2016-08-01 12:11:26 -04:00
parent 81eb53a152
commit dd9470af94
2 changed files with 5 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qutebrowser/completion/models/miscmodels.py
View File

@ -75,7 +75,7 @@ class HelpCompletionModel(base.BaseCompletionModel):
assert cmdutils.cmd_dict assert cmdutils.cmd_dict
cmdlist = [] cmdlist = []
for obj in set(cmdutils.cmd_dict.values()): for obj in set(cmdutils.cmd_dict.values()):
if (obj.hide or (obj.debug and not objreg.get('args').debug) or if ((obj.debug and not objreg.get('args').debug) or
obj.deprecated): obj.deprecated):
pass pass
else: else:

5
tests/unit/completion/test_models.py
View File

@ -193,7 +193,7 @@ def test_help_completion(qtmodeltester, monkeypatch, stubs):
"""Test the results of command completion. """Test the results of command completion.
Validates that: Validates that:
- only non-hidden and non-deprecated commands are included - only non-deprecated commands are included
- commands are sorted by name - commands are sorted by name
- the command description is shown in the desc column - the command description is shown in the desc column
- the binding (if any) is shown in the misc column - the binding (if any) is shown in the misc column
@ -211,8 +211,9 @@ def test_help_completion(qtmodeltester, monkeypatch, stubs):
assert actual == [ assert actual == [
("Commands", [ ("Commands", [
(':drop', 'drop all user data', ''), (':drop', 'drop all user data', ''),
(':hide', '', ''),
(':roll', 'never gonna give you up', ''), (':roll', 'never gonna give you up', ''),
(':stop', 'stop qutebrowser', '') (':stop', 'stop qutebrowser', ''),
]), ]),
("Settings", [ ("Settings", [
('general->time', 'Is an illusion.', ''), ('general->time', 'Is an illusion.', ''),