From 1de465f42bbd1fe1152f24e0f47e2589fb6ddf29 Mon Sep 17 00:00:00 2001 From: Ryan Roden-Corrent Date: Wed, 10 Aug 2016 10:20:04 -0400 Subject: [PATCH 1/2] Filter buffer completion by all columns. In addition to the url and text column, also filter by the index column so the user can enter a number to navigate to that tab. Resolves #1830. --- qutebrowser/completion/models/miscmodels.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/qutebrowser/completion/models/miscmodels.py b/qutebrowser/completion/models/miscmodels.py index aeb9478f0..14a48c399 100644 --- a/qutebrowser/completion/models/miscmodels.py +++ b/qutebrowser/completion/models/miscmodels.py @@ -148,7 +148,8 @@ class TabCompletionModel(base.BaseCompletionModel): def __init__(self, parent=None): super().__init__(parent) - self.columns_to_filter = [self.URL_COLUMN, self.TEXT_COLUMN] + self.columns_to_filter = [self.IDX_COLUMN, self.URL_COLUMN, + self.TEXT_COLUMN] for win_id in objreg.window_registry: tabbed_browser = objreg.get('tabbed-browser', scope='window', From 082e8da1441c3b58169e8c946113ce98c87a1876 Mon Sep 17 00:00:00 2001 From: Florian Bruhin Date: Wed, 10 Aug 2016 16:58:26 +0200 Subject: [PATCH 2/2] Update changelog --- CHANGELOG.asciidoc | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.asciidoc b/CHANGELOG.asciidoc index 9652f9b41..744cf8d8b 100644 --- a/CHANGELOG.asciidoc +++ b/CHANGELOG.asciidoc @@ -60,6 +60,7 @@ Changed configured with the new `new-instance-open-target.window` setting. - Word hints now are more clever about getting the element text from some elements. - Completions for `:help` and `:bind` now also show hidden commands +- The `:buffer` completion now also filters using the first column (id). Removed ~~~~~~~