rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Rewrite test_crashdialog.py to use pytest.

Browse Source 
See #660.
This commit is contained in:
Florian Bruhin 2015-05-10 15:27:35 +02:00
parent 392fb3e1d7
commit db0a54b03f
1 changed files with 5 additions and 15 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
tests/misc/test_crashdialog.py
View File

@ -19,8 +19,6 @@
"""Tests for qutebrowser.misc.crashdialog.""" """Tests for qutebrowser.misc.crashdialog."""
import unittest
from qutebrowser.misc import crashdialog from qutebrowser.misc import crashdialog
@ -52,7 +50,7 @@ Hello world!
""" """
class ParseFatalStacktraceTests(unittest.TestCase): class TestParseFatalStacktrace:
"""Tests for parse_fatal_stacktrace.""" """Tests for parse_fatal_stacktrace."""
@ -60,30 +58,22 @@ class ParseFatalStacktraceTests(unittest.TestCase):
"""Test parse_fatal_stacktrace with a valid text.""" """Test parse_fatal_stacktrace with a valid text."""
text = VALID_CRASH_TEXT.strip().replace('_', ' ') text = VALID_CRASH_TEXT.strip().replace('_', ' ')
typ, func = crashdialog.parse_fatal_stacktrace(text) typ, func = crashdialog.parse_fatal_stacktrace(text)
self.assertEqual(typ, "Segmentation fault") assert (typ, func) == ("Segmentation fault", 'testfunc')
self.assertEqual(func, 'testfunc')
def test_valid_text_thread(self): def test_valid_text_thread(self):
"""Test parse_fatal_stacktrace with a valid text #2.""" """Test parse_fatal_stacktrace with a valid text #2."""
text = VALID_CRASH_TEXT_THREAD.strip().replace('_', ' ') text = VALID_CRASH_TEXT_THREAD.strip().replace('_', ' ')
typ, func = crashdialog.parse_fatal_stacktrace(text) typ, func = crashdialog.parse_fatal_stacktrace(text)
self.assertEqual(typ, "Segmentation fault") assert (typ, func) == ("Segmentation fault", 'testfunc')
self.assertEqual(func, 'testfunc')
def test_valid_text_empty(self): def test_valid_text_empty(self):
"""Test parse_fatal_stacktrace with a valid text but empty function.""" """Test parse_fatal_stacktrace with a valid text but empty function."""
text = VALID_CRASH_TEXT_EMPTY.strip().replace('_', ' ') text = VALID_CRASH_TEXT_EMPTY.strip().replace('_', ' ')
typ, func = crashdialog.parse_fatal_stacktrace(text) typ, func = crashdialog.parse_fatal_stacktrace(text)
self.assertEqual(typ, 'Aborted') assert (typ, func) == ('Aborted', '')
self.assertEqual(func, '')
def test_invalid_text(self): def test_invalid_text(self):
"""Test parse_fatal_stacktrace with an invalid text.""" """Test parse_fatal_stacktrace with an invalid text."""
text = INVALID_CRASH_TEXT.strip().replace('_', ' ') text = INVALID_CRASH_TEXT.strip().replace('_', ' ')
typ, func = crashdialog.parse_fatal_stacktrace(text) typ, func = crashdialog.parse_fatal_stacktrace(text)
self.assertEqual(typ, '') assert (typ, func) == ('', '')
self.assertEqual(func, '')
if __name__ == '__main__':
unittest.main()