rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

urlmatch: Get rid of scheme whitelist

Browse Source 
There are more schemes like data: or javascript:, and we don't want to restrict
schemes anyways.
This commit is contained in:
Florian Bruhin 2018-02-15 17:16:20 +01:00
parent 28aadc4f96
commit dae164abee
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
qutebrowser/utils/urlmatch.py
View File

@ -42,9 +42,6 @@ class UrlPattern:
"""A Chromium-like URL matching pattern. """A Chromium-like URL matching pattern.
Class attributes:
SCHEMES: Schemes which are allowed in patterns.
Attributes: Attributes:
_pattern: The given pattern as string. _pattern: The given pattern as string.
_match_all: Whether the pattern should match all URLs. _match_all: Whether the pattern should match all URLs.
@ -59,8 +56,6 @@ class UrlPattern:
_port: The port to match to as integer, or None for any port. _port: The port to match to as integer, or None for any port.
""" """
SCHEMES = ['https', 'http', 'ftp', 'file', 'chrome', 'qute', 'about']
def __init__(self, pattern): def __init__(self, pattern):
# Make sure all attributes are initialized if we exit early. # Make sure all attributes are initialized if we exit early.
self._pattern = pattern self._pattern = pattern
@ -116,8 +111,6 @@ class UrlPattern:
elif parsed.scheme == 'any': elif parsed.scheme == 'any':
self._scheme = None self._scheme = None
return return
elif parsed.scheme not in self.SCHEMES:
raise ParseError("Unknown scheme {}".format(parsed.scheme))
self._scheme = parsed.scheme self._scheme = parsed.scheme
@ -186,8 +179,6 @@ class UrlPattern:
return utils.get_repr(self, pattern=self._pattern, constructor=True) return utils.get_repr(self, pattern=self._pattern, constructor=True)
def _matches_scheme(self, scheme): def _matches_scheme(self, scheme):
if scheme not in self.SCHEMES:
return False
return self._scheme is None or self._scheme == scheme return self._scheme is None or self._scheme == scheme
def _matches_host(self, host): def _matches_host(self, host):