pylint: Disable protected-access for tests.

scripts/dev/run_pylint_on_tests.py

@@ -52,6 +52,7 @@ def main():
         'redefined-outer-name',
         'unused-argument',
         'missing-docstring',
+        'protected-access',
         # https://bitbucket.org/logilab/pylint/issue/511/
         'undefined-variable',
     ]

tests/browser/test_webelem.py

@@ -17,8 +17,6 @@
 # You should have received a copy of the GNU General Public License
 # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
 
-# pylint: disable=protected-access
-
 """Tests for the webelement utils."""
 
 from unittest import mock

tests/config/test_config.py

@@ -16,8 +16,6 @@
 # You should have received a copy of the GNU General Public License
 # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
 
-# pylint: disable=protected-access
-
 """Tests for qutebrowser.config.config."""
 
 import os

tests/config/test_configtypes.py

@@ -16,8 +16,6 @@
 # You should have received a copy of the GNU General Public License
 # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
 
-# pylint: disable=protected-access
-
 """Tests for qutebrowser.config.configtypes."""
 
 import re

tests/keyinput/test_basekeyparser.py

@@ -17,8 +17,6 @@
 # You should have received a copy of the GNU General Public License
 # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
 
-# pylint: disable=protected-access
-
 """Tests for BaseKeyParser."""
 
 import sys

tests/keyinput/test_modeparsers.py

@@ -39,8 +39,6 @@ class TestsNormalKeyParser:
         kp: The NormalKeyParser to be tested.
     """
 
-    # pylint: disable=protected-access
-
     @pytest.yield_fixture(autouse=True)
     def setup(self, monkeypatch, stubs, config_stub, fake_keyconfig):
         """Set up mocks and read the test config."""

tests/mainwindow/statusbar/test_textbase.py

@@ -50,4 +50,4 @@ def test_elided_text(qtbot, elidemode, check):
     label.setText(long_string)
     label.resize(100, 50)
     label.show()
-    assert check(label._elided_text)  # pylint: disable=protected-access
+    assert check(label._elided_text)

tests/misc/test_editor.py

@@ -19,8 +19,6 @@
 
 """Tests for qutebrowser.misc.editor."""
 
-# pylint: disable=protected-access
-
 import os
 import os.path
 import logging
@@ -46,7 +44,7 @@ class TestArg:
                             stubs.fake_qprocess())
         self.editor = editor.ExternalEditor(0)
         yield
-        self.editor._cleanup()  # pylint: disable=protected-access
+        self.editor._cleanup()
 
     @pytest.fixture
     def stubbed_config(self, config_stub, monkeypatch):
@@ -229,7 +227,7 @@ class TestErrorMessage:
         monkeypatch.setattr('qutebrowser.misc.editor.config', config_stub)
         self.editor = editor.ExternalEditor(0)
         yield
-        self.editor._cleanup()  # pylint: disable=protected-access
+        self.editor._cleanup()
 
     def test_proc_error(self, caplog):
         """Test on_proc_error."""

tests/misc/test_guiprocess.py

@@ -17,8 +17,6 @@
 # You should have received a copy of the GNU General Public License
 # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
 
-# pylint: disable=protected-access
-
 """Tests for qutebrowser.misc.guiprocess."""
 
 import os

tests/misc/test_lineparser.py

@@ -17,8 +17,6 @@
 # You should have received a copy of the GNU General Public License
 # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
 
-# pylint: disable=protected-access
-
 """Tests for qutebrowser.misc.lineparser."""
 
 import io

tests/misc/test_readline.py

@@ -19,8 +19,6 @@
 
 """Tests for qutebrowser.misc.readline."""
 
-# pylint: disable=protected-access
-
 import re
 import inspect
 

tests/utils/test_log.py

@@ -17,8 +17,6 @@
 # You should have received a copy of the GNU General Public License
 # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
 
-# pylint: disable=protected-access
-
 """Tests for qutebrowser.utils.log."""
 
 import logging

tests/utils/test_qtutils.py

@@ -928,8 +928,6 @@ class TestEventLoop:
         loop: The EventLoop we're testing.
     """
 
-    # pylint: disable=protected-access
-
     def _assert_executing(self):
         """Slot which gets called from timers to be sure the loop runs."""
         assert self.loop._executing

tests/utils/test_standarddir.py

@@ -17,8 +17,6 @@
 # You should have received a copy of the GNU General Public License
 # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
 
-# pylint: disable=protected-access
-
 """Tests for qutebrowser.utils.standarddir."""
 
 import os

tests/utils/test_urlutils.py

@@ -17,8 +17,6 @@
 # You should have received a copy of the GNU General Public License
 # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
 
-# pylint: disable=protected-access
-
 """Tests for qutebrowser.utils.urlutils."""
 
 import os.path

tests/utils/test_version.py

@@ -17,8 +17,6 @@
 # You should have received a copy of the GNU General Public License
 # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
 
-# pylint: disable=protected-access
-
 """Tests for qutebrowser.utils.version."""
 
 import io

tests/utils/usertypes/test_neighborlist.py

@@ -17,8 +17,6 @@
 # You should have received a copy of the GNU General Public License
 # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
 
-# pylint: disable=protected-access
-
 """Tests for the NeighborList class."""
 
 from qutebrowser.utils import usertypes

tests/utils/usertypes/test_timer.py

@@ -17,8 +17,6 @@
 # You should have received a copy of the GNU General Public License
 # along with qutebrowser.  If not, see <http://www.gnu.org/licenses/>.
 
-# pylint: disable=protected-access
-
 """Tests for Timer."""
 
 from qutebrowser.utils import usertypes