rnhmjoj/qutebrowser
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Allow :open-editor in modes other than insert

Browse Source 
':open-editor' can now be run in all modes.

Resolves #1902
This commit is contained in:
Ján Kobezda 2016-09-04 22:23:16 +02:00
parent 7a98af4c2f
commit da65f7234a
2 changed files with 28 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
qutebrowser/browser/commands.py
View File

@ -1472,8 +1472,8 @@ class CommandDispatcher:
self.on_editing_finished, elem)) self.on_editing_finished, elem))
ed.edit(text) ed.edit(text)
@cmdutils.register(instance='command-dispatcher', @cmdutils.register(instance='command-dispatcher', hide=True,
modes=[KeyMode.insert], hide=True, scope='window') scope='window')
def open_editor(self): def open_editor(self):
"""Open an external editor with the currently selected form field. """Open an external editor with the currently selected form field.

26
tests/end2end/features/editor.feature
View File

@ -67,3 +67,29 @@ Feature: Opening external editors
And I wait for "Read back: foobar" in the log And I wait for "Read back: foobar" in the log
And I run :click-element id qute-button And I run :click-element id qute-button
Then the javascript message "text: foobar" should be logged Then the javascript message "text: foobar" should be logged
Scenario: Spawning an editor in normal mode
When I set up a fake editor returning "foobar"
And I open data/editor.html
And I run :click-element id qute-textarea
And I wait for "Clicked editable element!" in the log
And I run :leave-mode
And I wait for "Leaving mode KeyMode.insert (reason: leave current)" in the log
And I run :open-editor
And I wait for "Read back: foobar" in the log
And I run :click-element id qute-button
Then the javascript message "text: foobar" should be logged
Scenario: Spawning an editor in caret mode
When I set up a fake editor returning "foobar"
And I open data/editor.html
And I run :click-element id qute-textarea
And I wait for "Clicked editable element!" in the log
And I run :leave-mode
And I wait for "Leaving mode KeyMode.insert (reason: leave current)" in the log
And I run :enter-mode caret
And I wait for "Entering mode KeyMode.caret (reason: command)" in the log
And I run :open-editor
And I wait for "Read back: foobar" in the log
And I run :click-element id qute-button
Then the javascript message "text: foobar" should be logged