From d7d577b1fa1fc90ab433b42e88f439c09ea83b69 Mon Sep 17 00:00:00 2001 From: Daniel Schadt Date: Mon, 23 Nov 2015 23:06:07 +0100 Subject: [PATCH] Fix pep8/pylint --- qutebrowser/browser/network/qutescheme.py | 1 - qutebrowser/browser/pdfjs.py | 2 +- qutebrowser/browser/webpage.py | 2 ++ scripts/dev/update_3rdparty.py | 3 +-- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/qutebrowser/browser/network/qutescheme.py b/qutebrowser/browser/network/qutescheme.py index 4b0b68ee8..083048e7d 100644 --- a/qutebrowser/browser/network/qutescheme.py +++ b/qutebrowser/browser/network/qutescheme.py @@ -34,7 +34,6 @@ import configparser from PyQt5.QtCore import pyqtSlot, QObject from PyQt5.QtNetwork import QNetworkReply -from PyQt5.QtWebKit import QWebSecurityOrigin import qutebrowser from qutebrowser.browser import pdfjs diff --git a/qutebrowser/browser/pdfjs.py b/qutebrowser/browser/pdfjs.py index 1c721979f..5d5e8aa00 100644 --- a/qutebrowser/browser/pdfjs.py +++ b/qutebrowser/browser/pdfjs.py @@ -107,7 +107,7 @@ def get_pdfjs_res(path): # First try a system wide installation # System installations might strip off the 'build/' or 'web/' prefixes. # qute expects them, so we need to adjust for it. - names_to_try = [path, path[path.index('/')+1:]] + names_to_try = [path, path[path.index('/') + 1:]] for system_path in SYSTEM_PDFJS_PATHS: content = _read_from_system(system_path, names_to_try) if content is not None: diff --git a/qutebrowser/browser/webpage.py b/qutebrowser/browser/webpage.py index be24a7fe0..137131c1f 100644 --- a/qutebrowser/browser/webpage.py +++ b/qutebrowser/browser/webpage.py @@ -223,6 +223,8 @@ class BrowserPage(QWebPage): try: page = pdfjs.generate_pdfjs_page(reply.url()).encode('utf-8') except pdfjs.PDFJSNotFound: + # pylint: disable=no-member + # Instance of 'str' has no 'render' member (no-member) page = (jinja.env.get_template('no_pdfjs.html') .render(url=reply.url().toDisplayString()) .encode('utf-8')) diff --git a/scripts/dev/update_3rdparty.py b/scripts/dev/update_3rdparty.py index bb9d70013..35571728f 100755 --- a/scripts/dev/update_3rdparty.py +++ b/scripts/dev/update_3rdparty.py @@ -43,6 +43,7 @@ def get_latest_pdfjs_url(): def update_pdfjs(): + """Download and extract the latest pdf.js version.""" version, url = get_latest_pdfjs_url() target_path = os.path.join('qutebrowser', '3rdparty', 'pdfjs') print("=> Downloading pdf.js {}".format(version)) @@ -56,8 +57,6 @@ def update_pdfjs(): shutil.unpack_archive(archive, target_path, 'zip') - - def main(): update_pdfjs()